chrisandchris/passive-record-orm

View on GitHub

Showing 161 of 161 total issues

Method init has 354 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function init()
    {
        $this->snippets = [
            'select'         => function () {
                return [

    Method init has 330 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function init()
        {
            $this->snippets = [
                'select'     => function () {
                    return [

      File Builder.php has 580 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      namespace ChrisAndChris\Common\RowMapperBundle\Services\Query;
      
      use ChrisAndChris\Common\RowMapperBundle\Exceptions\MalformedQueryException;
      use ChrisAndChris\Common\RowMapperBundle\Exceptions\MissingParameterException;
      Severity: Major
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 1 day to fix

        Method init has 215 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function init()
            {
                $this->types = [
                    'alias'          => [
                        'params'   => [

          Builder has 59 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Builder
          {
          
              /** @var array the statement */
              private $statement = [];
          Severity: Major
          Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 1 day to fix

            File BuilderTest.php has 515 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            namespace ChrisAndChris\Common\RowMapperBundle\Tests\Services\Query;
            
            use ChrisAndChris\Common\RowMapperBundle\Exceptions\MalformedQueryException;

              File ExtendedBuilderTest.php has 457 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              namespace ChrisAndChris\Common\RowMapperBundle\Tests\Services\Query;
              
              use ChrisAndChris\Common\RowMapperBundle\Exceptions\MalformedQueryException;
              use ChrisAndChris\Common\RowMapperBundle\Exceptions\MissingParameterException;

                Function init has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function init()
                    {
                        $this->snippets = [
                            'select'         => function () {
                                return [

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File MySqlBag.php has 409 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace ChrisAndChris\Common\RowMapperBundle\Services\Query\Parser\Snippets;
                
                use ChrisAndChris\Common\RowMapperBundle\Events\RowMapperEvents;

                  File PgSqlBag.php has 385 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  namespace ChrisAndChris\Common\RowMapperBundle\Services\Query\Parser\Snippets;
                  
                  use ChrisAndChris\Common\RowMapperBundle\Events\RowMapperEvents;

                    Function init has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function init()
                        {
                            $this->snippets = [
                                'select'     => function () {
                                    return [

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function append has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function append($typeName, array $params = [])
                        {
                            if ($this->allowAppend() && $this->typeBag->has($typeName)) {
                                $endParams = [];
                                $type = $this->typeBag->get($typeName);
                    Severity: Minor
                    Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    BuilderTest has 32 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class BuilderTest extends AbstractBuilderTest
                    {
                    
                        function testSimpleQuery()
                        {

                      File ConcreteModel.php has 333 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      namespace ChrisAndChris\Common\RowMapperBundle\Services\Model;
                      
                      use ChrisAndChris\Common\RowMapperBundle\Entity\Entity;

                        Method testFieldlist has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function testFieldlist()
                            {
                                $builder = $this->getBuilder();
                                $builder->fieldlist(
                                    [

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      'in'             => function (array $params) {
                                          if (is_array($params['in'])) {
                                              $code = '';
                                              $count = count($params['in']);
                                              for ($i = 0; $i < $count; $i++) {
                          src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php on lines 169..190

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 142.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      'in'         => function (array $params) {
                                          if (is_array($params['in'])) {
                                              $code = '';
                                              $count = count($params['in']);
                                              for ($i = 0; $i < $count; $i++) {
                          src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php on lines 200..221

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 142.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          ConcreteModel has 26 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class ConcreteModel
                          {
                          
                              /** @var ModelDependencyProvider the dependency provider */
                              protected $dependencyProvider;

                            File BusinessProcess.php has 290 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
                            declare(strict_types=1);
                            
                            namespace ChrisAndChris\Common\RowMapperBundle\Services;
                            
                            
                            Severity: Minor
                            Found in src/ChrisAndChris/Common/RowMapperBundle/Services/BusinessProcess.php - About 2 hrs to fix

                              Method testPrepareOptions has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function testPrepareOptions()
                                  {
                                      $model = $this->getModel();
                              
                                      $options = [
                                Severity
                                Category
                                Status
                                Source
                                Language