Sign upLogin

chrisandchris/passive-record-orm

View on GitHub
Star

Showing 161 of 161 total issues

Method testIf has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testIf()
    {
        $builder = $this->getBuilder();

        $builder->_if(true)
Severity: Minor
Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/ExtendedBuilderTest.php - About 1 hr to fix

    Method testNestedIf has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testNestedIf()
    {
        $builder = $this->getBuilder();

        // @formatter:off
    Severity: Minor
    Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/ExtendedBuilderTest.php - About 1 hr to fix

      Function testBags has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function testBags()
    {
        /*
         * Tests bags for desired behaviour, they must return a string to fulfil the test
         */
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/Parser/Snippets/GeneralBagTest.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  'insert'     => function (array $params) {
                $modes = [
                    'ignore',
                ];
                $mode = null;
      Severity: Major
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php and 1 other location - About 1 hr to fix
      src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php on lines 222..236

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  'insert'         => function (array $params) {
                $modes = [
                    'ignore',
                ];
                $mode = null;
      Severity: Major
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/MySqlBag.php and 1 other location - About 1 hr to fix
      src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Parser/Snippets/PgSqlBag.php on lines 191..204

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method getEntityFiller has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getEntityFiller() : \Closure
    {
        return
            function (
                Entity &$entity,
      Severity: Minor
      Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Mapper/RowMapper.php - About 1 hr to fix

        Method testNullParameters has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testNullParameters() {
        $parser = $this->getParser();
        $parser->setStatement(
            [
                [
        Severity: Minor
        Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/Parser/DefaultParserTest.php - About 1 hr to fix

          Method logIn has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function logIn($eventClass) : float
    {
        $trace = $this->getTraceInfo();

        $this->logger->info(sprintf(
          Severity: Minor
          Found in src/ChrisAndChris/Common/RowMapperBundle/Services/BusinessProcess.php - About 1 hr to fix

            Method getTraceInfo has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getTraceInfo(array $trace = null) : array
    {
        if ($trace === null) {
            $trace = debug_backtrace(0);
        }
            Severity: Minor
            Found in src/ChrisAndChris/Common/RowMapperBundle/Services/BusinessProcess.php - About 1 hr to fix

              Method testValuesStatement has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testValuesStatement()
    {
        $builder = $this->getBuilder();
        $fieldValues = [
            [
              Severity: Minor
              Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/ExtendedBuilderTest.php - About 1 hr to fix

                Function getTraceInfo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getTraceInfo(array $trace = null) : array
    {
        if ($trace === null) {
            $trace = debug_backtrace(0);
        }
                Severity: Minor
                Found in src/ChrisAndChris/Common/RowMapperBundle/Services/BusinessProcess.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getSqlQuery has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getSqlQuery(ParserInterface $parser = null)
    {
        if ($this->parser === null && $parser === null) {
            throw new SystemException('No parser given');
        }
                Severity: Minor
                Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method compareProperties has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function compareProperties($left, $right, array $properties)
    {
        if (!is_object($left) || !is_object($right)) {
            $this->fail('You must give me two objects');
        }
                Severity: Minor
                Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/TestKernel.php - About 1 hr to fix

                  Method testComparison has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function testComparison()
    {
        $tests = [
            '<=',
            '<',
                  Severity: Minor
                  Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/BuilderTest.php - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function testEventSubscriber()
    {
        $bag = new MySqlBag();

        $events = $bag->getSubscribedEvents();
                    Severity: Major
                    Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/Parser/Snippets/MySqlBagTest.php and 1 other location - About 1 hr to fix
                    src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/Parser/Snippets/PgSqlBagTest.php on lines 21..32

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 104.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function testEventSubscriber()
    {
        $bag = new PgSqlBag();

        $events = $bag->getSubscribedEvents();
                    Severity: Major
                    Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/Parser/Snippets/PgSqlBagTest.php and 1 other location - About 1 hr to fix
                    src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Query/Parser/Snippets/MySqlBagTest.php on lines 18..29

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 104.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method getSqlQuery has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getSqlQuery(ParserInterface $parser = null)
    {
        if ($this->parser === null && $parser === null) {
            throw new SystemException('No parser given');
        }
                    Severity: Minor
                    Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Query/Builder.php - About 1 hr to fix

                      Method testGetPdo has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function testGetPdo()
    {
        $pdo =
            $this->getMockBuilder('\ChrisAndChris\Common\RowMapperBundle\Services\Pdo\PdoLayer')
                 ->disableOriginalConstructor()
                      Severity: Minor
                      Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/Services/Pdo/PdoFactoryTest.php - About 1 hr to fix

                        Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function __construct(PdoLayer $layer, array $params = [])
    {
        // default connection defaults to write
        $this->connections['w'] = [$layer];
        $this->connections['r'] = [];
                        Severity: Minor
                        Found in src/ChrisAndChris/Common/RowMapperBundle/Services/Pdo/PdoFactory.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function compareProperties has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function compareProperties($left, $right, array $properties)
    {
        if (!is_object($left) || !is_object($right)) {
            $this->fail('You must give me two objects');
        }
                        Severity: Minor
                        Found in src/ChrisAndChris/Common/RowMapperBundle/Tests/TestKernel.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language