Sign upLogin

ckeditor/ckeditor5-widget

View on GitHub
Star

Showing 12 of 12 total issues

Function _updateToolbarsVisibility has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    _updateToolbarsVisibility() {
        let maxRelatedElementDepth = 0;
        let deepestRelatedElement = null;
        let deepestToolbarDefinition = null;
Severity: Minor
Found in src/widgettoolbarrepository.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _proposeNewSize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _proposeNewSize( domEventData ) {
        const state = this.state;
        const currentCoordinates = extractCoordinates( domEventData );
        const isCentered = this._options.isCentered ? this._options.isCentered( this ) : true;
Severity: Minor
Found in src/widgetresize/resizer.js - About 1 hr to fix

    Function init has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        init() {
        const view = this.editor.editing.view;
        const viewDocument = view.document;

        /**
    Severity: Minor
    Found in src/widget.js - About 1 hr to fix

      Function _handleArrowKeys has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          _handleArrowKeys( isForward ) {
        const model = this.editor.model;
        const schema = model.schema;
        const modelDocument = model.document;
        const modelSelection = modelDocument.selection;
      Severity: Minor
      Found in src/widget.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _onMousedown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _onMousedown( eventInfo, domEventData ) {
        const editor = this.editor;
        const view = editor.editing.view;
        const viewDocument = view.document;
        let element = domEventData.target;
      Severity: Minor
      Found in src/widget.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( oldTop !== newTop && !compareDescriptors( oldTop, newTop ) ) {
            this.fire( 'change:top', {
                oldDescriptor: oldTop,
                newDescriptor: newTop,
                writer
        Severity: Minor
        Found in src/highlightstack.js and 1 other location - About 50 mins to fix
        src/highlightstack.js on lines 72..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( oldTop !== newTop && !compareDescriptors( oldTop, newTop ) ) {
            this.fire( 'change:top', {
                oldDescriptor: oldTop,
                newDescriptor: newTop,
                writer
        Severity: Minor
        Found in src/highlightstack.js and 1 other location - About 50 mins to fix
        src/highlightstack.js on lines 48..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function _onMousedown has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            _onMousedown( eventInfo, domEventData ) {
        const editor = this.editor;
        const view = editor.editing.view;
        const viewDocument = view.document;
        let element = domEventData.target;
        Severity: Minor
        Found in src/widget.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findOptimalInsertionPosition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function findOptimalInsertionPosition( selection, model ) {
    const selectedElement = selection.getSelectedElement();

    if ( selectedElement && model.schema.isBlock( selectedElement ) ) {
        return model.createPositionAfter( selectedElement );
        Severity: Minor
        Found in src/utils.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return selection.focus;
        Severity: Major
        Found in src/utils.js - About 30 mins to fix

          Function isInsideNestedEditable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function isInsideNestedEditable( element ) {
    while ( element ) {
        if ( element.is( 'editableElement' ) && !element.is( 'rootElement' ) ) {
            return true;
        }
          Severity: Minor
          Found in src/widget.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _proposeNewSize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              _proposeNewSize( domEventData ) {
        const state = this.state;
        const currentCoordinates = extractCoordinates( domEventData );
        const isCentered = this._options.isCentered ? this._options.isCentered( this ) : true;
          Severity: Minor
          Found in src/widgetresize/resizer.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language