Sign upLogin

cloudfoundry-community/bosh-cloudstack-cpi

View on GitHub
Star
go_agent/src/code.google.com/p/go.tools/pointer/reflect.go

Summary

Maintainability
F
3 days
Test Coverage

File reflect.go has 1178 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package pointer

// This file implements the generation and resolution rules for
// constraints arising from the use of reflection in the target
// program.  See doc.go for explanation of the representation.
Severity: Major
Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go - About 2 days to fix

    Method rVCallConstraint.solve has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *rVCallConstraint) solve(a *analysis, _ *node, delta nodeset) {
    if c.targets == 0 {
        panic("no targets")
    }
    Severity: Minor
    Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reflectCallImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func reflectCallImpl(a *analysis, cgn *cgnode, site *callsite, recv, arg nodeid, dotdotdot bool) nodeid {
    Severity: Minor
    Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ext۰reflect۰rtype۰MethodByName(a *analysis, cgn *cgnode) {
    // If we have access to the callsite,
    // and the argument is a string constant,
    // return only that method.
    var name string
      Severity: Major
      Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go and 1 other location - About 1 hr to fix
      go_agent/src/code.google.com/p/go.tools/pointer/reflect.go on lines 1389..1406

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 178.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ext۰reflect۰rtype۰FieldByName(a *analysis, cgn *cgnode) {
    // If we have access to the callsite,
    // and the argument is a string constant,
    // return only that field.
    var name string
      Severity: Major
      Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go and 1 other location - About 1 hr to fix
      go_agent/src/code.google.com/p/go.tools/pointer/reflect.go on lines 1599..1616

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 178.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (c *reflectSliceOfConstraint) solve(a *analysis, _ *node, delta nodeset) {
    changed := false
    for tObj := range delta {
        T := a.rtypeTaggedValue(tObj)
      Severity: Minor
      Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go and 1 other location - About 55 mins to fix
      go_agent/src/code.google.com/p/go.tools/pointer/reflect.go on lines 1125..1137

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (c *reflectPtrToConstraint) solve(a *analysis, _ *node, delta nodeset) {
    changed := false
    for tObj := range delta {
        T := a.rtypeTaggedValue(tObj)
      Severity: Minor
      Found in go_agent/src/code.google.com/p/go.tools/pointer/reflect.go and 1 other location - About 55 mins to fix
      go_agent/src/code.google.com/p/go.tools/pointer/reflect.go on lines 1166..1178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status