cloudfoundry-incubator/stratos

View on GitHub

Showing 650 of 1,370 total issues

Method MetricsSpecification.Connect has 9 return statements (exceeds 4 allowed).
Open

func (m *MetricsSpecification) Connect(ec echo.Context, cnsiRecord interfaces.CNSIRecord, userId string) (*interfaces.TokenRecord, bool, error) {
    log.Debug("Metrics Connect...")

    params := new(interfaces.LoginToCNSIParams)
    err := interfaces.BindOnce(params, ec)
Severity: Major
Found in src/jetstream/plugins/metrics/main.go - About 55 mins to fix

    Method KubernetesSpecification.InstallRelease has 9 return statements (exceeds 4 allowed).
    Open

    func (c *KubernetesSpecification) InstallRelease(ec echo.Context) error {
        bodyReader := ec.Request().Body
        buf := new(bytes.Buffer)
        buf.ReadFrom(bodyReader)
    
    
    Severity: Major
    Found in src/jetstream/plugins/kubernetes/install_release.go - About 55 mins to fix

      Method portalProxy.endpointUpdateDeleteMiddleware has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
      Open

      func (p *portalProxy) endpointUpdateDeleteMiddleware(h echo.HandlerFunc) echo.HandlerFunc {
          return func(c echo.Context) error {
              log.Debug("endpointUpdateDeleteMiddleware")
              userID, err := p.GetSessionValue(c, "user_id")
              if err != nil {
      Severity: Minor
      Found in src/jetstream/middleware.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method PgsqlTokenRepository.SaveAuthToken has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
      Open

      func (p *PgsqlTokenRepository) SaveAuthToken(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
          log.Debug("SaveAuthToken")
          if userGUID == "" {
              msg := "Unable to save Auth Token without a valid User GUID."
              log.Debug(msg)
      Severity: Minor
      Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method portalProxy.updateEndpoint has 9 return statements (exceeds 4 allowed).
      Open

      func (p *portalProxy) updateEndpoint(ec echo.Context) error {
          log.Debug("updateEndpoint")
      
          params := new(interfaces.UpdateEndpointParams)
          if err := ec.Bind(params); err != nil {
      Severity: Major
      Found in src/jetstream/cnsi.go - About 55 mins to fix

        Function makeSpan has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
        Open

          makeSpan() {
            let span = '';
            if (this.boldOn || this.currentFg || this.currentBg) {
              span += '<span class="';
              if (this.boldOn) {

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sortEndpointTiles has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
        Open

          protected sortEndpointTiles(
            { label: aLabel, renderPriority: aRenderPriority }: IStratosEndpointDefinition,
            { label: bLabel, renderPriority: bRenderPriority }: IStratosEndpointDefinition
          ) {
            // We're going to do a little more work than just to compare the render priority to ensure

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method CFAppPush.getConfigData has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (cfAppPush *CFAppPush) getConfigData(echoContext echo.Context, cnsiGUID string, orgGUID string, spaceGUID string, spaceName string, orgName string, clientWebSocket *websocket.Conn) (*CFPushAppConfig, error) {
        Severity: Major
        Found in src/jetstream/plugins/cfapppush/deploy.go - About 50 mins to fix

          Function setUpTestOrgSpaceUserRoles has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            cfGuid: string,
            defaultCf: E2EConfigCloudFoundry,
            orgName: string,
            spaceName: string,
            userName: string,
          Severity: Major
          Found in src/test-e2e/cloud-foundry/users-list-e2e.helper.ts - About 50 mins to fix

            Function handleOrgRoleChange has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              state: IAllCfRolesState,
              endpointGuid: string,
              cf: ICfRolesState,
              orgGuid: string,
              orgState: IOrgRoleState,

              Function buildMetricsChartConfig has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                metricsAction: MetricsAction,
                yAxisLabel: string,
                getSeriesName: (result) => string,
                dataType: ChartDataTypes = null,
                filterSeries?: MetricsFilterSeries,

                Function KubeDashboardProxy has 8 return statements (exceeds 4 allowed).
                Open

                func KubeDashboardProxy(c echo.Context, p interfaces.PortalProxy, config *rest.Config) error {
                    log.Debugf("KubeDashboardProxy request for: %s", c.Request().RequestURI)
                
                    cnsiGUID := c.Param("guid")
                    prefix := "/pp/v1/apps/kubedash/ui/" + cnsiGUID + "/"
                Severity: Major
                Found in src/jetstream/plugins/kubernetes/dashboard/proxy.go - About 50 mins to fix

                  Function InstallDashboard has 8 return statements (exceeds 4 allowed).
                  Open

                  func InstallDashboard(p interfaces.PortalProxy, endpointGUID, userGUID string) error {
                      // Download the Yaml for the dashboard
                      kubeDashboardImage := p.Env().String("STRATOS_KUBERNETES_DASHBOARD_IMAGE", "")
                      if len(kubeDashboardImage) == 0 {
                          kubeDashboardImage = dashboardInstallYAMLDownloadURL
                  Severity: Major
                  Found in src/jetstream/plugins/kubernetes/dashboard/configure.go - About 50 mins to fix

                    Method MetricsSpecification.createMetadata has 8 return statements (exceeds 4 allowed).
                    Open

                    func (m *MetricsSpecification) createMetadata(metricEndpoint *url.URL, httpClient http.Client, auth *MetricsAuth) (string, error) {
                        basicMetricRequest := fmt.Sprintf("%s/api/v1/query?query=firehose_total_metrics_received", metricEndpoint)
                        req, err := http.NewRequest("GET", basicMetricRequest, nil)
                        if err != nil {
                            msg := "Failed to create request for the Metrics Endpoint: %v"
                    Severity: Major
                    Found in src/jetstream/plugins/metrics/main.go - About 50 mins to fix

                      Method KubernetesSpecification.Info has 8 return statements (exceeds 4 allowed).
                      Open

                      func (c *KubernetesSpecification) Info(apiEndpoint string, skipSSLValidation bool) (interfaces.CNSIRecord, interface{}, error) {
                      
                          log.Debug("Kubernetes Info")
                          var v2InfoResponse interfaces.V2Info
                          var newCNSI interfaces.CNSIRecord
                      Severity: Major
                      Found in src/jetstream/plugins/kubernetes/main.go - About 50 mins to fix

                        Function getSSHCode has 8 return statements (exceeds 4 allowed).
                        Open

                        func getSSHCode(authorizeEndpoint, clientID, token string, skipSSLValidation bool) (string, error) {
                            authorizeURL, err := url.Parse(authorizeEndpoint)
                            if err != nil {
                                return "", err
                            }
                        Severity: Major
                        Found in src/jetstream/plugins/cfappssh/app_ssh.go - About 50 mins to fix

                          Method Monocular.artifactHubGetIcon has 8 return statements (exceeds 4 allowed).
                          Open

                          func (m *Monocular) artifactHubGetIcon(c echo.Context) error {
                              endpoint := c.Param("guid")
                              repo := c.Param("repo")
                              chartName := c.Param("name")
                              version := c.Param("version")
                          Severity: Major
                          Found in src/jetstream/plugins/monocular/artifacthub.go - About 50 mins to fix

                            Function init has 8 return statements (exceeds 4 allowed).
                            Open

                            func init() {
                                RegisterMigration(20170818120003, "InitialSchema", func(txn *sql.Tx, conf *goose.DBConf) error {
                                    binaryDataType := "BYTEA"
                                    if strings.Contains(conf.Driver.Name, "mysql") {
                                        binaryDataType = "BLOB"
                            Severity: Major
                            Found in src/jetstream/datastore/20170818120003_InitialSchema.go - About 50 mins to fix

                              Function saveUAAConsoleConfig has 8 return statements (exceeds 4 allowed).
                              Open

                              func saveUAAConsoleConfig(consoleRepo console_config.Repository, consoleConfig *interfaces.ConsoleConfig) error {
                                  log.Debugf("Saving ConsoleConfig: %+v", consoleConfig)
                              
                                  if err := consoleRepo.SetValue(systemGroupName, "UAA_ENDPOINT", consoleConfig.UAAEndpoint.String()); err != nil {
                                      return err
                              Severity: Major
                              Found in src/jetstream/setup_console.go - About 50 mins to fix

                                Method GKEKubeAuth.FetchToken has 7 return statements (exceeds 4 allowed).
                                Open

                                func (c *GKEKubeAuth) FetchToken(cnsiRecord interfaces.CNSIRecord, ec echo.Context) (*interfaces.TokenRecord, *interfaces.CNSIRecord, error) {
                                    log.Debug("FetchToken (GKE)")
                                
                                    // We should already have the refresh token in the body sent to us
                                    req := ec.Request()
                                Severity: Major
                                Found in src/jetstream/plugins/kubernetes/auth/gke.go - About 45 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language