cloudfoundry-incubator/stratos

View on GitHub

Showing 650 of 1,370 total issues

Method LocalUserInfo.UpdatePassword has 7 return statements (exceeds 4 allowed).
Open

func (userInfo *LocalUserInfo) UpdatePassword(id string, passwordInfo *passwordChangeInfo) (int, error) {

    // Fetch the user, make updates and save
    localUsersRepo, err := localusers.NewPgsqlLocalUsersRepository(userInfo.portalProxy.GetDatabaseConnection())
    if err != nil {
Severity: Major
Found in src/jetstream/plugins/userinfo/local_user.go - About 45 mins to fix

    Function echoV2DefaultHTTPErrorHandler has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

    func echoV2DefaultHTTPErrorHandler(err error, c echo.Context) {
    
        code := http.StatusInternalServerError
        msg := http.StatusText(code)
        if he, ok := err.(*echo.HTTPError); ok {
    Severity: Minor
    Found in src/jetstream/main.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function makePrometheusRequestInfos has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func makePrometheusRequestInfos(c echo.Context, userGUID string, metrics map[string]EndpointMetricsRelation, prometheusOp string, queries string, addJob bool) []interfaces.ProxyRequestInfo {
    Severity: Minor
    Found in src/jetstream/plugins/metrics/cloud_foundry.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if err == nil {
                                  isValid, err := k.PortalProxy.GetSessionDataStore().IsValidSession(i)
                                  if err == nil && !isValid {
                                      log.Debugf("Deleting secret %s", secret.Name)
                                      secretClient.Delete(secret.Name, nil)
      Severity: Major
      Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 45 mins to fix

        Method HelmRelease.UpdatePods has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

        func (r *HelmRelease) UpdatePods(jetstream interfaces.PortalProxy) {
            var jobs []KubeResourceJob
            for _, job := range r.PodJobs {
                jobs = append(jobs, job)
            }
        Severity: Minor
        Found in src/jetstream/plugins/kubernetes/helm/release.go - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method CFAppPush.getGitSCMSource has 7 return statements (exceeds 4 allowed).
        Open

        func (cfAppPush *CFAppPush) getGitSCMSource(clientWebSocket *websocket.Conn, tempDir string, msg SocketMessage, userGUID string) (StratosProject, string, error) {
            var (
                err error
            )
        
        
        Severity: Major
        Found in src/jetstream/plugins/cfapppush/deploy.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if err == nil {
                                      isValid, err := k.PortalProxy.GetSessionDataStore().IsValidSession(i)
                                      if err == nil && !isValid {
                                          log.Debugf("Deleting pod %s", pod.Name)
                                          podClient.Delete(pod.Name, nil)
          Severity: Major
          Found in src/jetstream/plugins/kubernetes/terminal/cleanup.go - About 45 mins to fix

            Method CFPushApp.Run has 7 return statements (exceeds 4 allowed).
            Open

            func (c *CFPushApp) Run(msgSender DeployAppMessageSender, clientWebsocket *websocket.Conn) error {
            
                // Get a CF Config
                config, err := configv3.LoadConfig()
                if err != nil {
            Severity: Major
            Found in src/jetstream/plugins/cfapppush/pushapp.go - About 45 mins to fix

              Method KubernetesSpecification.UpgradeRelease has 7 return statements (exceeds 4 allowed).
              Open

              func (c *KubernetesSpecification) UpgradeRelease(ec echo.Context) error {
                  endpointGUID := ec.Param("endpoint")
                  releaseName := ec.Param("name")
                  namespace := ec.Param("namespace")
              
              
              Severity: Major
              Found in src/jetstream/plugins/kubernetes/install_release.go - About 45 mins to fix

                Method GKEKubeAuth.FetchToken has 7 return statements (exceeds 4 allowed).
                Open

                func (c *GKEKubeAuth) FetchToken(cnsiRecord interfaces.CNSIRecord, ec echo.Context) (*interfaces.TokenRecord, *interfaces.CNSIRecord, error) {
                    log.Debug("FetchToken (GKE)")
                
                    // We should already have the refresh token in the body sent to us
                    req := ec.Request()
                Severity: Major
                Found in src/jetstream/plugins/kubernetes/auth/gke.go - About 45 mins to fix

                  Method portalProxy.setupGetAvailableScopes has 7 return statements (exceeds 4 allowed).
                  Open

                  func (p *portalProxy) setupGetAvailableScopes(c echo.Context) error {
                  
                      // Check if already set up
                      if p.GetConfig().ConsoleConfig.IsSetupComplete() {
                          return c.NoContent(http.StatusServiceUnavailable)
                  Severity: Major
                  Found in src/jetstream/setup_console.go - About 45 mins to fix

                    Method PostgresCNSIRepository.ListByUser has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                    Open

                    func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
                        log.Debug("ListByUser")
                        rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
                        if err != nil {
                            return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
                    Severity: Minor
                    Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                        if err != nil {
                                            return fmt.Errorf("Can not get endpoint type for %s: '%v'", endpoint.CNSIType, err)
                                        }
                    Severity: Major
                    Found in src/jetstream/cnsi.go - About 45 mins to fix

                      Method portalProxy.ProxyRequest has 7 return statements (exceeds 4 allowed).
                      Open

                      func (p *portalProxy) ProxyRequest(c echo.Context, uri *url.URL) (map[string]*interfaces.CNSIRequest, error) {
                          log.Debug("ProxyRequest")
                          cnsiList := strings.Split(c.Request().Header.Get("x-cap-cnsi-list"), ",")
                          shouldPassthrough := "true" == c.Request().Header.Get("x-cap-passthrough")
                          longRunning := "true" == c.Request().Header.Get(longRunningTimeoutHeader)
                      Severity: Major
                      Found in src/jetstream/passthrough.go - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                    if consoleConfig.AuthorizationEndpoint == nil {
                                        // No Authorization endpoint
                                        consoleConfig.AuthorizationEndpoint = consoleConfig.UAAEndpoint
                                        log.Debugf("Using UAA Endpoint for Auth Endpoint: %s", consoleConfig.AuthorizationEndpoint)
                                    }
                        Severity: Major
                        Found in src/jetstream/setup_console.go - About 45 mins to fix

                          Function KubeDashboardLogin has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                          Open

                          func KubeDashboardLogin(c echo.Context, p interfaces.PortalProxy) error {
                              log.Debug("kubeDashboardLogin request")
                          
                              endpointGUID := c.Param("guid")
                              userGUID := c.Get("user_id").(string)
                          Severity: Minor
                          Found in src/jetstream/plugins/kubernetes/dashboard/login.go - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function updateCFFIle has 7 return statements (exceeds 4 allowed).
                          Open

                          func updateCFFIle(updates map[string]string) error {
                              usr, err := user.Current()
                              if err != nil {
                                  return err
                              }
                          Severity: Major
                          Found in src/jetstream/plugins/desktop/kubernetes/kubeconfig.go - About 45 mins to fix

                            Function NewDatabaseConnectionParametersFromConfig has 7 return statements (exceeds 4 allowed).
                            Open

                            func NewDatabaseConnectionParametersFromConfig(dc DatabaseConfig) (DatabaseConfig, error) {
                            
                                if len(dc.DatabaseProvider) == 0 {
                                    dc.DatabaseProvider = DefaultDatabaseProvider
                                }
                            Severity: Major
                            Found in src/jetstream/datastore/datastore.go - About 45 mins to fix

                              Function SetStructFieldValue has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                              Open

                              func SetStructFieldValue(value reflect.Value, field reflect.Value, val string) error {
                              
                                  var newVal interface{}
                                  var err error
                                  typ := field.Type()
                              Severity: Minor
                              Found in src/jetstream/repository/interfaces/config/config.go - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function updateCFFIle has 7 return statements (exceeds 4 allowed).
                              Open

                              func updateCFFIle(updates map[string]string) error {
                                  usr, err := user.Current()
                                  if err != nil {
                                      return err
                                  }
                              Severity: Major
                              Found in src/jetstream/plugins/desktop/cloudfoundry.go - About 45 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language