cloudfoundry-incubator/stratos

View on GitHub

Showing 650 of 1,370 total issues

Function getKubeDashboardPod has 5 return statements (exceeds 4 allowed).
Open

func getKubeDashboardPod(p interfaces.PortalProxy, cnsiGUID, userGUID string, labelSelector string) (*v1.Pod, error) {
    log.Debug("kubeDashboardStatus request")

    response, err := p.DoProxySingleRequest(cnsiGUID, userGUID, "GET", "/api/v1/pods?labelSelector="+labelSelector, nil, nil)
    if err != nil || response.StatusCode != 200 {
Severity: Major
Found in src/jetstream/plugins/kubernetes/dashboard/common.go - About 35 mins to fix

    Method Monocular.artifactHubCacheChartFiles has 5 return statements (exceeds 4 allowed).
    Open

    func (m *Monocular) artifactHubCacheChartFiles(endpointID, repoName, repoURL, name, version, digest string) (string, error) {
    
        // First look to see if there is a digest file
        cacheFolder := path.Join(m.CacheFolder, endpointID, fmt.Sprintf("%s_%s_%s", repoName, name, version))
        if hasDigestFile(cacheFolder, digest) {
    Severity: Major
    Found in src/jetstream/plugins/monocular/artifacthub.go - About 35 mins to fix

      Method SemanticVersion.LessThan has 5 return statements (exceeds 4 allowed).
      Open

      func (s *SemanticVersion) LessThan(d *SemanticVersion) bool {
          if d == nil {
              return true
          }
          if s.Valid && d.Valid {
      Severity: Major
      Found in src/jetstream/plugins/monocular/store/version.go - About 35 mins to fix

        Method MetricsSpecification.getMetricsEndpoints has 5 return statements (exceeds 4 allowed).
        Open

        func (m *MetricsSpecification) getMetricsEndpoints(userGUID string, cnsiList []string) (map[string]EndpointMetricsRelation, error) {
        
            metricsProviders := make([]MetricsMetadata, 0)
            endpointsMap := make(map[string]*interfaces.ConnectedEndpoint)
            results := make(map[string]EndpointMetricsRelation)
        Severity: Major
        Found in src/jetstream/plugins/metrics/main.go - About 35 mins to fix

          Method KubeTerminal.createPod has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
          Open

          func (k *KubeTerminal) createPod(c echo.Context, kubeConfig, kubeVersion string, ws *websocket.Conn) (*PodCreationData, error) {
              // Unique ID for the secret and pod name
              id := uuid.NewV4().String()
              id = strings.ReplaceAll(id, "-", "")
              // Names for the secret and pod
          Severity: Minor
          Found in src/jetstream/plugins/kubernetes/terminal/helpers.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method GeneratedEndpointPlugin.fetchUsername has 5 return statements (exceeds 4 allowed).
          Open

          func (gep GeneratedEndpointPlugin) fetchUsername(config pluginConfig, cnsiRecord *interfaces.CNSIRecord, tr *interfaces.TokenRecord) string {
              if len(config.UserInfoAPI) == 0 || len(config.UserInfoPath) == 0 {
                  // Not configured
                  return defaultTokenUsername
              }
          Severity: Major
          Found in src/jetstream/plugins/yamlgenerated/main.go - About 35 mins to fix

            Method portalProxy.login has 5 return statements (exceeds 4 allowed).
            Open

            func (p *portalProxy) login(c echo.Context, skipSSLValidation bool, client string, clientSecret string, endpoint string) (uaaRes *interfaces.UAAResponse, u *interfaces.JWTUserTokenInfo, err error) {
                log.Debug("login")
                if c.Request().Method == http.MethodGet {
                    code := c.QueryParam("code")
                    state := c.QueryParam("state")
            Severity: Major
            Found in src/jetstream/auth.go - About 35 mins to fix

              Method portalProxy.listRegisteredCNSIs has 5 return statements (exceeds 4 allowed).
              Open

              func (p *portalProxy) listRegisteredCNSIs(c echo.Context) error {
                  log.Debug("listRegisteredCNSIs")
                  userGUIDIntf, err := p.GetSessionValue(c, "user_id")
                  if err != nil {
                      return interfaces.NewHTTPShadowError(
              Severity: Major
              Found in src/jetstream/cnsi.go - About 35 mins to fix

                Function UnMarshalHelper has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
                Open

                func UnMarshalHelper(values map[string]interface{}, intf interface{}) error {
                
                    value := reflect.ValueOf(intf)
                
                    if value.Kind() != reflect.Ptr {
                Severity: Minor
                Found in src/jetstream/plugins/kubernetes/config/kube_config.go - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method portalProxy.loginToCNSI has 5 return statements (exceeds 4 allowed).
                Open

                func (p *portalProxy) loginToCNSI(c echo.Context) error {
                    log.Debug("loginToCNSI")
                
                    var systemSharedToken = false
                
                
                Severity: Major
                Found in src/jetstream/authcnsi.go - About 35 mins to fix

                  Function MakePluginsFromConfig has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
                  Open

                  func MakePluginsFromConfig() {
                      log.Debug("MakePluginsFromConfig")
                  
                      var config []pluginConfig
                  
                  
                  Severity: Minor
                  Found in src/jetstream/plugins/yamlgenerated/main.go - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function init has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
                  Open

                  func init() {
                      RegisterMigration(20191008121900, "PrimaryKeys", func(txn *sql.Tx, conf *goose.DBConf) error {
                  
                          // Make sure all tokens have a CNSI guid
                          ensureTokensHaveCnsi := "UPDATE tokens SET cnsi_guid='STRATOS' WHERE token_type='uaa' and cnsi_guid IS NULL;"
                  Severity: Minor
                  Found in src/jetstream/datastore/20191008121900_PrimaryKeys.go - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getKubeDashboardServiceAccount has 5 return statements (exceeds 4 allowed).
                  Open

                  func getKubeDashboardServiceAccount(p interfaces.PortalProxy, cnsiGUID, userGUID string, labelSelector string) (*v1.ServiceAccount, error) {
                      log.Debug("getKubeDashboardService request")
                  
                      response, err := p.DoProxySingleRequest(cnsiGUID, userGUID, "GET", "/api/v1/serviceaccounts?labelSelector="+labelSelector, nil, nil)
                      if err != nil || response.StatusCode != 200 {
                  Severity: Major
                  Found in src/jetstream/plugins/kubernetes/dashboard/common.go - About 35 mins to fix

                    Function getRecentLogs has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
                    Open

                    func getRecentLogs(ac *AuthorizedConsumer, cnsiGUID, appGUID string) ([]*events.LogMessage, error) {
                        log.Debug("getRecentLogs")
                        messages, err := ac.consumer.RecentLogs(appGUID, ac.authToken)
                        if err != nil {
                            errorPattern := "Failed to get recent messages for App %s on CNSI %s [%v]"
                    Severity: Minor
                    Found in src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method CloudFoundrySpecification.Info has 5 return statements (exceeds 4 allowed).
                    Open

                    func (c *CloudFoundrySpecification) Info(apiEndpoint string, skipSSLValidation bool) (interfaces.CNSIRecord, interface{}, error) {
                        log.Debug("Info")
                        var v2InfoResponse interfaces.V2Info
                        var newCNSI interfaces.CNSIRecord
                    
                    
                    Severity: Major
                    Found in src/jetstream/plugins/cloudfoundry/main.go - About 35 mins to fix

                      Method CFHosting.Init has 5 return statements (exceeds 4 allowed).
                      Open

                      func (ch *CFHosting) Init() error {
                      
                          // Determine if we are running CF by presence of env var "VCAP_APPLICATION" and configure appropriately
                          if ch.portalProxy.Env().IsSet(VCapApplication) {
                              log.Info("Detected that Console is deployed as a Cloud Foundry Application")
                      Severity: Major
                      Found in src/jetstream/plugins/cloudfoundryhosting/main.go - About 35 mins to fix

                        Method PostgresCNSIRepository.ListByUser has 5 return statements (exceeds 4 allowed).
                        Open

                        func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
                            log.Debug("ListByUser")
                            rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
                            if err != nil {
                                return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
                        Severity: Major
                        Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 35 mins to fix

                          Method FavoritesDBStore.List has 5 return statements (exceeds 4 allowed).
                          Open

                          func (p *FavoritesDBStore) List(userGUID string) ([]*UserFavoriteRecord, error) {
                              log.Debug("List")
                              rows, err := p.db.Query(getFavorites, userGUID)
                              if err != nil {
                                  return nil, fmt.Errorf("Unable to retrieve User Favorite records: %v", err)

                            Method CustomBinder.Bind has 5 return statements (exceeds 4 allowed).
                            Open

                            func (b *CustomBinder) Bind(i interface{}, c echo.Context) error {
                                db := new(echo.DefaultBinder)
                                err := db.Bind(i, c)
                            
                                if err != nil {
                            Severity: Major
                            Found in src/jetstream/custombinder/custombinder.go - About 35 mins to fix

                              Function init has 5 return statements (exceeds 4 allowed).
                              Open

                              func init() {
                                  RegisterMigration(20180824092600, "LinkedTokens", func(txn *sql.Tx, conf *goose.DBConf) error {
                              
                                      addTokenID := "ALTER TABLE tokens ADD token_guid VARCHAR(36) DEFAULT 'default-token'"
                                      _, err := txn.Exec(addTokenID)
                              Severity: Major
                              Found in src/jetstream/datastore/20180824092600_LinkedTokens.go - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language