cloudfoundry-incubator/stratos

Function getActionDispatcher has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  private static getActionDispatcher<Y, ABC extends OrchestratedActionBuilders, K extends keyof ABC>(
    es: CoreEntityCatalogEntityStore<Y, ABC>,
    builder: OrchestratedActionBuilder,
    actionKey: string,
  ): ActionDispatcher<K, ABC> {

Function updateMetricsInfo has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function updateMetricsInfo(state: IRequestEntityTypeState<EndpointModel>, action: MetricsAPIActionSuccess) {
  if (action.queryType === MetricAPIQueryTypes.TARGETS) {
    const existingEndpoint = state[action.endpointGuid];
    return {
      ...state,

Function editModeChanged has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  editModeChanged(mode) {
    this.mode = mode.value;

    if (this.mode === EditorMode.CodeEditor) {
      // Form -> Editor

Function connectEndpoint has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  private connectEndpoint(action: KubeConfigImportAction, pData: ConnectEndpointData): Observable<IActionMonitorComponentState> {
    const config: ConnectEndpointConfig = {
      name: action.cluster.name,
      guid: action.depends.cluster._guid || action.cluster._guid,
      type: KUBERNETES_ENDPOINT_TYPE,

Function reconnect has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  reconnect() {
    this.isConnecting = true;
    this.errorMessage = undefined;
    this.xterm.reset();
    this.msgSubscription = this.sshStream

Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  constructor(
    private store: Store<AppState>,
  ) {
    this.userGuid$ = this.store.select(s => s.auth).pipe(
      filter((auth: AuthState) => !!(auth && auth.sessionData)),

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func getKubeDashboardPod(p interfaces.PortalProxy, cnsiGUID, userGUID string, labelSelector string) (*v1.Pod, error) {
    log.Debug("kubeDashboardStatus request")

    response, err := p.DoProxySingleRequest(cnsiGUID, userGUID, "GET", "/api/v1/pods?labelSelector="+labelSelector, nil, nil)
    if err != nil || response.StatusCode != 200 {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func getKubeDashboardServiceAccount(p interfaces.PortalProxy, cnsiGUID, userGUID string, labelSelector string) (*v1.ServiceAccount, error) {
    log.Debug("getKubeDashboardService request")

    response, err := p.DoProxySingleRequest(cnsiGUID, userGUID, "GET", "/api/v1/serviceaccounts?labelSelector="+labelSelector, nil, nil)
    if err != nil || response.StatusCode != 200 {

• Read up
  Read up

Method Analysis.doRunReport has 10 return statements (exceeds 4 allowed).

Open

func (c *Analysis) doRunReport(ec echo.Context, analyzer, endpointID, userID string, dbStore store.AnalysisStore, report *store.AnalysisRecord) error {

    // Get Kube Config
    k8s := c.portalProxy.GetPlugin("kubernetes")
    if k8s == nil {

Function KubeDashboardLogin has 10 return statements (exceeds 4 allowed).

Open

func KubeDashboardLogin(c echo.Context, p interfaces.PortalProxy) error {
    log.Debug("kubeDashboardLogin request")

    endpointGUID := c.Param("guid")
    userGUID := c.Get("user_id").(string)

Method portalProxy.DoRegisterEndpoint has 10 return statements (exceeds 4 allowed).

Open

func (p *portalProxy) DoRegisterEndpoint(cnsiName string, apiEndpoint string, skipSSLValidation bool, clientId string, clientSecret string, userId string, ssoAllowed bool, subType string, createSystemEndpoint bool, fetchInfo interfaces.InfoFunc) (interfaces.CNSIRecord, error) {
    log.Debug("DoRegisterEndpoint")

    if len(cnsiName) == 0 || len(apiEndpoint) == 0 {
        return interfaces.CNSIRecord{}, interfaces.NewHTTPShadowError(

Method PgsqlTokenRepository.SaveCNSIToken has 10 return statements (exceeds 4 allowed).

Open

func (p *PgsqlTokenRepository) SaveCNSIToken(cnsiGUID string, userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
    log.Debug("SaveCNSIToken")
    if cnsiGUID == "" {
        msg := "Unable to save CNSI Token without a valid CNSI GUID."
        log.Debug(msg)

Method PgsqlTokenRepository.UpdateTokenAuth has 10 return statements (exceeds 4 allowed).

Open

func (p *PgsqlTokenRepository) UpdateTokenAuth(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
    log.Debug("UpdateTokenAuth")

    if userGUID == "" {
        msg := "Unable to save Token without a valid User GUID."

Function handleSpaceRoleChange has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

  state: IAllCfRolesState,
  endpointGuid: string,
  cf: ICfRolesState,
  orgGuid: string,
  spaceGuid: string,

Function setRole has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

  existingState: UsersRolesState,
  orgGuid: string,
  orgName: string,
  spaceGuid: string,
  spaceName: string,

Function setSpaceRole has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

  orgRoles: IUserPermissionInOrg,
  orgGuid: string,
  orgName: string,
  spaceGuid: string,
  spaceName: string,

Function flattenPagination has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

  actionDispatcher: ActionDispatcher,
  firstRequest: Observable<C>,
  flattener: PaginationFlattener<T, C>,
  maxCount?: number,
  entityType?: string,

Method UaaUserInfo.uaa has 9 return statements (exceeds 4 allowed).

Open

func (userInfo *UaaUserInfo) uaa(target string, body []byte) (int, []byte, *http.Header, error) {
    log.Debug("uaa request")

    // Check session
    _, err := userInfo.portalProxy.GetSessionInt64Value(userInfo.echo, "exp")

Method Analysis.checkStatus has 9 return statements (exceeds 4 allowed).

Open

func (c *Analysis) checkStatus() error {
    log.Debug("Checking status....")
    p := c.portalProxy
    // Create a record in the reports datastore
    dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())

Method cnsiTokenBackup.restoreBackup has 9 return statements (exceeds 4 allowed).

Open

func (ctb *cnsiTokenBackup) restoreBackup(backup *RestoreRequest) error {
    log.Debug("restoreBackup")

    data := &BackupContent{}
    if err := json.Unmarshal([]byte(backup.Data), data); err != nil {