Sign upLogin

cloudfoundry-incubator/stratos

View on GitHub
Star

Showing 1,111 of 1,370 total issues

Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

  constructor(dir: string, options?: any, loggingEnabled = true) {
    this.angularJsonFile = this.findFileOrFolderInChain(dir, 'angular.json');
    this.angularJson = JSON.parse(fs.readFileSync(this.angularJsonFile, 'utf8').toString());
    this.loggingEnabled = loggingEnabled;
Severity: Minor
Found in src/frontend/packages/devkit/src/lib/stratos.config.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deleteEntity has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

function deleteEntity(state, entityKey, guid) {
  const newState = {} as Record<string, any>;
  for (const entityTypeKey in state) {
    if (entityTypeKey === entityKey) {
      newState[entityTypeKey] = {};
Severity: Minor
Found in src/frontend/packages/store/src/reducers/api-request-data-reducer/request-data-reducer.factory.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dashboardReducer has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

export function dashboardReducer(state: DashboardState = defaultDashboardState, action): DashboardState {
  switch (action.type) {
    case OPEN_SIDE_NAV:
      if (state.isMobile) {
        return { ...state, isMobileNavOpen: true };
Severity: Minor
Found in src/frontend/packages/store/src/reducers/dashboard-reducer.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getObservables has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  store: Store<GeneralEntityAppState>,
  entityKey: string,
  paginationKey: string,
  paginationAction: PaginatedAction | PaginatedAction[],
  paginationMonitor: PaginationMonitor,
Severity: Minor
Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts - About 45 mins to fix

    Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

      constructor(
    public activatedRoute: ActivatedRoute,
    public kubeEndpointService: KubernetesEndpointService
  ) {
    this.podName = activatedRoute.snapshot.params.podName;
    Severity: Minor
    Found in src/frontend/packages/kubernetes/src/kubernetes/pod-metrics/pod-metrics.component.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

            if (itemFormat) {
          arrayItem.format = itemFormat;
        }
    Severity: Major
    Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/chart-values-editor/json-schema-generator.ts - About 45 mins to fix

      Function failApiRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        store: Store<T>,
  apiAction: EntityRequestAction,
  error,
  catalogEntity: StratosBaseCatalogEntity,
  requestType: ApiRequestTypes = 'fetch',
      Severity: Minor
      Found in src/frontend/packages/store/src/reducers/api-request-reducer/request-helpers.ts - About 45 mins to fix

        Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

          constructor(private store: Store<AppState>, private activatedRoute: ActivatedRoute) {
    // Determine the starting state of the filter by repo section
    stratosEntityCatalog.endpoint.store.getAll.getPaginationService().entities$.pipe(
      filter(entities => !!entities),
      first()
        Severity: Minor
        Found in src/frontend/packages/kubernetes/src/helm/tabs/catalog-tab/catalog-tab.component.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                        if (!resources[entityType]) {
                  resources[entityType] = [];
                }
        Severity: Major
        Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts - About 45 mins to fix

          Function editModeChanged has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
          Open

            editModeChanged(mode) {
    this.mode = mode.value;

    if (this.mode === EditorMode.CodeEditor) {
      // Form -> Editor
          Severity: Minor
          Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/chart-values-editor/chart-values-editor.component.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setErrorMessage has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
          Open

            private setErrorMessage(auth: AuthState) {
    // Default error message
    this.message = `Couldn't log in, please try again.`;
    if (auth.error && auth.errorResponse) {
      if (auth.errorResponse === 'Invalid session') {
          Severity: Minor
          Found in src/frontend/packages/core/src/features/login/login-page/login-page.component.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (br *BackupRestore) backupEndpoints(c echo.Context) error {
    log.Debug("backupEndpoints")

    userID, err := br.portalProxy.GetSessionStringValue(c, "user_id")
    if err != nil {
          Severity: Minor
          Found in src/jetstream/plugins/backup/main.go and 1 other location - About 45 mins to fix
          src/jetstream/plugins/backup/main.go on lines 90..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 214.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (br *BackupRestore) restoreEndpoints(c echo.Context) error {
    log.Debug("restoreEndpoints")

    userID, err := br.portalProxy.GetSessionStringValue(c, "user_id")
    if err != nil {
          Severity: Minor
          Found in src/jetstream/plugins/backup/main.go and 1 other location - About 45 mins to fix
          src/jetstream/plugins/backup/main.go on lines 66..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 214.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function detectTLSCert has 6 return statements (exceeds 4 allowed).
          Open

          func detectTLSCert(pc interfaces.PortalConfig) (string, string, error) {
    log.Debug("detectTLSCert")
    certFilename := "pproxy.crt"
    certKeyFilename := "pproxy.key"
          Severity: Major
          Found in src/jetstream/main.go - About 40 mins to fix

            Function extractArchiveFiles has 6 return statements (exceeds 4 allowed).
            Open

            func extractArchiveFiles(archivePath, chartName, downloadFolder string, filenames []string) error {
    // Map the filenames array into a map of path to destination file
    requiredFiles := make(map[string]string)
    requiredCount := len(filenames)
    for _, name := range filenames {
            Severity: Major
            Found in src/jetstream/plugins/monocular/cache.go - About 40 mins to fix

              Method UserInfo.updateUserInfo has 6 return statements (exceeds 4 allowed).
              Open

              func (userInfo *UserInfo) updateUserInfo(c echo.Context) error {
    _, err := userInfo.preFlightChecks(c)
    if err != nil {
        return err
    }
              Severity: Major
              Found in src/jetstream/plugins/userinfo/main.go - About 40 mins to fix

                Method CertKubeAuth.DoFlowRequest has 6 return statements (exceeds 4 allowed).
                Open

                func (c *CertKubeAuth) DoFlowRequest(cnsiRequest *interfaces.CNSIRequest, req *http.Request) (*http.Response, error) {
    log.Debug("doCertAuthFlowRequest")

    authHandler := func(tokenRec interfaces.TokenRecord, cnsi interfaces.CNSIRecord) (*http.Response, error) {
                Severity: Major
                Found in src/jetstream/plugins/kubernetes/auth/cert.go - About 40 mins to fix

                  Function NewKubeTerminal has 6 return statements (exceeds 4 allowed).
                  Open

                  func NewKubeTerminal(p interfaces.PortalProxy) *KubeTerminal {
    // Only enabled in tech preview
    if !p.GetConfig().EnableTechPreview {
        log.Info("Kube Terminal not enabled - requires tech preview")
        return nil
                  Severity: Major
                  Found in src/jetstream/plugins/kubernetes/terminal/terminal.go - About 40 mins to fix

                    Method Monocular.cacheChartFromURL has 6 return statements (exceeds 4 allowed).
                    Open

                    func (m *Monocular) cacheChartFromURL(chartCachePath, digest, name, chartURL string) error {
    // Check to see if we have the same digest
    if ok := hasDigestFile(chartCachePath, digest); ok {
        log.Debug("Skipping download - already have archive with the same digest")
        return nil
                    Severity: Major
                    Found in src/jetstream/plugins/monocular/cache.go - About 40 mins to fix

                      Method CFPushApp.Init has 6 return statements (exceeds 4 allowed).
                      Open

                      func (c *CFPushApp) Init(appDir string, manifestPath string, overrides CFPushAppOverrides) error {

    // App name
    if len(overrides.Name) > 0 {
        c.pushCommand.OptionalArgs = flag.OptionalAppName{
                      Severity: Major
                      Found in src/jetstream/plugins/cfapppush/pushapp.go - About 40 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language