cloudfoundry-incubator/stratos

View on GitHub

Showing 1,111 of 1,370 total issues

Method PostgresCNSIRepository.ListByUser has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
    log.Debug("ListByUser")
    rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
Severity: Minor
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if err != nil {
                        return fmt.Errorf("Can not get endpoint type for %s: '%v'", endpoint.CNSIType, err)
                    }
Severity: Major
Found in src/jetstream/cnsi.go - About 45 mins to fix

    Method portalProxy.ProxyRequest has 7 return statements (exceeds 4 allowed).
    Open

    func (p *portalProxy) ProxyRequest(c echo.Context, uri *url.URL) (map[string]*interfaces.CNSIRequest, error) {
        log.Debug("ProxyRequest")
        cnsiList := strings.Split(c.Request().Header.Get("x-cap-cnsi-list"), ",")
        shouldPassthrough := "true" == c.Request().Header.Get("x-cap-passthrough")
        longRunning := "true" == c.Request().Header.Get(longRunningTimeoutHeader)
    Severity: Major
    Found in src/jetstream/passthrough.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if consoleConfig.AuthorizationEndpoint == nil {
                      // No Authorization endpoint
                      consoleConfig.AuthorizationEndpoint = consoleConfig.UAAEndpoint
                      log.Debugf("Using UAA Endpoint for Auth Endpoint: %s", consoleConfig.AuthorizationEndpoint)
                  }
      Severity: Major
      Found in src/jetstream/setup_console.go - About 45 mins to fix

        Function KubeDashboardLogin has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

        func KubeDashboardLogin(c echo.Context, p interfaces.PortalProxy) error {
            log.Debug("kubeDashboardLogin request")
        
            endpointGUID := c.Param("guid")
            userGUID := c.Get("user_id").(string)
        Severity: Minor
        Found in src/jetstream/plugins/kubernetes/dashboard/login.go - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateCFFIle has 7 return statements (exceeds 4 allowed).
        Open

        func updateCFFIle(updates map[string]string) error {
            usr, err := user.Current()
            if err != nil {
                return err
            }
        Severity: Major
        Found in src/jetstream/plugins/desktop/kubernetes/kubeconfig.go - About 45 mins to fix

          Function NewDatabaseConnectionParametersFromConfig has 7 return statements (exceeds 4 allowed).
          Open

          func NewDatabaseConnectionParametersFromConfig(dc DatabaseConfig) (DatabaseConfig, error) {
          
              if len(dc.DatabaseProvider) == 0 {
                  dc.DatabaseProvider = DefaultDatabaseProvider
              }
          Severity: Major
          Found in src/jetstream/datastore/datastore.go - About 45 mins to fix

            Function SetStructFieldValue has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
            Open

            func SetStructFieldValue(value reflect.Value, field reflect.Value, val string) error {
            
                var newVal interface{}
                var err error
                typ := field.Type()
            Severity: Minor
            Found in src/jetstream/repository/interfaces/config/config.go - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function updateCFFIle has 7 return statements (exceeds 4 allowed).
            Open

            func updateCFFIle(updates map[string]string) error {
                usr, err := user.Current()
                if err != nil {
                    return err
                }
            Severity: Major
            Found in src/jetstream/plugins/desktop/cloudfoundry.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if err != nil {
                                      if ok, detail := isSSLRelatedError(err); ok {
                                          return interfaces.NewHTTPShadowError(
                                              http.StatusForbidden,
                                              "SSL error - "+detail,
              Severity: Major
              Found in src/jetstream/cnsi.go - About 45 mins to fix

                Function init has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                Open

                func init() {
                    RegisterMigration(20180413135700, "MetricsSchema", func(txn *sql.Tx, conf *goose.DBConf) error {
                        if strings.Contains(conf.Driver.Name, "sqlite3") {
                            // SQLite does not support MODIFY on ALTER TABLE - but fortunately it doesn't mind about the column sizes
                            return nil
                Severity: Minor
                Found in src/jetstream/datastore/20180413135700_MetricsSchema.go - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method PgsqlLocalUsersRepository.UpdateLocalUser has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                Open

                func (p *PgsqlLocalUsersRepository) UpdateLocalUser(user interfaces.LocalUser) error {
                    log.Debug("UpdateLocalUser")
                
                    //Validate args
                    var err error
                Severity: Minor
                Found in src/jetstream/repository/localusers/psql_localusers.go - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                    if strings.HasPrefix(authToken, "bearer ") {
                                        authToken = authToken[7:]
                                    }
                Severity: Major
                Found in src/jetstream/plugins/desktop/tokens.go - About 45 mins to fix

                  Method CloudFoundrySpecification.openNoaaConsumer has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                  Open

                  func (c CloudFoundrySpecification) openNoaaConsumer(echoContext echo.Context) (*AuthorizedConsumer, error) {
                  
                      ac := &AuthorizedConsumer{}
                  
                      // Get the CNSI and app IDs from route parameters
                  Severity: Minor
                  Found in src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method portalProxy.buildCNSIRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (p *portalProxy) buildCNSIRequest(cnsiGUID string, userGUID string, method string, uri *url.URL, body []byte, header http.Header) (interfaces.CNSIRequest, error) {
                  Severity: Minor
                  Found in src/jetstream/passthrough.go - About 45 mins to fix

                    Method PgsqlTokenRepository.SaveAuthToken has 7 return statements (exceeds 4 allowed).
                    Open

                    func (p *PgsqlTokenRepository) SaveAuthToken(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
                        log.Debug("SaveAuthToken")
                        if userGUID == "" {
                            msg := "Unable to save Auth Token without a valid User GUID."
                            log.Debug(msg)
                    Severity: Major
                    Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 45 mins to fix

                      Method PgsqlTokenRepository.findCNSIToken has 7 return statements (exceeds 4 allowed).
                      Open

                      func (p *PgsqlTokenRepository) findCNSIToken(cnsiGUID string, userGUID string, encryptionKey []byte, includeDisconnected bool) (interfaces.TokenRecord, error) {
                          log.Debug("findCNSIToken")
                          if cnsiGUID == "" {
                              msg := "Unable to find CNSI Token without a valid CNSI GUID."
                              log.Debug(msg)
                      Severity: Major
                      Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 45 mins to fix

                        Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                        Open

                          constructor(
                            private store: Store<CFAppState>,
                            private activeRouteCfOrgSpace: ActiveRouteCfOrgSpace,
                            private cfUserService: CfUserService,
                            private route: ActivatedRoute

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function constructor has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                        Open

                          constructor(dir: string, options?: any, loggingEnabled = true) {
                            this.angularJsonFile = this.findFileOrFolderInChain(dir, 'angular.json');
                            this.angularJson = JSON.parse(fs.readFileSync(this.angularJsonFile, 'utf8').toString());
                            this.loggingEnabled = loggingEnabled;
                        
                        
                        Severity: Minor
                        Found in src/frontend/packages/devkit/src/lib/stratos.config.ts - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function apply has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
                        Open

                          public apply(src: string): string {
                        
                            // Patch different page title if there is one
                            const title = this.config.stratosConfig.title || 'Stratos';
                            src = src.replace(/@@TITLE@@/g, title);
                        Severity: Minor
                        Found in src/frontend/packages/devkit/src/build/index.transform.ts - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language