cloudfoundry/stratos

View on GitHub

Showing 1,155 of 1,370 total issues

File cf-org-card.component.spec.ts has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { Store } from '@ngrx/store';
import { testSessionData } from '@stratosui/store/testing';

import { ConfirmationDialogService } from '../../../../../../../../core/src/shared/components/confirmation-dialog.service';

    Function endpointActions has 136 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      endpointActions(includeSeparators = false): IListAction<EndpointModel>[] {
        // Add any additional actions that are per endpoint type
        const customActions = entityCatalog.getAllEndpointTypes()
          .map(endpoint => endpoint.definition.endpointListActions)
          .filter(endpointListActions => !!endpointListActions)

      File cf-user.service.ts has 391 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { Injectable } from '@angular/core';
      import { Store } from '@ngrx/store';
      import { combineLatest, Observable, of as observableOf, of, ReplaySubject } from 'rxjs';
      import { filter, first, map, multicast, publishReplay, refCount, startWith, switchMap } from 'rxjs/operators';
      
      

        Function initialise has a Cognitive Complexity of 38 (exceeds 8 allowed). Consider refactoring.
        Open

          private initialise() {
            this.globalActions = this.setupActionsDefaultObservables(
              this.config.getGlobalActions()
            );
            this.multiActions = this.setupActionsDefaultObservables(

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File cf.helpers.ts has 380 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import { ActivatedRoute } from '@angular/router';
        import { Store } from '@ngrx/store';
        import { combineLatest, Observable } from 'rxjs';
        import { filter, first, map, publishReplay, refCount, switchMap, tap } from 'rxjs/operators';
        
        
        Severity: Minor
        Found in src/frontend/packages/cloud-foundry/src/features/cf/cf.helpers.ts - About 5 hrs to fix

          Function main has a Cognitive Complexity of 37 (exceeds 8 allowed). Consider refactoring.
          Open

          func main() {
          
              // Register time.Time in gob
              gob.Register(time.Time{})
          
          
          Severity: Minor
          Found in src/jetstream/main.go - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method portalProxy.ProxyRequest has a Cognitive Complexity of 37 (exceeds 8 allowed). Consider refactoring.
          Open

          func (p *portalProxy) ProxyRequest(c echo.Context, uri *url.URL) (map[string]*interfaces.CNSIRequest, error) {
              log.Debug("ProxyRequest")
              cnsiList := strings.Split(c.Request().Header.Get("x-cap-cnsi-list"), ",")
              shouldPassthrough := "true" == c.Request().Header.Get("x-cap-passthrough")
              longRunning := "true" == c.Request().Header.Get(longRunningTimeoutHeader)
          Severity: Minor
          Found in src/jetstream/passthrough.go - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method portalProxy.DoRegisterEndpoint has a Cognitive Complexity of 36 (exceeds 8 allowed). Consider refactoring.
          Open

          func (p *portalProxy) DoRegisterEndpoint(cnsiName string, apiEndpoint string, skipSSLValidation bool, clientId string, clientSecret string, userId string, ssoAllowed bool, subType string, createSystemEndpoint bool, fetchInfo interfaces.InfoFunc) (interfaces.CNSIRecord, error) {
              log.Debug("DoRegisterEndpoint")
          
              if len(cnsiName) == 0 || len(apiEndpoint) == 0 {
                  return interfaces.CNSIRecord{}, interfaces.NewHTTPShadowError(
          Severity: Minor
          Found in src/jetstream/cnsi.go - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File autoscaler-tab-extension.component.ts has 369 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import { Component, OnDestroy, OnInit } from '@angular/core';
          import { MatSnackBar, MatSnackBarRef, SimpleSnackBar } from '@angular/material/snack-bar';
          import { ActivatedRoute } from '@angular/router';
          import { Store } from '@ngrx/store';
          import { combineLatest, Observable, of, Subscription } from 'rxjs';

            File combo-chart.component.ts has 365 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import {
              Component,
              ContentChild,
              EventEmitter,
              HostListener,

              File cf-shared.module.ts has 365 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import { CommonModule } from '@angular/common';
              import { ApplicationModule, NgModule, Type } from '@angular/core';
              import { MaterialDesignFrameworkModule } from '@cfstratos/ajsf-material';
              
              import { CoreModule } from '../../../core/src/core/core.module';
              Severity: Minor
              Found in src/frontend/packages/cloud-foundry/src/shared/cf-shared.module.ts - About 4 hrs to fix

                File schema-tree-traverse.spec.ts has 357 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import { RecursiveDelete } from '../effects/recursive-entity-delete.effect';
                import { EntitySchema } from './entity-schema';
                import { EntitySchemaTreeBuilder, IFlatTreeValue } from './schema-tree-traverse';
                
                describe('SchemaTreeTraversal', () => {
                Severity: Minor
                Found in src/frontend/packages/store/src/helpers/schema-tree-traverse.spec.ts - About 4 hrs to fix

                  File cf-api.types.ts has 353 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import { APIResource } from '../../store/src/types/api.types';
                  import { IService, IServiceBinding } from './cf-api-svc.types';
                  import { CfUser } from './store/types/cf-user.types';
                  
                  export interface StratosCFEntity {
                  Severity: Minor
                  Found in src/frontend/packages/cloud-foundry/src/cf-api.types.ts - About 4 hrs to fix

                    Function deployAppReducer has 110 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function deployAppReducer(state: DeployApplicationState = defaultState, action): DeployApplicationState {
                      switch (action.type) {
                        case SET_APP_SOURCE_DETAILS:
                          return {
                            ...state,

                      Function StratosSpecReporter has 108 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        var StratosSpecReporter = function (baseReporterDecorator, config) {
                          baseReporterDecorator(this);
                      
                          const reporterConfig = Object.assign({}, config.stratosReporter);
                          this.file = reporterConfig.reportFile || './stratos-test-report.log';
                      Severity: Major
                      Found in build/karma.test.reporter.js - About 4 hrs to fix

                        Function createPodExpandedStatus has 106 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          static createPodExpandedStatus(pod: KubernetesPod): KubernetesPodExpandedStatus {
                        
                            let restarts = 0;
                            const totalContainers = pod.spec.containers ? pod.spec.containers.length : 0;
                            let readyContainers = 0;

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          func (p *PgsqlLocalUsersRepository) AddLocalUser(user interfaces.LocalUser) error {
                          
                              log.Debug("AddLocalUser")
                          
                              //Validate args
                          Severity: Major
                          Found in src/jetstream/repository/localusers/psql_localusers.go and 1 other location - About 4 hrs to fix
                          src/jetstream/repository/localusers/psql_localusers.go on lines 279..326

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 424.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          func (p *PgsqlLocalUsersRepository) UpdateLocalUser(user interfaces.LocalUser) error {
                              log.Debug("UpdateLocalUser")
                          
                              //Validate args
                              var err error
                          Severity: Major
                          Found in src/jetstream/repository/localusers/psql_localusers.go and 1 other location - About 4 hrs to fix
                          src/jetstream/repository/localusers/psql_localusers.go on lines 229..277

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 424.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          ListHeaderComponent has 33 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          export class ListHeaderComponent extends Component {
                          
                            listLocator: ElementFinder;
                          
                            constructor(locator: ElementFinder) {
                          Severity: Minor
                          Found in src/test-e2e/po/list.po.ts - About 4 hrs to fix

                            File kubernetes.actions.ts has 337 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            import { SortDirection } from '@angular/material/sort';
                            import { Action } from '@ngrx/store';
                            import { getActions } from 'frontend/packages/store/src/actions/action.helper';
                            import { ApiRequestTypes } from 'frontend/packages/store/src/reducers/api-request-reducer/request-helpers';
                            
                            
                              Severity
                              Category
                              Status
                              Source
                              Language