cloudfoundry/stratos

View on GitHub

Showing 718 of 1,370 total issues

Method Analysis.checkStatus has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

func (c *Analysis) checkStatus() error {
    log.Debug("Checking status....")
    p := c.portalProxy
    // Create a record in the reports datastore
    dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())
Severity: Minor
Found in src/jetstream/plugins/analysis/status.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method portalProxy.OAuthHandlerFunc has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

func (p *portalProxy) OAuthHandlerFunc(cnsiRequest *interfaces.CNSIRequest, req *http.Request, refreshOAuthTokenFunc interfaces.RefreshOAuthTokenFunc) interfaces.AuthHandlerFunc {

    return func(tokenRec interfaces.TokenRecord, cnsi interfaces.CNSIRecord) (*http.Response, error) {

        got401 := false
Severity: Minor
Found in src/jetstream/oauth_requests.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

func init() {
    RegisterMigration(20170818120003, "InitialSchema", func(txn *sql.Tx, conf *goose.DBConf) error {
        binaryDataType := "BYTEA"
        if strings.Contains(conf.Driver.Name, "mysql") {
            binaryDataType = "BLOB"
Severity: Minor
Found in src/jetstream/datastore/20170818120003_InitialSchema.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildJSONResponse has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

func buildJSONResponse(cnsiList []string, responses map[string]*interfaces.CNSIRequest) map[string]*json.RawMessage {
    log.Debug("buildJSONResponse")
    jsonResponse := make(map[string]*json.RawMessage)
    for _, guid := range cnsiList {
        var response []byte
Severity: Minor
Found in src/jetstream/passthrough.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

  constructor(
    store: Store<CFAppState>,
    listConfig: IListConfig<APIResource>,
    cfGuid: string,
    action: PaginatedAction,

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function removeUserActions has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

  removeUserActions(): IListAction<APIResource<CfUser>>[] {
    const activeRouteCfOrgSpace = this.cfUserService.activeRouteCfOrgSpace;
    const orgGuid = activeRouteCfOrgSpace.orgGuid;
    const spaceGuid = activeRouteCfOrgSpace.spaceGuid;
    const isCfContext = !orgGuid && !spaceGuid;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleFileInputSelection has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

  handleFileInputSelection(items): Observable<FileScannerInfo> {
    const obs$ = new BehaviorSubject<DeployApplicationFSScanner>(undefined);
    let scanner = new DeployApplicationFSScanner(CF_DEFAULT_IGNORES);
    let cfIgnoreFile;
    let manifestFile = false;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function start has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

  public start() {
    if (this.isStarted()) {
      return;
    }

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function install has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  module.exports.install = function (jasmine) {
    const global = jasmine.getGlobal();
    const _super = {
      describe: global.describe,
      fdescribe: global.fdescribe,
Severity: Major
Found in src/test-e2e/skip-plugin.js - About 2 hrs to fix

    Function sub has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.sub = messages.subscribe(jsonString => {
          const messageObj = JSON.parse(jsonString);
          if (messageObj) {
            if (messageObj.kind === 'ReleasePrefix') {
              prefix = messageObj.data;

      Function constructor has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(
          activatedRoute: ActivatedRoute,
        ) {
          this.editEndpoint = new FormGroup({
            name: new FormControl('', [Validators.required as any]),

        File kubernetes-endpoint.service.ts has 253 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import { Injectable } from '@angular/core';
        import { Store } from '@ngrx/store';
        import { combineLatest, Observable, of } from 'rxjs';
        import { filter, first, map, shareReplay, startWith, switchMap } from 'rxjs/operators';
        
        

          Function fetchPolicy has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private fetchPolicy(
              getPolicyAction: GetAppAutoscalerPolicyAction,
              getPolicyTriggerAction?: GetAppAutoscalerPolicyTriggerAction): Observable<Action> {
              const actionType = 'fetch';
              this.store.dispatch(new StartRequestAction(getPolicyAction, actionType));
          Severity: Major
          Found in src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts - About 2 hrs to fix

            Function constructor has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              constructor(
                private activatedRoute: ActivatedRoute,
                router: Router
              ) {
                const serviceId = getIdFromRoute(activatedRoute, 'serviceId');

              Function removeUserActions has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                removeUserActions(): IListAction<APIResource<CfUser>>[] {
                  const activeRouteCfOrgSpace = this.cfUserService.activeRouteCfOrgSpace;
                  const orgGuid = activeRouteCfOrgSpace.orgGuid;
                  const spaceGuid = activeRouteCfOrgSpace.spaceGuid;
                  const isCfContext = !orgGuid && !spaceGuid;

                Function getColumns has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  private getColumns(definition: KubeResourceEntityDefinition): ITableColumn<KubeAPIResource>[] {
                    const component = this.uiConfigService.previewComponent.get(definition.type);
                    let columns: Array<ITableColumn<KubeAPIResource>> = [
                      // Name
                      {

                  Function parse has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    public parse(config: string): Observable<string> {
                      let doc: KubeConfigFile;
                  
                      const clusters: { [name: string]: KubeConfigFileCluster, } = {};
                  
                  

                    Method CFPushApp.Init has 74 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (c *CFPushApp) Init(appDir string, manifestPath string, overrides CFPushAppOverrides) error {
                    
                        // App name
                        if len(overrides.Name) > 0 {
                            c.pushCommand.OptionalArgs = flag.OptionalAppName{
                    Severity: Minor
                    Found in src/jetstream/plugins/cfapppush/pushapp.go - About 1 hr to fix

                      Function constructor has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        constructor(
                          store: Store<CFAppState>,
                          listConfig: IListConfig<APIResource>,
                          cfGuid: string,
                          action: PaginatedAction,

                        Function generateCfTopLevelStoreEntities has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function generateCfTopLevelStoreEntities() {
                          return {
                            createApplication: {
                              cloudFoundryDetails: null,
                              name: '',
                          Severity
                          Category
                          Status
                          Source
                          Language