Showing 718 of 1,370 total issues
Function getOrgRoles
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export function getOrgRoles(userRolesInOrg: UserRoleInOrg): IUserRole<OrgUserRoleNames>[] {
const roles = [];
if (userRolesInOrg[OrgUserRoleNames.MANAGER]) {
roles.push({
string: UserRoleLabels.org.short[OrgUserRoleNames.MANAGER],
Function setUpBreadcrumbs
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private setUpBreadcrumbs(
cfEndpointService: CloudFoundryEndpointService,
cfOrgService: CloudFoundryOrganizationService
) {
this.breadcrumbs$ = combineLatest(
Function editModeChanged
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
editModeChanged(mode) {
this.mode = mode.value;
if (this.mode === EditorMode.CodeEditor) {
// Form -> Editor
Function connectEndpoint
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private connectEndpoint(action: KubeConfigImportAction, pData: ConnectEndpointData): Observable<IActionMonitorComponentState> {
const config: ConnectEndpointConfig = {
name: action.cluster.name,
guid: action.depends.cluster._guid || action.cluster._guid,
type: KUBERNETES_ENDPOINT_TYPE,
Function buildFullCleanPageObservable
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private buildFullCleanPageObservable(
cleanPage$: Observable<T[]>,
cleanPagination$: Observable<PaginationEntityState>,
dataFunctions?: DataFunction<any>[]) {
const fullPageObs$ = combineLatest(
Function reconnect
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
reconnect() {
this.isConnecting = true;
this.errorMessage = undefined;
this.xterm.reset();
this.msgSubscription = this.sshStream
Method Analysis.doRunReport
has 10 return statements (exceeds 4 allowed). Open
Open
func (c *Analysis) doRunReport(ec echo.Context, analyzer, endpointID, userID string, dbStore store.AnalysisStore, report *store.AnalysisRecord) error {
// Get Kube Config
k8s := c.portalProxy.GetPlugin("kubernetes")
if k8s == nil {
Method UserInvite.invite
has 10 return statements (exceeds 4 allowed). Open
Open
func (invite *UserInvite) invite(c echo.Context) error {
log.Debug("Invite User")
cfGUID := c.Param("id")
// Check that there is an endpoint with the specified ID and that it is a Cloud Foundry endpoint
Method UserInvite.UAAUserInvite
has 10 return statements (exceeds 4 allowed). Open
Open
func (invite *UserInvite) UAAUserInvite(c echo.Context, endpoint interfaces.CNSIRecord, uaaInviteReq *UserInviteReq) (*UserInviteResponse, error) {
log.Debug("Requesting invite links from UAA")
// See if we can get a token for the invite user
token, ok := invite.portalProxy.GetCNSITokenRecord(endpoint.GUID, UserInviteUserID)
Method portalProxy.DoRegisterEndpoint
has 10 return statements (exceeds 4 allowed). Open
Open
func (p *portalProxy) DoRegisterEndpoint(cnsiName string, apiEndpoint string, skipSSLValidation bool, clientId string, clientSecret string, userId string, ssoAllowed bool, subType string, createSystemEndpoint bool, fetchInfo interfaces.InfoFunc) (interfaces.CNSIRecord, error) {
log.Debug("DoRegisterEndpoint")
if len(cnsiName) == 0 || len(apiEndpoint) == 0 {
return interfaces.CNSIRecord{}, interfaces.NewHTTPShadowError(
Function KubeDashboardLogin
has 10 return statements (exceeds 4 allowed). Open
Open
func KubeDashboardLogin(c echo.Context, p interfaces.PortalProxy) error {
log.Debug("kubeDashboardLogin request")
endpointGUID := c.Param("guid")
userGUID := c.Get("user_id").(string)
Method PgsqlTokenRepository.SaveCNSIToken
has 10 return statements (exceeds 4 allowed). Open
Open
func (p *PgsqlTokenRepository) SaveCNSIToken(cnsiGUID string, userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
log.Debug("SaveCNSIToken")
if cnsiGUID == "" {
msg := "Unable to save CNSI Token without a valid CNSI GUID."
log.Debug(msg)
Method PgsqlTokenRepository.UpdateTokenAuth
has 10 return statements (exceeds 4 allowed). Open
Open
func (p *PgsqlTokenRepository) UpdateTokenAuth(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
log.Debug("UpdateTokenAuth")
if userGUID == "" {
msg := "Unable to save Token without a valid User GUID."
Function flattenPagination
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
actionDispatcher: ActionDispatcher,
firstRequest: Observable<C>,
flattener: PaginationFlattener<T, C>,
maxCount?: number,
entityType?: string,
Method MetricsSpecification.Connect
has 9 return statements (exceeds 4 allowed). Open
Open
func (m *MetricsSpecification) Connect(ec echo.Context, cnsiRecord interfaces.CNSIRecord, userId string) (*interfaces.TokenRecord, bool, error) {
log.Debug("Metrics Connect...")
params := new(interfaces.LoginToCNSIParams)
err := interfaces.BindOnce(params, ec)
Function makePrometheusRequestURI
has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring. Open
Open
func makePrometheusRequestURI(c echo.Context, prometheusOp string, modify string) *url.URL {
uri := getEchoURL(c)
uri.Path = "/api/v1/" + prometheusOp
values := uri.Query()
query := values.Get("query")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method KubernetesSpecification.InstallRelease
has 9 return statements (exceeds 4 allowed). Open
Open
func (c *KubernetesSpecification) InstallRelease(ec echo.Context) error {
bodyReader := ec.Request().Body
buf := new(bytes.Buffer)
buf.ReadFrom(bodyReader)
Method KubeTerminal.Start
has 9 return statements (exceeds 4 allowed). Open
Open
func (k *KubeTerminal) Start(c echo.Context) error {
log.Debug("Kube Terminal start request")
endpointGUID := c.Param("guid")
userGUID := c.Get("user_id").(string)
Method Monocular.cleanCacheFiles
has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring. Open
Open
func (m *Monocular) cleanCacheFiles(endpointID string, allCharts []store.ChartStoreRecord) error {
// Build map of the valid chart folder names
validFiles := make(map[string]bool)
for _, chart := range allCharts {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Analysis.checkStatus
has 9 return statements (exceeds 4 allowed). Open
Open
func (c *Analysis) checkStatus() error {
log.Debug("Checking status....")
p := c.portalProxy
// Create a record in the reports datastore
dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())