Sign upLogin

cloudfoundry/stratos

View on GitHub
Star

Showing 718 of 1,370 total issues

Method portalProxy.setupSaveConfig has 6 return statements (exceeds 4 allowed).
Open

func (p *portalProxy) setupSaveConfig(c echo.Context) error {

    log.Debug("setupSaveConfig")

    consoleRepo, err := console_config.NewPostgresConsoleConfigRepository(p.DatabaseConnectionPool)
Severity: Major
Found in src/jetstream/setup_console.go - About 40 mins to fix

    Method PostgresCNSIRepository.List has 6 return statements (exceeds 4 allowed).
    Open

    func (p *PostgresCNSIRepository) List(encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    log.Debug("List")
    rows, err := p.db.Query(listCNSIs)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
    Severity: Major
    Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

      Function CreateServiceAccount has 6 return statements (exceeds 4 allowed).
      Open

      func CreateServiceAccount(p interfaces.PortalProxy, endpointGUID, userGUID string) error {
    log.Debug("CreateServiceAccount")

    svc, err := getKubeDashboardServiceInfo(p, endpointGUID, userGUID)
    if err != nil {
      Severity: Major
      Found in src/jetstream/plugins/kubernetes/dashboard/configure.go - About 40 mins to fix

        Method CustomBinder.bindData has 6 return statements (exceeds 4 allowed).
        Open

        func (b *CustomBinder) bindData(ptr interface{}, data map[string][]string, tag string) error {
    typ := reflect.TypeOf(ptr).Elem()
    val := reflect.ValueOf(ptr).Elem()

    if typ.Kind() != reflect.Struct {
        Severity: Major
        Found in src/jetstream/custombinder/custombinder.go - About 40 mins to fix

          Method portalProxy.logoutOfCNSI has 6 return statements (exceeds 4 allowed).
          Open

          func (p *portalProxy) logoutOfCNSI(c echo.Context) error {
    log.Debug("logoutOfCNSI")

    cnsiGUID := c.Param("cnsi_guid")
          Severity: Major
          Found in src/jetstream/authcnsi.go - About 40 mins to fix

            Function ApplyMigrations has 6 return statements (exceeds 4 allowed).
            Open

            func ApplyMigrations(conf *goose.DBConf, db *sql.DB) error {
    current, err := goose.EnsureDBVersion(conf, db)
    if err != nil {
        return fmt.Errorf("Failed to get database version: %s", err.Error())
    }
            Severity: Major
            Found in src/jetstream/datastore/datastore_migrator.go - About 40 mins to fix

              Method UserFavorites.setMetadata has 6 return statements (exceeds 4 allowed).
              Open

              func (uf *UserFavorites) setMetadata(c echo.Context) error {

    store, err := userfavoritesstore.NewFavoritesDBStore(uf.portalProxy.GetDatabaseConnection())
    if err != nil {
        return err
              Severity: Major
              Found in src/jetstream/plugins/userfavorites/favorites.go - About 40 mins to fix

                Method portalProxy.initialiseConsoleConfig has 6 return statements (exceeds 4 allowed).
                Open

                func (p *portalProxy) initialiseConsoleConfig(envLookup *env.VarSet) (*interfaces.ConsoleConfig, error) {
    log.Debug("initialiseConsoleConfig")

    consoleConfig := &interfaces.ConsoleConfig{}
    if err := config.Load(consoleConfig, envLookup.Lookup); err != nil {
                Severity: Major
                Found in src/jetstream/setup_console.go - About 40 mins to fix

                  Method ConsoleConfigRepository.GetConsoleConfig has 6 return statements (exceeds 4 allowed).
                  Open

                  func (c *ConsoleConfigRepository) GetConsoleConfig() (*interfaces.ConsoleConfig, error) {
    log.Debug("Get ConsoleConfig")
    rows, err := c.db.Query(getConsoleConfig)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve console config record: %v", err)
                  Severity: Major
                  Found in src/jetstream/repository/console_config/psql_console_config.go - About 40 mins to fix

                    Function getKubeDashboardSecretToken has 6 return statements (exceeds 4 allowed).
                    Open

                    func getKubeDashboardSecretToken(p interfaces.PortalProxy, cnsiGUID, userGUID string, sa *v1.ServiceAccount) (string, error) {
    log.Debug("getKubeDashboardSecretToken request")

    namespace := sa.Namespace
                    Severity: Major
                    Found in src/jetstream/plugins/kubernetes/dashboard/common.go - About 40 mins to fix

                      Function saveLocalUserConsoleConfig has 6 return statements (exceeds 4 allowed).
                      Open

                      func saveLocalUserConsoleConfig(consoleRepo console_config.Repository, consoleConfig *interfaces.ConsoleConfig) error {

    log.Debug("saveLocalUserConsoleConfig")

    if err := consoleRepo.SetValue(systemGroupName, "AUTH_ENDPOINT_TYPE", "local"); err != nil {
                      Severity: Major
                      Found in src/jetstream/setup_console.go - About 40 mins to fix

                        Method CloudFoundrySpecification.cfLoginHook has 6 return statements (exceeds 4 allowed).
                        Open

                        func (c *CloudFoundrySpecification) cfLoginHook(context echo.Context) error {

    cfAPI, cfCnsi, err := c.fetchAutoRegisterEndpoint()
    // CF auto reg url missing, continue as normal
    if cfAPI == "" {
                        Severity: Major
                        Found in src/jetstream/plugins/cloudfoundry/main.go - About 40 mins to fix

                          Method portalProxy.ssoLoginToCNSI has 6 return statements (exceeds 4 allowed).
                          Open

                          func (p *portalProxy) ssoLoginToCNSI(c echo.Context) error {
    log.Debug("ssoLoginToCNSI")
    endpointGUID := c.QueryParam("guid")
    if len(endpointGUID) == 0 {
        return interfaces.NewHTTPShadowError(
                          Severity: Major
                          Found in src/jetstream/authcnsi.go - About 40 mins to fix

                            Method CloudFoundrySpecification.openNoaaConsumer has 6 return statements (exceeds 4 allowed).
                            Open

                            func (c CloudFoundrySpecification) openNoaaConsumer(echoContext echo.Context) (*AuthorizedConsumer, error) {

    ac := &AuthorizedConsumer{}

    // Get the CNSI and app IDs from route parameters
                            Severity: Major
                            Found in src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go - About 40 mins to fix

                              Method PostgresCNSIRepository.Update has 6 return statements (exceeds 4 allowed).
                              Open

                              func (p *PostgresCNSIRepository) Update(endpoint interfaces.CNSIRecord, encryptionKey []byte) error {
    log.Debug("Update endpoint")

    if endpoint.GUID == "" {
        msg := "Unable to update Endpoint without a valid guid."
                              Severity: Major
                              Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

                                Method GeneratedEndpointPlugin.Connect has 6 return statements (exceeds 4 allowed).
                                Open

                                func (gep GeneratedEndpointPlugin) Connect(ec echo.Context, cnsiRecord interfaces.CNSIRecord, userId string) (*interfaces.TokenRecord, bool, error) {
    params := new(interfaces.LoginToCNSIParams)
    err := interfaces.BindOnce(params, ec)
    if err != nil {
        return nil, false, err
                                Severity: Major
                                Found in src/jetstream/plugins/yamlgenerated/main.go - About 40 mins to fix

                                  Method uaaAuth.VerifySession has 6 return statements (exceeds 4 allowed).
                                  Open

                                  func (a *uaaAuth) VerifySession(c echo.Context, sessionUser string, sessionExpireTime int64) error {

    tr, err := a.p.GetUAATokenRecord(sessionUser)

    if err != nil {
                                  Severity: Major
                                  Found in src/jetstream/authuaa.go - About 40 mins to fix

                                    Consider simplifying this complex logical expression.
                                    Open

                                        if (!secrets ||
      !secrets.consoleUsers || !secrets.consoleUsers.admin || !secrets.consoleUsers.nonAdmin ||
      !secrets.endpoints || !secrets.endpoints.cf
    ) {
      throw new Error(`Failed to validate secrets`);
                                    Severity: Major
                                    Found in src/test-e2e/helpers/secrets-helpers.ts - About 40 mins to fix

                                      Consider simplifying this complex logical expression.
                                      Open

                                        if (ep.provider && ep.provider.metadata && ep.provider.metadata && ep.provider.metadata.metrics_stratos
    && Array.isArray(ep.provider.metadata.metrics_stratos)) {
    ep.provider.metadata.metrics_stratos.forEach(endp => {
      // See if we already know about this endpoint
      const hasEndpoint = data.findIndex(i => compareUrl(i.url, endp.url) || compareUrl(i.url, endp.cfEndpoint)) !== -1;
                                      Severity: Major
                                      Found in src/frontend/packages/core/src/features/metrics/metrics.helpers.ts - About 40 mins to fix

                                        Function initSessionStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                        func initSessionStore(db *sql.DB, databaseProvider string, pc interfaces.PortalConfig, sessionExpiry int, env *env.VarSet) (HttpSessionStore, *sessions.Options, error) {
                                        Severity: Minor
                                        Found in src/jetstream/main.go - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language