Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/frontend/packages/cloud-foundry/src/features/applications/application.service.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function constructAmalgamatedObservables has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private constructAmalgamatedObservables() {
    // Assign/Amalgamate them to public properties (with mangling if required)
    const appStats = cfEntityCatalog.appStats.store.getPaginationService(this.appGuid, this.cfGuid);
    // This will fail to fetch the app stats if the current app is not running but we're
    // willing to do this to speed up the initial fetch for a running application.
Severity: Minor
Found in src/frontend/packages/cloud-foundry/src/features/applications/application.service.ts - About 1 hr to fix

    Function constructCoreObservables has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private constructCoreObservables() {
    // First set up all the base observables
    this.app$ = this.entityService.waitForEntity$;
    const moreWaiting$ = this.app$.pipe(
      filter(entityInfo => !!(entityInfo.entity && entityInfo.entity.entity && entityInfo.entity.entity.cfGuid)),
    Severity: Minor
    Found in src/frontend/packages/cloud-foundry/src/features/applications/application.service.ts - About 1 hr to fix

      Function constructStatusObservables has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private constructStatusObservables() {
    this.isFetchingApp$ = this.entityService.isFetchingEntity$;

    this.isUpdatingApp$ = this.entityService.entityObs$.pipe(map(a => {
      const updatingRoot = a.entityRequestInfo.updating[rootUpdatingKey] || { busy: false };
      Severity: Minor
      Found in src/frontend/packages/cloud-foundry/src/features/applications/application.service.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status