Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/specify-details-step/specify-details-step.component.ts

Summary

Maintainability
C
1 day
Test Coverage

File specify-details-step.component.ts has 444 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { COMMA, ENTER, SPACE } from '@angular/cdk/keycodes';
import { AfterContentInit, Component, Input, OnDestroy } from '@angular/core';
import { AbstractControl, FormControl, FormGroup, ValidatorFn, Validators } from '@angular/forms';
import { MatChipInputEvent } from '@angular/material/chips';
import { Store } from '@ngrx/store';
Severity: Minor
Found in src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/specify-details-step/specify-details-step.component.ts - About 6 hrs to fix

    SpecifyDetailsStepComponent has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'app-specify-details-step',
  templateUrl: './specify-details-step.component.html',
  styleUrls: ['./specify-details-step.component.scss'],
})
    Severity: Minor
    Found in src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/specify-details-step/specify-details-step.component.ts - About 2 hrs to fix

      Function constructor has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(
    private store: Store<CFAppState>,
    private cSIHelperServiceFactory: CreateServiceInstanceHelperServiceFactory,
    private csiGuidsService: CsiGuidsService,
    public modeService: CsiModeService,
      Severity: Major
      Found in src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/specify-details-step/specify-details-step.component.ts - About 2 hrs to fix

        Function createServiceInstance has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          createServiceInstance(createServiceInstance: CreateServiceInstanceState): Observable<RequestInfoState> {

    const name = this.createNewInstanceForm.controls.name.value;
    const { spaceGuid, cfGuid } = createServiceInstance;
    const servicePlanGuid = createServiceInstance.servicePlanGuid;
        Severity: Minor
        Found in src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/specify-details-step/specify-details-step.component.ts - About 1 hr to fix

          Function handleCreateServiceResult has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

            private handleCreateServiceResult(request: RequestInfoState, state: CreateServiceInstanceState): Observable<StepOnNextResult> {
    const bindApp = !!state.bindAppGuid;

    if (this.longRunningOpService.isLongRunning(request)) {
      // This request has taken too long for the browser/jetstream and is on going. Treat this as a success
          Severity: Minor
          Found in src/frontend/packages/cloud-foundry/src/shared/components/add-service-instance/specify-details-step/specify-details-step.component.ts - About 1 hr to fix

            There are no issues that match your filters.

            Category
            Status