Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function getObservables has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getObservables<T = any>(
  store: Store<GeneralEntityAppState>,
  entityKey: string,
  paginationKey: string,
  paginationAction: PaginatedAction | PaginatedAction[],
Severity: Major
Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts - About 2 hrs to fix

    Function getObservables has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      store: Store<GeneralEntityAppState>,
  entityKey: string,
  paginationKey: string,
  paginationAction: PaginatedAction | PaginatedAction[],
  paginationMonitor: PaginationMonitor,
    Severity: Minor
    Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts - About 45 mins to fix

      Avoid too many return statements within this function.
      Wontfix

        return false;
      Severity: Major
      Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts - About 30 mins to fix

        FIXME found
        Open

        // FIXME: Add typings, should be done with #1477
        Severity: Minor
        Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts by fixme

        FIXME found
        Open

        // FIXME: Add typings, should be done with #1477
        Severity: Minor
        Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts by fixme

        FIXME found
        Open

        // FIXME: Add typings, should be done with #1477
        Severity: Minor
        Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts by fixme

        FIXME found
        Open

          // FIXME: This will reset pagination every time regardless of if we need to (or just want the pag settings/entities from pagination
        Severity: Minor
        Found in src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.helper.ts by fixme

        There are no issues that match your filters.

        Category
        Status