Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/jetstream/auth.go

Summary

Maintainability
A
1 hr
Test Coverage

Method portalProxy.login has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (p *portalProxy) login(c echo.Context, skipSSLValidation bool, client string, clientSecret string, endpoint string) (uaaRes *interfaces.UAAResponse, u *interfaces.JWTUserTokenInfo, err error) {
Severity: Minor
Found in src/jetstream/auth.go - About 35 mins to fix

    Method portalProxy.login has 5 return statements (exceeds 4 allowed).
    Open

    func (p *portalProxy) login(c echo.Context, skipSSLValidation bool, client string, clientSecret string, endpoint string) (uaaRes *interfaces.UAAResponse, u *interfaces.JWTUserTokenInfo, err error) {
    log.Debug("login")
    if c.Request().Method == http.MethodGet {
        code := c.QueryParam("code")
        state := c.QueryParam("state")
    Severity: Major
    Found in src/jetstream/auth.go - About 35 mins to fix

      Method portalProxy.login has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
      Open

      func (p *portalProxy) login(c echo.Context, skipSSLValidation bool, client string, clientSecret string, endpoint string) (uaaRes *interfaces.UAAResponse, u *interfaces.JWTUserTokenInfo, err error) {
    log.Debug("login")
    if c.Request().Method == http.MethodGet {
        code := c.QueryParam("code")
        state := c.QueryParam("state")
      Severity: Minor
      Found in src/jetstream/auth.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status