Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method CloudFoundrySpecification.openNoaaConsumer has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

func (c CloudFoundrySpecification) openNoaaConsumer(echoContext echo.Context) (*AuthorizedConsumer, error) {

    ac := &AuthorizedConsumer{}

    // Get the CNSI and app IDs from route parameters
Severity: Minor
Found in src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method CloudFoundrySpecification.openNoaaConsumer has 6 return statements (exceeds 4 allowed).
Open

func (c CloudFoundrySpecification) openNoaaConsumer(echoContext echo.Context) (*AuthorizedConsumer, error) {

    ac := &AuthorizedConsumer{}

    // Get the CNSI and app IDs from route parameters
Severity: Major
Found in src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go - About 40 mins to fix

    Function getRecentLogs has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
    Open

    func getRecentLogs(ac *AuthorizedConsumer, cnsiGUID, appGUID string) ([]*events.LogMessage, error) {
    log.Debug("getRecentLogs")
    messages, err := ac.consumer.RecentLogs(appGUID, ac.authToken)
    if err != nil {
        errorPattern := "Failed to get recent messages for App %s on CNSI %s [%v]"
    Severity: Minor
    Found in src/jetstream/plugins/cloudfoundry/cf_websocket_streams.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status