Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/jetstream/plugins/kubernetes/terminal/helpers.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method KubeTerminal.createPod has 98 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (k *KubeTerminal) createPod(c echo.Context, kubeConfig, kubeVersion string, ws *websocket.Conn) (*PodCreationData, error) {
    // Unique ID for the secret and pod name
    id := uuid.NewV4().String()
    id = strings.ReplaceAll(id, "-", "")
    // Names for the secret and pod
Severity: Major
Found in src/jetstream/plugins/kubernetes/terminal/helpers.go - About 2 hrs to fix

    Method KubeTerminal.createPod has a Cognitive Complexity of 10 (exceeds 8 allowed). Consider refactoring.
    Open

    func (k *KubeTerminal) createPod(c echo.Context, kubeConfig, kubeVersion string, ws *websocket.Conn) (*PodCreationData, error) {
    // Unique ID for the secret and pod name
    id := uuid.NewV4().String()
    id = strings.ReplaceAll(id, "-", "")
    // Names for the secret and pod
    Severity: Minor
    Found in src/jetstream/plugins/kubernetes/terminal/helpers.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status