Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/jetstream/repository/cnsis/pgsql_cnsis.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method PostgresCNSIRepository.List has a Cognitive Complexity of 17 (exceeds 8 allowed). Consider refactoring.
Open

func (p *PostgresCNSIRepository) List(encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    log.Debug("List")
    rows, err := p.db.Query(listCNSIs)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
Severity: Minor
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PostgresCNSIRepository.listBy has a Cognitive Complexity of 17 (exceeds 8 allowed). Consider refactoring.
Wontfix

func (p *PostgresCNSIRepository) listBy(query string, match string, encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    rows, err := p.db.Query(query, match)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
    }
Severity: Minor
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PostgresCNSIRepository.ListByUser has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
    log.Debug("ListByUser")
    rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
Severity: Minor
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PostgresCNSIRepository.listBy has 6 return statements (exceeds 4 allowed).
Wontfix

func (p *PostgresCNSIRepository) listBy(query string, match string, encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    rows, err := p.db.Query(query, match)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
    }
Severity: Major
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

    Method PostgresCNSIRepository.Update has 6 return statements (exceeds 4 allowed).
    Open

    func (p *PostgresCNSIRepository) Update(endpoint interfaces.CNSIRecord, encryptionKey []byte) error {
    log.Debug("Update endpoint")

    if endpoint.GUID == "" {
        msg := "Unable to update Endpoint without a valid guid."
    Severity: Major
    Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

      Method PostgresCNSIRepository.List has 6 return statements (exceeds 4 allowed).
      Open

      func (p *PostgresCNSIRepository) List(encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    log.Debug("List")
    rows, err := p.db.Query(listCNSIs)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
      Severity: Major
      Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

        Method PostgresCNSIRepository.ListByUser has 5 return statements (exceeds 4 allowed).
        Open

        func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
    log.Debug("ListByUser")
    rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
        Severity: Major
        Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 35 mins to fix

          Method PostgresCNSIRepository.UpdateMetadata has 5 return statements (exceeds 4 allowed).
          Open

          func (p *PostgresCNSIRepository) UpdateMetadata(guid string, metadata string) error {
    log.Debug("UpdateMetadata")

    if guid == "" {
        msg := "Unable to update Endpoint without a valid guid."
          Severity: Major
          Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                for rows.Next() {
        var (
            pCNSIType              string
            pURL                   string
            cipherTextClientSecret []byte
            Severity: Major
            Found in src/jetstream/repository/cnsis/pgsql_cnsis.go and 1 other location - About 4 hrs to fix
            src/jetstream/repository/cnsis/pgsql_cnsis.go on lines 212..254

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 348.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                for rows.Next() {
        var (
            pCNSIType              string
            pURL                   string
            cipherTextClientSecret []byte
            Severity: Major
            Found in src/jetstream/repository/cnsis/pgsql_cnsis.go and 1 other location - About 4 hrs to fix
            src/jetstream/repository/cnsis/pgsql_cnsis.go on lines 84..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 348.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status