Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/test-e2e/marketplace/services-helper-e2e.ts

Summary

Maintainability
C
1 day
Test Coverage

File services-helper-e2e.ts has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { browser, promise, protractor } from 'protractor';

import { IService, IServiceInstance, IServicePlan } from '../../frontend/packages/cloud-foundry/src/cf-api-svc.types';
import { CFResponse, createEmptyCfResponse } from '../../frontend/packages/cloud-foundry/src/store/types/cf-api.types';
import { APIResource } from '../../frontend/packages/store/src/types/api.types';
Severity: Minor
Found in src/test-e2e/marketplace/services-helper-e2e.ts - About 3 hrs to fix

    ServicesHelperE2E has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class ServicesHelperE2E {

  constructor(public e2eSetup: E2ESetup, createServiceInstance: CreateMarketplaceServiceInstance = null, seed?: ServicesHelperE2E) {
    this.cfRequestHelper = seed ? seed.cfRequestHelper : new CFRequestHelpers(e2eSetup);
    this.cfHelper = seed ? seed.cfHelper : new CFHelpers(e2eSetup);
    Severity: Minor
    Found in src/test-e2e/marketplace/services-helper-e2e.ts - About 3 hrs to fix

      Function cleanUpServiceInstances has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        cleanUpServiceInstances(serviceInstanceNames: string[], userProvided = false): promise.Promise<any> {
    // Sleeping because the service instance may not be listed in the `get services` request
    browser.sleep(1000);
    if (serviceInstanceNames.length === 0) {
      return promise.fullyResolved(createEmptyCfResponse());
      Severity: Minor
      Found in src/test-e2e/marketplace/services-helper-e2e.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status