coast-team/netflux

View on GitHub
src/service/dataChannelBuilder/Remote.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function handleMessage has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

  handleMessage(msg: proto.Message) {
    if (msg.type) {
      switch (msg.type) {
        case 'offer':
          log.webrtc('REMOTE OFFER', { offer: msg.offer })
Severity: Major
Found in src/service/dataChannelBuilder/Remote.ts - About 2 hrs to fix

    Function constructor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor(
        id: number,
        pc: RTCPeerConnection,
        send: (msg: proto.IMessage) => void,
        remotes: Map<number, Remote>,
    Severity: Minor
    Found in src/service/dataChannelBuilder/Remote.ts - About 1 hr to fix

      Function constructor has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        constructor(
          id: number,
          pc: RTCPeerConnection,
          send: (msg: proto.IMessage) => void,
          remotes: Map<number, Remote>,
      Severity: Minor
      Found in src/service/dataChannelBuilder/Remote.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        handleMessage(msg: proto.Message) {
          if (msg.type) {
            switch (msg.type) {
              case 'offer':
                log.webrtc('REMOTE OFFER', { offer: msg.offer })
      Severity: Minor
      Found in src/service/dataChannelBuilder/Remote.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status