Sign upLogin

codeclimate/test-reporter

View on GitHub
Star
formatters/cobertura/xml.go

Summary

Maintainability
A
30 mins
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (coberturaFile xmlFile) getFullFilePath(filename string) string {
    fullFilePath := filename

    for _, source := range coberturaFile.Sources {
        filepath := fmt.Sprintf("%s/%s", source.Path, filename)
Severity: Minor
Found in formatters/cobertura/xml.go and 1 other location - About 30 mins to fix
formatters/coveragepy/xml.go on lines 28..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

comment on exported type ByLineNum should be of the form "ByLineNum ..." (with optional leading article)
Open

// Interface to sort []Lines by line number
Severity: Minor
Found in formatters/cobertura/xml.go by golint

exported type Source should have comment or be unexported
Open

type Source struct {
Severity: Minor
Found in formatters/cobertura/xml.go by golint

exported type Lines should have comment or be unexported
Open

type Lines struct {
Severity: Minor
Found in formatters/cobertura/xml.go by golint

There are no issues that match your filters.

Category
Status