Sign upLogin

codeclimate/test-reporter

View on GitHub
Star

Showing 144 of 144 total issues

Method Formatter.Format has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func (r Formatter) Format() (formatters.Report, error) {
    report, err := formatters.NewReport()
    if err != nil {
        return report, err
    }
Severity: Minor
Found in formatters/lcovjson/lcovjson.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Formatter.Format has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

func (r Formatter) Format() (formatters.Report, error) {
    rep, err := formatters.NewReport()
    if err != nil {
        return rep, err
    }
Severity: Minor
Found in formatters/cobertura/cobertura.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Formatter.Format has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (r Formatter) Format() (formatters.Report, error) {
    report, err := formatters.NewReport()
    if err != nil {
        return report, err
    }
Severity: Minor
Found in formatters/xccov/xccov.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Formatter.Format has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r Formatter) Format() (formatters.Report, error) {
    rep, err := formatters.NewReport()
    if err != nil {
        return rep, err
    }
Severity: Minor
Found in formatters/cobertura/cobertura.go - About 1 hr to fix

    Method Formatter.Format has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func (r Formatter) Format() (formatters.Report, error) {
    sourcePaths := getSourcePaths()

    rep, err := formatters.NewReport()
    if err != nil {
    Severity: Minor
    Found in formatters/jacoco/jacoco.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Formatter.Format has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r Formatter) Format() (formatters.Report, error) {
    report, err := formatters.NewReport()
    if err != nil {
        return report, err
    }
    Severity: Minor
    Found in formatters/lcovjson/lcovjson.go - About 1 hr to fix

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for coverage.py formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/coveragepy/coveragepy.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for simplecov formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/simplecov/simplecov.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for clover formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/clover/clover.go and 8 other locations - About 1 hr to fix
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for xccov formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/xccov/xccov.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for cobertura formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/cobertura/cobertura.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for excoveralls formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/excoveralls/excoveralls.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for gocov formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/gocov/gocov.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for lcov formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/lcov/lcov.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/jacoco/jacoco.go on lines 27..38
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

      func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for jacoco formatter", p)
        if _, err := os.Stat(p); err == nil {
      Severity: Major
      Found in formatters/jacoco/jacoco.go and 8 other locations - About 1 hr to fix
      formatters/clover/clover.go on lines 20..31
      formatters/cobertura/cobertura.go on lines 21..32
      formatters/coveragepy/coveragepy.go on lines 20..31
      formatters/excoveralls/excoveralls.go on lines 20..31
      formatters/gocov/gocov.go on lines 32..43
      formatters/lcov/lcov.go on lines 22..33
      formatters/simplecov/simplecov.go on lines 18..29
      formatters/xccov/xccov.go on lines 20..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method region.UnmarshalJSON has 10 return statements (exceeds 4 allowed).
      Open

      func (region *region) UnmarshalJSON(data []byte) error {
    var array []interface{}
    if err := json.Unmarshal(data, &array); err != nil {
        return err
    }
      Severity: Major
      Found in formatters/lcovjson/json_input.go - About 1 hr to fix

        Method Formatter.Format has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
        Open

        func (r Formatter) Format() (formatters.Report, error) {
    rep, err := formatters.NewReport()
    if err != nil {
        return rep, err
    }
        Severity: Minor
        Found in formatters/lcov/lcov.go - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Uploader.doRequest has 7 return statements (exceeds 4 allowed).
        Open

        func (u Uploader) doRequest(in io.Reader, url string) (*http.Response, error) {
    c := http.Client{
        Transport: u.newTransport(),
        Timeout:   30 * time.Second,
    }
        Severity: Major
        Found in upload/uploader.go - About 45 mins to fix

          Method segment.UnmarshalJSON has 7 return statements (exceeds 4 allowed).
          Open

          func (segment *segment) UnmarshalJSON(data []byte) error {
    var array []interface{}
    if err := json.Unmarshal(data, &array); err != nil {
        return err
    }
          Severity: Major
          Found in formatters/lcovjson/json_input.go - About 45 mins to fix

            Method Uploader.Upload has 7 return statements (exceeds 4 allowed).
            Open

            func (u Uploader) Upload() error {
    if u.ReporterID == "" {
        return errors.New("you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag")
    }
            Severity: Major
            Found in upload/uploader.go - About 45 mins to fix
              Severity
              Category
              Status
              Source
              Language