Sign upLogin

codeclimate/test-reporter

View on GitHub
Star
formatters/excoveralls/excoveralls.go

Summary

Maintainability
A
1 hr
Test Coverage

Method Formatter.Format has 6 return statements (exceeds 4 allowed).
Open

func (r Formatter) Format() (formatters.Report, error) {
    report, err := formatters.NewReport()
    if err != nil {
        return report, err
    }
Severity: Major
Found in formatters/excoveralls/excoveralls.go - About 40 mins to fix

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    func (f *Formatter) Search(paths ...string) (string, error) {
    paths = append(paths, searchPaths...)
    for _, p := range paths {
        logrus.Debugf("checking search path %s for excoveralls formatter", p)
        if _, err := os.Stat(p); err == nil {
    Severity: Major
    Found in formatters/excoveralls/excoveralls.go and 8 other locations - About 1 hr to fix
    formatters/clover/clover.go on lines 20..31
    formatters/cobertura/cobertura.go on lines 21..32
    formatters/coveragepy/coveragepy.go on lines 20..31
    formatters/gocov/gocov.go on lines 32..43
    formatters/jacoco/jacoco.go on lines 27..38
    formatters/lcov/lcov.go on lines 22..33
    formatters/simplecov/simplecov.go on lines 18..29
    formatters/xccov/xccov.go on lines 20..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package excoveralls
    Severity: Minor
    Found in formatters/excoveralls/excoveralls.go by gofmt

    exported type Formatter should have comment or be unexported
    Open

    type Formatter struct {
    Severity: Minor
    Found in formatters/excoveralls/excoveralls.go by golint

    exported method Formatter.Search should have comment or be unexported
    Open

    func (f *Formatter) Search(paths ...string) (string, error) {
    Severity: Minor
    Found in formatters/excoveralls/excoveralls.go by golint

    exported method Formatter.Format should have comment or be unexported
    Open

    func (r Formatter) Format() (formatters.Report, error) {
    Severity: Minor
    Found in formatters/excoveralls/excoveralls.go by golint

    receiver name r should be consistent with previous receiver name f for Formatter
    Open

    func (r Formatter) Format() (formatters.Report, error) {
    Severity: Minor
    Found in formatters/excoveralls/excoveralls.go by golint

    There are no issues that match your filters.

    Category
    Status