codeforamerica/ohana-web-search

View on GitHub

Showing 2,141 of 2,141 total issues

Avoid vendor prefixes.
Open

    -webkit-box-shadow: 0 0 0 #ccc, 0 0 #fff inset;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Avoid using id selectors
Open

.inside #keyword-search-box {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 2 spaces, but was indented 4 spaces
Open

    text-shadow: none;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Avoid using id selectors
Open

#search-controls {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Expected item on line 488 to appear before line 485. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

        @include inline-block();
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Rule declaration should be followed by an empty line
Open

          }
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 2 spaces, but was indented 4 spaces
Open

    background: #b3d4fc;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Use // comments everywhere
Open

/*
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Rule declaration should be followed by an empty line
Open

        }
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Expected item on line 555 to appear before line 544. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

  @include box-sizing(border-box);
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

0.4 should be written without a leading zero as .4
Open

  top: 0.4em;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Unexpected var, use let or const instead.
Open

        var oldLeft = el.style.left, oldRsLeft = el.runtimeStyle.left;
Severity: Minor
Found in app/javascript/app/util/util.js by eslint

require let or const instead of var (no-var)

ECMAScript 6 allows programmers to create variables with block scope instead of function scope using the let and const keywords. Block scope is common in many other programming languages and helps programmers avoid mistakes such as:

var count = people.length;
var enoughFood = count > sandwiches.length;

if (enoughFood) {
    var count = sandwiches.length; // accidentally overriding the count variable
    console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}

// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");

Rule Details

This rule is aimed at discouraging the use of var and encouraging the use of const or let instead.

Examples

Examples of incorrect code for this rule:

/*eslint no-var: "error"*/

var x = "y";
var CONFIG = {};

Examples of correct code for this rule:

/*eslint no-var: "error"*/
/*eslint-env es6*/

let x = "y";
const CONFIG = {};

When Not To Use It

In addition to non-ES6 environments, existing JavaScript projects that are beginning to introduce ES6 into their codebase may not want to apply this rule if the cost of migrating from var to let is too costly. Source: http://eslint.org/docs/rules/

Name of variable font_size_110 should be written in all lowercase letters with hyphens instead of underscores
Open

    font-size: $font_size_110;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Avoid using id selectors
Open

#logo {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Name of variable greyscale_light should be written in all lowercase letters with hyphens instead of underscores
Open

      border-right: 1px dotted $greyscale_light;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 5
Open

  p {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Nesting should be no greater than 3, but was 4
Open

      > em {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Expected 0 spaces after ( instead of
Open

    @include background( radial-gradient( $primary-lightest 10%, $primary) );
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Name of variable greyscale_light should be written in all lowercase letters with hyphens instead of underscores
Open

      border-top: 1px solid $greyscale_light; // IE fallback
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered background, font-size, margin, margin-bottom, padding, text-align, text-transform, vertical-align
Open

        text-align: left;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint
Severity
Category
Status
Source
Language