codeforamerica/ohana-web-search

View on GitHub

Showing 2,141 of 2,141 total issues

Property color already defined on line 790
Open

          color: rgba($black,.4);
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 5
Open

        > ul {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Name of variable font_serif should be written in all lowercase letters with hyphens instead of underscores
Open

          font-family: $font_serif;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Expected item on line 874 to appear before line 873. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

    @include border-radius(0px 4px 4px 4px);
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Missing trailing comma.
Open

  }]
Severity: Minor
Found in config/webpack/loaders/erb.js by eslint

require or disallow trailing commas (comma-dangle)

Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

var foo = {
    bar: "baz",
    qux: "quux",
};

Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

Less clear:

var foo = {
-    bar: "baz",
-    qux: "quux"
+    bar: "baz"
 };

More clear:

var foo = {
     bar: "baz",
-    qux: "quux",
 };

Rule Details

This rule enforces consistent use of trailing commas in object and array literals.

Options

This rule has a string option or an object option:

{
    "comma-dangle": ["error", "never"],
    // or
    "comma-dangle": ["error", {
        "arrays": "never",
        "objects": "never",
        "imports": "never",
        "exports": "never",
        "functions": "ignore",
    }]
}
  • "never" (default) disallows trailing commas
  • "always" requires trailing commas
  • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
  • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

  • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
  • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
  • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
  • exports is for export declarations of ES Modules. (e.g. export {a,};)
  • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
    functions is set to "ignore" by default for consistency with the string option.

never

Examples of incorrect code for this rule with the default "never" option:

/*eslint comma-dangle: ["error", "never"]*/

var foo = {
    bar: "baz",
    qux: "quux",
};

var arr = [1,2,];

foo({
  bar: "baz",
  qux: "quux",
});

Examples of correct code for this rule with the default "never" option:

/*eslint comma-dangle: ["error", "never"]*/

var foo = {
    bar: "baz",
    qux: "quux"
};

var arr = [1,2];

foo({
  bar: "baz",
  qux: "quux"
});

always

Examples of incorrect code for this rule with the "always" option:

/*eslint comma-dangle: ["error", "always"]*/

var foo = {
    bar: "baz",
    qux: "quux"
};

var arr = [1,2];

foo({
  bar: "baz",
  qux: "quux"
});

Examples of correct code for this rule with the "always" option:

/*eslint comma-dangle: ["error", "always"]*/

var foo = {
    bar: "baz",
    qux: "quux",
};

var arr = [1,2,];

foo({
  bar: "baz",
  qux: "quux",
});

always-multiline

Examples of incorrect code for this rule with the "always-multiline" option:

/*eslint comma-dangle: ["error", "always-multiline"]*/

var foo = {
    bar: "baz",
    qux: "quux"
};

var foo = { bar: "baz", qux: "quux", };

var arr = [1,2,];

var arr = [1,
    2,];

var arr = [
    1,
    2
];

foo({
  bar: "baz",
  qux: "quux"
});

Examples of correct code for this rule with the "always-multiline" option:

/*eslint comma-dangle: ["error", "always-multiline"]*/

var foo = {
    bar: "baz",
    qux: "quux",
};

var foo = {bar: "baz", qux: "quux"};
var arr = [1,2];

var arr = [1,
    2];

var arr = [
    1,
    2,
];

foo({
  bar: "baz",
  qux: "quux",
});

only-multiline

Examples of incorrect code for this rule with the "only-multiline" option:

/*eslint comma-dangle: ["error", "only-multiline"]*/

var foo = { bar: "baz", qux: "quux", };

var arr = [1,2,];

var arr = [1,
    2,];

Examples of correct code for this rule with the "only-multiline" option:

/*eslint comma-dangle: ["error", "only-multiline"]*/

var foo = {
    bar: "baz",
    qux: "quux",
};

var foo = {
    bar: "baz",
    qux: "quux"
};

var foo = {bar: "baz", qux: "quux"};
var arr = [1,2];

var arr = [1,
    2];

var arr = [
    1,
    2,
];

var arr = [
    1,
    2
];

foo({
  bar: "baz",
  qux: "quux",
});

foo({
  bar: "baz",
  qux: "quux"
});

functions

Examples of incorrect code for this rule with the {"functions": "never"} option:

/*eslint comma-dangle: ["error", {"functions": "never"}]*/

function foo(a, b,) {
}

foo(a, b,);
new foo(a, b,);

Examples of correct code for this rule with the {"functions": "never"} option:

/*eslint comma-dangle: ["error", {"functions": "never"}]*/

function foo(a, b) {
}

foo(a, b);
new foo(a, b);

Examples of incorrect code for this rule with the {"functions": "always"} option:

/*eslint comma-dangle: ["error", {"functions": "always"}]*/

function foo(a, b) {
}

foo(a, b);
new foo(a, b);

Examples of correct code for this rule with the {"functions": "always"} option:

/*eslint comma-dangle: ["error", {"functions": "always"}]*/

function foo(a, b,) {
}

foo(a, b,);
new foo(a, b,);

When Not To Use It

You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

Avoid using id selectors
Open

#map-size-control:hover {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered border-left, font-size, margin, margin-left, padding-left
Open

            margin: 5px;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 2 spaces, but was indented 4 spaces
Open

    background: #b3d4fc;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Expected item on line 1029 to appear before line 1028. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

      @include type-size(baseline);
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 4
Open

      > ul {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 2 spaces, but was indented 4 spaces
Open

    padding: 0;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Use // comments everywhere
Open

/*
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered background, border-left, margin-left, position, vertical-align, z-index
Open

  position: relative;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 4
Open

    li {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

0.4 should be written without a leading zero as .4
Open

  top: -0.4em;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered background, border-bottom, font-family, min-height, position, right, text-align, top, width, z-index
Open

  position: absolute;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Avoid using id selectors
Open

#app-footer {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered color, font-weight
Open

      font-weight: bold;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Name of variable greyscale_midtone should be written in all lowercase letters with hyphens instead of underscores
Open

    color: $greyscale_midtone;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Commas in function arguments should be followed by one space
Open

      @include box-shadow(0 0 1px $white, -1px 0 2px rgba($black,.2), 0 1px 2px rgba($black,.2), 0 -1px 2px rgba($black,.2));
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint
Severity
Category
Status
Source
Language