codeforamerica/ohana-web-search

View on GitHub

Showing 2,141 of 2,141 total issues

Avoid using id selectors
Open

#results-container.result-map-showing .results-header {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Name of variable greyscale_dark should be written in all lowercase letters with hyphens instead of underscores
Open

      color: $greyscale_dark;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Missing semicolon.
Open

const erb =  require('./loaders/erb')
Severity: Minor
Found in config/webpack/environment.js by eslint

require or disallow semicolons instead of ASI (semi)

JavaScript is unique amongst the C-like languages in that it doesn't require semicolons at the end of each statement. In many cases, the JavaScript engine can determine that a semicolon should be in a certain spot and will automatically add it. This feature is known as automatic semicolon insertion (ASI) and is considered one of the more controversial features of JavaScript. For example, the following lines are both valid:

var name = "ESLint"
var website = "eslint.org";

On the first line, the JavaScript engine will automatically insert a semicolon, so this is not considered a syntax error. The JavaScript engine still knows how to interpret the line and knows that the line end indicates the end of the statement.

In the debate over ASI, there are generally two schools of thought. The first is that we should treat ASI as if it didn't exist and always include semicolons manually. The rationale is that it's easier to always include semicolons than to try to remember when they are or are not required, and thus decreases the possibility of introducing an error.

However, the ASI mechanism can sometimes be tricky to people who are using semicolons. For example, consider this code:

return
{
    name: "ESLint"
};

This may look like a return statement that returns an object literal, however, the JavaScript engine will interpret this code as:

return;
{
    name: "ESLint";
}

Effectively, a semicolon is inserted after the return statement, causing the code below it (a labeled literal inside a block) to be unreachable. This rule and the [no-unreachable](no-unreachable.md) rule will protect your code from such cases.

On the other side of the argument are those who says that since semicolons are inserted automatically, they are optional and do not need to be inserted manually. However, the ASI mechanism can also be tricky to people who don't use semicolons. For example, consider this code:

var globalCounter = { }

(function () {
    var n = 0
    globalCounter.increment = function () {
        return ++n
    }
})()

In this example, a semicolon will not be inserted after the first line, causing a run-time error (because an empty object is called as if it's a function). The [no-unexpected-multiline](no-unexpected-multiline.md) rule can protect your code from such cases.

Although ASI allows for more freedom over your coding style, it can also make your code behave in an unexpected way, whether you use semicolons or not. Therefore, it is best to know when ASI takes place and when it does not, and have ESLint protect your code from these potentially unexpected cases. In short, as once described by Isaac Schlueter, a \n character always ends a statement (just like a semicolon) unless one of the following is true:

  1. The statement has an unclosed paren, array literal, or object literal or ends in some other way that is not a valid way to end a statement. (For instance, ending with . or ,.)
  2. The line is -- or ++ (in which case it will decrement/increment the next token.)
  3. It is a for(), while(), do, if(), or else, and there is no {
  4. The next line starts with [, (, +, *, /, -, ,, ., or some other binary operator that can only be found between two tokens in a single expression.

Rule Details

This rule enforces consistent use of semicolons.

Options

This rule has two options, a string option and an object option.

String option:

  • "always" (default) requires semicolons at the end of statements
  • "never" disallows semicolons as the end of statements (except to disambiguate statements beginning with [, (, /, +, or -)

Object option:

  • "omitLastInOneLineBlock": true ignores the last semicolon in a block in which its braces (and therefore the content of the block) are in the same line

always

Examples of incorrect code for this rule with the default "always" option:

/*eslint semi: ["error", "always"]*/

var name = "ESLint"

object.method = function() {
    // ...
}

Examples of correct code for this rule with the default "always" option:

/*eslint semi: "error"*/

var name = "ESLint";

object.method = function() {
    // ...
};

never

Examples of incorrect code for this rule with the "never" option:

/*eslint semi: ["error", "never"]*/

var name = "ESLint";

object.method = function() {
    // ...
};

Examples of correct code for this rule with the "never" option:

/*eslint semi: ["error", "never"]*/

var name = "ESLint"

object.method = function() {
    // ...
}

var name = "ESLint"

;(function() {
    // ...
})()

omitLastInOneLineBlock

Examples of additional correct code for this rule with the "always", { "omitLastInOneLineBlock": true } options:

/*eslint semi: ["error", "always", { "omitLastInOneLineBlock": true}] */

if (foo) { bar() }

if (foo) { bar(); baz() }

When Not To Use It

If you do not want to enforce semicolon usage (or omission) in any particular way, then you can turn this rule off.

Further Reading

Related Rules

  • [no-extra-semi](no-extra-semi.md)
  • [no-unexpected-multiline](no-unexpected-multiline.md)
  • [semi-spacing](semi-spacing.md) Source: http://eslint.org/docs/rules/

Selector should have depth of applicability no greater than 3, but was 4
Open

    .contact-box .phones {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Avoid using id selectors
Open

#floating-results-header.floating .static-content {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 2 spaces, but was indented 4 spaces
Open

    color: #222;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 2 spaces, but was indented 4 spaces
Open

    vertical-align: middle;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 4
Open

      > em {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered font-family, height
Open

  height: 100%;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Nesting should be no greater than 3, but was 4
Open

      ul {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 6 spaces, but was indented 8 spaces
Open

        color: $black;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Name of variable greyscale_midtone should be written in all lowercase letters with hyphens instead of underscores
Open

          color: $greyscale_midtone; // IE fallback
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Line should be indented 6 spaces, but was indented 8 spaces
Open

        margin-left: 14px;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Merge rule h1.name > a:hover::after with rule on line 779
Open

        h1.name > a:hover::after {
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered color, font-family, font-size, margin-left, position, top
Open

    font-size: $font_size_90;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Selector should have depth of applicability no greater than 3, but was 5
Open

  input,
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered margin-right, max-height, text-align
Open

    text-align: right;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered font-size, left, position, top
Open

      position: relative;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

!important should not be used
Open

  height: 400px !important;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint

Properties should be ordered cursor, font-family
Open

  font-family: $font_san_serif;
Severity: Minor
Found in app/assets/stylesheets/_base.scss by scss-lint
Severity
Category
Status
Source
Language