Sign upLogin

codenothing/CSSCompressor

View on GitHub
Star

Showing 254 of 254 total issues

Function objectsMatch has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    objectsMatch: function( a, b ) {
        var isArray = CSSCompressor.isArray,
            isObject = CSSCompressor.isObject,
            i;
Severity: Minor
Found in lib/Util.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function render( css, branches, indent ) {
    if ( indent === undefined ) {
        indent = '';
    }
Severity: Major
Found in lib/formats/Medium.js - About 3 hrs to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                    if ( rule !== first && rule.position && first.position ) {
                    compressor.log(
                        "Combining '" + rule.property + "' on line " + rule.position.start.line +
                        " with '" + first.property + "' on line " + first.position.start.line,
                        [ rule.position, first.position ]
    Severity: Major
    Found in lib/rules/List Style Combinations.js and 4 other locations - About 3 hrs to fix
    lib/rules/Border Radius Combinations.js on lines 172..178
    lib/rules/Border, Outline Style Combinations.js on lines 80..86
    lib/rules/Font Combinations.js on lines 82..88
    lib/rules/Margin, Padding Combinations.js on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                        if ( rule !== first && rule.position && first.position ) {
                        compressor.log(
                            "Combining '" + rule.property + "' on line " + rule.position.start.line +
                            " with '" + first.property + "' on line " + first.position.start.line,
                            [ rule.position, first.position ]
    Severity: Major
    Found in lib/rules/Border, Outline Style Combinations.js and 4 other locations - About 3 hrs to fix
    lib/rules/Border Radius Combinations.js on lines 172..178
    lib/rules/Font Combinations.js on lines 82..88
    lib/rules/List Style Combinations.js on lines 79..85
    lib/rules/Margin, Padding Combinations.js on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                        if ( rule !== first && rule.position && first.position ) {
                        compressor.log(
                            "Combining '" + rule.property + "' on line " + rule.position.start.line +
                            " with '" + first.property + "' on line " + first.position.start.line,
                            [ rule.position, first.position ]
    Severity: Major
    Found in lib/rules/Font Combinations.js and 4 other locations - About 3 hrs to fix
    lib/rules/Border Radius Combinations.js on lines 172..178
    lib/rules/Border, Outline Style Combinations.js on lines 80..86
    lib/rules/List Style Combinations.js on lines 79..85
    lib/rules/Margin, Padding Combinations.js on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                        if ( rule !== first && rule.position && first.position ) {
                        compressor.log(
                            "Combining '" + rule.property + "' on line " + rule.position.start.line +
                            " with '" + first.property + "' on line " + first.position.start.line,
                            [ rule.position, first.position ]
    Severity: Major
    Found in lib/rules/Margin, Padding Combinations.js and 4 other locations - About 3 hrs to fix
    lib/rules/Border Radius Combinations.js on lines 172..178
    lib/rules/Border, Outline Style Combinations.js on lines 80..86
    lib/rules/Font Combinations.js on lines 82..88
    lib/rules/List Style Combinations.js on lines 79..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                        if ( rule !== first && rule.position && first.position ) {
                        compressor.log(
                            "Combining '" + rule.property + "' on line " + rule.position.start.line +
                            " with '" + graph.shorthand + "' on line " + first.position.start.line,
                            [ rule.position, first.position ]
    Severity: Major
    Found in lib/rules/Border Radius Combinations.js and 4 other locations - About 3 hrs to fix
    lib/rules/Border, Outline Style Combinations.js on lines 80..86
    lib/rules/Font Combinations.js on lines 82..88
    lib/rules/List Style Combinations.js on lines 79..85
    lib/rules/Margin, Padding Combinations.js on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function render has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function render( css, branches, indent ) {
    if ( indent === undefined ) {
        indent = '';
    }
    Severity: Major
    Found in lib/formats/Minimum.js - About 3 hrs to fix

      Function render has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function render( css, branches, indent ) {
    if ( indent === undefined ) {
        indent = '';
    }
      Severity: Major
      Found in lib/formats/Max.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( m && m.length > 4 &&  parseFloat( m[ 4 ] ) >= 1  ) {
            value = "rgb(" + m[ 1 ] + "," + m[ 2 ] + "," + m[ 3 ] + ")";

            compressor.log(
                "Converting RGBA to RGB '" + before + "' => '" + value + "'",
        Severity: Major
        Found in lib/rules/RGBA to RGB.js and 1 other location - About 3 hrs to fix
        lib/rules/HSLA to HSL.js on lines 36..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ( m && m.length > 4 && parseFloat( m[ 4 ] ) >= 1  ) {
            value = "hsl(" + m[ 1 ] + "," + m[ 2 ] + "%," + m[ 3 ] + "%)";

            compressor.log(
                "Converting HSLA to HSL '" + before + "' => '" + value + "'",
        Severity: Major
        Found in lib/rules/HSLA to HSL.js and 1 other location - About 3 hrs to fix
        lib/rules/RGBA to RGB.js on lines 37..45

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function remove has 92 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            remove: function( elem, types, handler, pos ) {
        // don't do events on text and comment nodes
        if ( elem.nodeType === 3 || elem.nodeType === 8 ) {
            return;
        }
        Severity: Major
        Found in demo/rules/js/jquery.js - About 3 hrs to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              else if ( rule.property == graph.topright ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 1 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 1 ] = rule.parts[ 1 ];
          Severity: Major
          Found in lib/rules/Border Radius Combinations.js and 2 other locations - About 3 hrs to fix
          lib/rules/Border Radius Combinations.js on lines 127..169
          lib/rules/Border Radius Combinations.js on lines 149..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              else if ( rule.property == graph.topleft ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 0 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 0 ] = rule.parts[ 1 ];
          Severity: Major
          Found in lib/rules/Border Radius Combinations.js and 2 other locations - About 3 hrs to fix
          lib/rules/Border Radius Combinations.js on lines 138..169
          lib/rules/Border Radius Combinations.js on lines 149..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              else if ( rule.property == ptop ) {
                        parts[ 0 ] = rule.parts[ 0 ];
                    }
                    else if ( rule.property == pright ) {
                        parts[ 1 ] = rule.parts[ 0 ];
          Severity: Major
          Found in lib/rules/Margin, Padding Combinations.js and 1 other location - About 3 hrs to fix
          lib/rules/Border, Outline Style Combinations.js on lines 66..77

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if ( rule.property == prop ) {
                        parts = rule.parts;
                    }
                    else if ( rule.property == pwidth ) {
                        parts[ 0 ] = rule.parts[ 0 ];
          Severity: Major
          Found in lib/rules/Border, Outline Style Combinations.js and 1 other location - About 3 hrs to fix
          lib/rules/Margin, Padding Combinations.js on lines 86..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              else if ( rule.property == graph.bottomright ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 2 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 2 ] = rule.parts[ 1 ];
          Severity: Major
          Found in lib/rules/Border Radius Combinations.js and 2 other locations - About 3 hrs to fix
          lib/rules/Border Radius Combinations.js on lines 127..169
          lib/rules/Border Radius Combinations.js on lines 138..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function add has 83 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              add: function( elem, types, handler, data ) {
        if ( elem.nodeType === 3 || elem.nodeType === 8 ) {
            return;
        }
          Severity: Major
          Found in demo/rules/js/jquery.js - About 3 hrs to fix

            Function exports has 80 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function( content ) {
    var html = '', m, i,
        seek = null,
        comexit = false,
        props = {
            Severity: Major
            Found in build/comment.js - About 3 hrs to fix

              Function callback has 78 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  callback: function( branch, compressor ) {
        if ( ! branch.rules || ! branch.rules.length ) {
            return;
        }
              Severity: Major
              Found in lib/rules/Margin, Padding Combinations.js - About 3 hrs to fix
                Severity
                Category
                Status
                Source
                Language