Sign upLogin

coding-blocks/CBOnlineApp

View on GitHub
Star

Showing 862 of 862 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private val itemClickListener: WishListItemClickListener by lazy {
        object : WishListItemClickListener {
            override fun onClick(id: String, name: String, logo: CircleImageView) {
                val intent = Intent(this@WishlistActivity, CourseActivity::class.java)
                intent.putExtra(COURSE_ID, id)
Severity: Major
Found in app/src/main/java/com/codingblocks/cbonlineapp/dashboard/home/WishlistActivity.kt and 4 other locations - About 4 hrs to fix
app/src/main/java/com/codingblocks/cbonlineapp/course/CourseActivity.kt on lines 96..113
app/src/main/java/com/codingblocks/cbonlineapp/course/SearchCourseActivity.kt on lines 29..46
app/src/main/java/com/codingblocks/cbonlineapp/tracks/LearningTracksActivity.kt on lines 38..55
app/src/main/java/com/codingblocks/cbonlineapp/tracks/TrackActivity.kt on lines 50..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 308.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private val itemClickListener: ItemClickListener by lazy {
        object : ItemClickListener {
            override fun onClick(id: String, name: String, logo: ImageView) {
                val intent = Intent(this@CourseActivity, CourseActivity::class.java)
                intent.putExtra(COURSE_ID, id)
Severity: Major
Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseActivity.kt and 4 other locations - About 4 hrs to fix
app/src/main/java/com/codingblocks/cbonlineapp/course/SearchCourseActivity.kt on lines 29..46
app/src/main/java/com/codingblocks/cbonlineapp/dashboard/home/WishlistActivity.kt on lines 25..42
app/src/main/java/com/codingblocks/cbonlineapp/tracks/LearningTracksActivity.kt on lines 38..55
app/src/main/java/com/codingblocks/cbonlineapp/tracks/TrackActivity.kt on lines 50..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 308.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private val itemClickListener: ItemClickListener by lazy {
        object : ItemClickListener {
            override fun onClick(id: String, name: String, logo: ImageView) {
                val intent = Intent(this@SearchCourseActivity, CourseActivity::class.java)
                intent.putExtra(COURSE_ID, id)
Severity: Major
Found in app/src/main/java/com/codingblocks/cbonlineapp/course/SearchCourseActivity.kt and 4 other locations - About 4 hrs to fix
app/src/main/java/com/codingblocks/cbonlineapp/course/CourseActivity.kt on lines 96..113
app/src/main/java/com/codingblocks/cbonlineapp/dashboard/home/WishlistActivity.kt on lines 25..42
app/src/main/java/com/codingblocks/cbonlineapp/tracks/LearningTracksActivity.kt on lines 38..55
app/src/main/java/com/codingblocks/cbonlineapp/tracks/TrackActivity.kt on lines 50..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 308.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method fetchCodeChallenge has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

    fun fetchCodeChallenge() = liveData(Dispatchers.IO) {
        val codeModel = contentId?.let { repo.getCodeId(it) }
        attempId = codeModel?.attempt_id
        codeId = codeModel?.codeUid
        contestId = codeModel?.codeContestId.toString()
Severity: Minor
Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/codechallenge/CodeChallengeViewModel.kt - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method showConfirmation has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    fun showConfirmation(context: Context, type: String, callback: (state: Boolean) -> Unit = { }) {
        val confirmDialog = AlertDialog.Builder(context).create()
        val updateView = context.layoutInflater.inflate(R.layout.custom_dialog, null)
        when (type) {
            VERIFY -> {
Severity: Major
Found in app/src/main/java/com/codingblocks/cbonlineapp/util/CustomDialog.kt - About 4 hrs to fix

    File VideoPlayerViewModel.kt has 353 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.codingblocks.cbonlineapp.mycourse.content.player

import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.SavedStateHandle
import androidx.lifecycle.Transformations
    Severity: Minor
    Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/player/VideoPlayerViewModel.kt - About 4 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private val itemClickListener: ItemClickListener by lazy {
        object : ItemClickListener {
            override fun onClick(id: String, name: String, logo: ImageView) {
                val intent = Intent(requireContext(), CourseActivity::class.java)
                intent.putExtra(COURSE_ID, id)
      Severity: Major
      Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseSearchFragment.kt and 2 other locations - About 4 hrs to fix
      app/src/main/java/com/codingblocks/cbonlineapp/dashboard/explore/DashboardExploreFragment.kt on lines 57..73
      app/src/main/java/com/codingblocks/cbonlineapp/dashboard/explore/DashboardExploreFragment.kt on lines 91..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 298.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private val itemClickListener: ItemClickListener by lazy {
        object : ItemClickListener {
            override fun onClick(id: String, name: String, logo: ImageView) {
                val intent = Intent(requireContext(), CourseActivity::class.java)
                intent.putExtra(COURSE_ID, id)
      Severity: Major
      Found in app/src/main/java/com/codingblocks/cbonlineapp/dashboard/explore/DashboardExploreFragment.kt and 2 other locations - About 4 hrs to fix
      app/src/main/java/com/codingblocks/cbonlineapp/course/CourseSearchFragment.kt on lines 58..74
      app/src/main/java/com/codingblocks/cbonlineapp/dashboard/explore/DashboardExploreFragment.kt on lines 91..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 298.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private val trackItemClickList: ItemClickListener by lazy {
        object : ItemClickListener {
            override fun onClick(id: String, name: String, logo: ImageView) {
                val intent = Intent(requireContext(), TrackActivity::class.java)
                intent.putExtra(COURSE_ID, id)
      Severity: Major
      Found in app/src/main/java/com/codingblocks/cbonlineapp/dashboard/explore/DashboardExploreFragment.kt and 2 other locations - About 4 hrs to fix
      app/src/main/java/com/codingblocks/cbonlineapp/course/CourseSearchFragment.kt on lines 58..74
      app/src/main/java/com/codingblocks/cbonlineapp/dashboard/explore/DashboardExploreFragment.kt on lines 57..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 298.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method makeForm has 111 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private fun makeForm(formData: MutableLiveData<ArrayList<Form>>) {

        val params = LinearLayout.LayoutParams(
            LinearLayout.LayoutParams.MATCH_PARENT,
            LinearLayout.LayoutParams.WRAP_CONTENT
      Severity: Major
      Found in app/src/main/java/com/codingblocks/cbonlineapp/jobs/jobdetails/JobDetailActivity.kt - About 4 hrs to fix

        Method fetchProjects has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
        Open

            fun fetchProjects(projectIdList: ArrayList<Project>?) {
        val list = arrayListOf<Project>()
        if (!projectIdList.isNullOrEmpty()) {
            runIO {
                val projectList = projectIdList.map {
        Severity: Minor
        Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseViewModel.kt - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method fetchSections has a Cognitive Complexity of 44 (exceeds 20 allowed). Consider refactoring.
        Open

            // Todo - Improvise this
    fun fetchSections(sectionIdList: ArrayList<Sections>) {
        val list = arrayListOf<Sections>()
        if (!sectionIdList.isNullOrEmpty()) {
            runIO {
        Severity: Minor
        Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseViewModel.kt - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File CourseContentFragment.kt has 343 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        package com.codingblocks.cbonlineapp.mycourse.content

import android.app.ActivityManager
import android.content.Context
import android.os.Bundle
        Severity: Minor
        Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/CourseContentFragment.kt - About 4 hrs to fix

          Method onViewCreated has 105 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        setUpBottomSheet()
        typeTv.text = vm.type
        when (vm.type) {
          Severity: Major
          Found in app/src/main/java/com/codingblocks/cbonlineapp/library/LibraryViewFragment.kt - About 4 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                fun changeWishlistStatus(id: String) {
        runIO {
            when (val response = homeRepo.checkWishlisted(id)) {
                is ResultWrapper.GenericError -> setError(response.error)
                is ResultWrapper.Success -> with(response.value) {
            Severity: Major
            Found in app/src/main/java/com/codingblocks/cbonlineapp/dashboard/DashboardViewModel.kt and 1 other location - About 4 hrs to fix
            app/src/main/java/com/codingblocks/cbonlineapp/course/CourseViewModel.kt on lines 229..246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 280.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                fun changeWishlistStatus(id: String) {
        runIO {
            when (val response = repo.checkIfWishlisted(id)) {
                is ResultWrapper.GenericError -> setError(response.error)
                is ResultWrapper.Success -> with(response.value) {
            Severity: Major
            Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseViewModel.kt and 1 other location - About 4 hrs to fix
            app/src/main/java/com/codingblocks/cbonlineapp/dashboard/DashboardViewModel.kt on lines 366..383

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 280.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File CourseActivity.kt has 332 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            package com.codingblocks.cbonlineapp.course

import android.app.Activity
import android.content.Intent
import android.graphics.Typeface
            Severity: Minor
            Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseActivity.kt - About 4 hrs to fix

              File OnlineJsonApi.kt has 332 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              package com.codingblocks.onlineapi.api

import com.codingblocks.onlineapi.models.Applications
import com.codingblocks.onlineapi.models.Bookmark
import com.codingblocks.onlineapi.models.CareerTracks
              Severity: Minor
              Found in onlineapi/src/main/kotlin/com/codingblocks/onlineapi/api/OnlineJsonApi.kt - About 4 hrs to fix

                Method bind has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
                Open

                        fun bind(item: Sections) = with(itemView) {
            title.text = item.name
            lectures.text = " ${item.contents?.size ?: 0} Items |"
            var duration: Long = 0
            for (subItems in item.contents!!) {
                Severity: Minor
                Found in app/src/main/java/com/codingblocks/cbonlineapp/course/CourseSectionListAdapter.kt - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    fun removeBookmark() {
        runIO {
            val uid = bookmark.value?.bookmarkUid
            when (val response = uid?.let { repo.removeBookmark(it) }) {
                is ResultWrapper.GenericError -> setError(response.error)
                Severity: Major
                Found in app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/quiz/QuizViewModel.kt and 1 other location - About 3 hrs to fix
                app/src/main/java/com/codingblocks/cbonlineapp/mycourse/content/document/PdfViewModel.kt on lines 60..76

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 265.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language