Sign upLogin

colinschoen/enrollme

View on GitHub
Star
app/controllers/file_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for download_approved_teams is too high. [29.43/15]
Open

  def download_approved_teams
    time_zone = "Pacific Time (US & Canada)"
    time_format = "%Y%m%d%H%M"
    time = Time.now.in_time_zone(time_zone).strftime(time_format)
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [19/10]
Open

  def download_approved_teams
    time_zone = "Pacific Time (US & Canada)"
    time_format = "%Y%m%d%H%M"
    time = Time.now.in_time_zone(time_zone).strftime(time_format)
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Use 0o for octal literals.
Open

        disc_id = 00000
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

This cop checks for octal, hex, binary and decimal literals using uppercase prefixes and corrects them to lowercase prefix or no prefix (in case of decimals). eg. for octal use 0o instead of 0 or 0O.

Can be configured to use 0 only for octal literals using EnforcedOctalStyle => zero_only

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    time_format = "%Y%m%d%H%M"
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    rows << ["Team ID", "Discussion Number", "Student ID", "Student Name"]
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    csv_str = rows.inject([]) { |csv, row|  csv << CSV.generate_line(row) }.join("")
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Unnecessary spacing detected.
Open

    csv_str = rows.inject([]) { |csv, row|  csv << CSV.generate_line(row) }.join("")
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Missing top-level class documentation comment.
Open

class FileController < ApplicationController
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    rows << ["Team ID", "Discussion Number", "Student ID", "Student Name"]
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Put empty method definitions on a single line.
Open

  def index
  end
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Line is too long. [84/80]
Open

    csv_str = rows.inject([]) { |csv, row|  csv << CSV.generate_line(row) }.join("")
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    rows << ["Team ID", "Discussion Number", "Student ID", "Student Name"]
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    rows << ["Team ID", "Discussion Number", "Student ID", "Student Name"]
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    time_zone = "Pacific Time (US & Canada)"
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use the return of the conditional for variable assignment and comparison.
Open

      if discussion.nil?
        disc_id = 00000
      else
        disc_id = discussion.number
      end
Severity: Minor
Found in app/controllers/file_controller.rb by rubocop

There are no issues that match your filters.

Category
Status