colinschoen/enrollme

Class has too many lines. [202/100]

Open

class AdminsController < ApplicationController
  skip_before_filter :authenticate, :only => ['new', 'create']
  before_filter :validate_admin, :set_admin, :except => ['new', 'create']

  def new

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for create is too high. [41.3/15]

Open

    def create
        @user = User.find_by_id(session[:user_id])
        @team = Team.find_by_id(@user.team.id)
        
        d1 = submission_params[:disc1id]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for create is too high. [33.23/15]

Open

  def create
    oauth_hash = Rails.env.test? ? OmniAuth.config.mock_auth[:google] : env["omniauth.auth"]
    user = User.user_from_oauth(oauth_hash)
    admin = Admin.admin_from_oauth(oauth_hash)
    session[:user_email] = oauth_hash[:info][:email]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for download_approved_teams is too high. [29.43/15]

Open

  def download_approved_teams
    time_zone = "Pacific Time (US & Canada)"
    time_format = "%Y%m%d%H%M"
    time = Time.now.in_time_zone(time_zone).strftime(time_format)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Class AdminsController has 27 methods (exceeds 20 allowed). Consider refactoring.

Open

class AdminsController < ApplicationController
  skip_before_filter :authenticate, :only => ['new', 'create']
  before_filter :validate_admin, :set_admin, :except => ['new', 'create']

  def new

Method has too many lines. [19/10]

Open

  def create
    oauth_hash = Rails.env.test? ? OmniAuth.config.mock_auth[:google] : env["omniauth.auth"]
    user = User.user_from_oauth(oauth_hash)
    admin = Admin.admin_from_oauth(oauth_hash)
    session[:user_email] = oauth_hash[:info][:email]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method has too many lines. [19/10]

Open

  def download_approved_teams
    time_zone = "Pacific Time (US & Canada)"
    time_format = "%Y%m%d%H%M"
    time = Time.now.in_time_zone(time_zone).strftime(time_format)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method has too many lines. [18/10]

Open

    def create
        @user = User.find_by_id(session[:user_id])
        @team = Team.find_by_id(@user.team.id)
        
        d1 = submission_params[:disc1id]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method has too many lines. [17/10]

Open

  def delete
    if @admin.superadmin == true
      c = 0
      for a in Admin.all
        if params.has_key? "delete_#{a.name}"

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for join_team is too high. [21.95/15]

Open

  def join_team
    @passcode = params[:team_hash]
    @team = Team.find_by_passcode(@passcode)
    @team ||= Team.new()
    return redirect_to without_team_path, :notice => "Unable to join team" if @passcode.empty? or !(@team.can_join?)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method has too many lines. [16/10]

Open

  def add_skill
    skill_name = params[:skill].titleize
    existing_skill = Skill.where(:name => skill_name).first
    if existing_skill
      if existing_skill.active

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for skills_str is too high. [19.08/15]

Open

  def skills_str
    if talents.nil? || talents.length.zero?
      return ''
    end
    skills = []

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for edit_disc is too high. [19.65/15]

Open

   def edit_disc
      @disc = Discussion.find(params[:discussion][:id])
      @disc.number = params[:discussion][:number]
      @disc.day = params[:discussion][:day]
      @disc.time = params[:discussion][:time]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method has too many lines. [13/10]

Open

  def transfer
    if @admin.superadmin == true and params[:transfer_admin] != nil
      other_admin = Admin.find(params[:transfer_admin])
      @admin.superadmin = false
      other_admin.superadmin = true

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for transfer is too high. [18.47/15]

Open

  def transfer
    if @admin.superadmin == true and params[:transfer_admin] != nil
      other_admin = Admin.find(params[:transfer_admin])
      @admin.superadmin = false
      other_admin.superadmin = true

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for approve is too high. [18.14/15]

Open

  def approve
    @team = Team.find_by_id(params[:team_id])
    @team.approved = true
    @team.save!

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method has too many lines. [13/10]

Open

  def do_email
    @to.each_with_index do |to_email, counter|
      email_team_paramters = { to: to_email,
                               from_name: @user.name,
                               to_name: @names[counter],

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Consider simplifying this complex logical expression.

Open

  if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or 
      (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
    puts "Sending Emails to Admins..."
    AdminMailer.send_look_at_submission
    puts "done." 

Assignment Branch Condition size for edit is too high. [17.72/15]

Open

  def edit
    @user_to_remove = User.find_by_id(params[:unwanted_user])
    @user_to_remove.leave_team
    notice = ""

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [43/25]

Open

Rails.application.routes.draw do

  resources :users
  get '/without_team', to: 'users#without'
  post '/create_team', to: 'users#start_team'

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check