Sign upLogin

colinschoen/enrollme

View on GitHub
Star

Showing 572 of 572 total issues

Assignment Branch Condition size for new is too high. [16.4/15]
Open

  def new
    id = session[:user_id]
    user = User.find_by_id(id)
    if id.nil?
      render 'new'
Severity: Minor
Found in app/controllers/session_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [11/10]
Open

  def edit
    @user_to_remove = User.find_by_id(params[:unwanted_user])
    @user_to_remove.leave_team
    notice = ""
Severity: Minor
Found in app/controllers/team_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for skills_str is too high. [7/6]
Open

  def skills_str
    if talents.nil? || talents.length.zero?
      return ''
    end
    skills = []
Severity: Minor
Found in app/models/user.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [11/10]
Open

  def skills_str
    if talents.nil? || talents.length.zero?
      return ''
    end
    skills = []
Severity: Minor
Found in app/models/user.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for team_skills is too high. [15.43/15]
Open

    def team_skills
      result = []
      self.users.each do |user|
        user.talents.each do |talent|
          skill = Skill.find(talent.skill_id)
Severity: Minor
Found in app/models/team.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def delete
    if @admin.superadmin == true
      c = 0
      for a in Admin.all
        if params.has_key? "delete_#{a.name}"
Severity: Minor
Found in app/controllers/admins_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method skills_str has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def skills_str
    if talents.nil? || talents.length.zero?
      return ''
    end
    skills = []
Severity: Minor
Found in app/models/user.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

  if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
      (time.month == 11 and time.day > 15) or time.month == 12)
    puts "Sending Emails to Admins..."
    AdminMailer.send_look_at_submission
    puts "done."
Severity: Major
Found in script/clock.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    oauth_hash = Rails.env.test? ? OmniAuth.config.mock_auth[:google] : env["omniauth.auth"]
    user = User.user_from_oauth(oauth_hash)
    admin = Admin.admin_from_oauth(oauth_hash)
    session[:user_email] = oauth_hash[:info][:email]
    Severity: Minor
    Found in app/controllers/session_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def create
        @user = User.find_by_id(session[:user_id])
        @team = Team.find_by_id(@user.team.id)
        
        d1 = submission_params[:disc1id]
    Severity: Minor
    Found in app/controllers/submissions_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

      if ((time.month == 8 and time.day > 15) or time.month == 9 or
      time.month == 1 or (time.month == 2 and time.day <= 20))
    puts "Sending Emails to Admins..."
    AdminMailer.send_look_at_submission
    puts "done."
    Severity: Major
    Found in script/clock.rb - About 40 mins to fix

      Avoid too many return statements within this method.
      Open

              return Team.all.each
      Severity: Major
      Found in app/models/team.rb - About 30 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          def send_disapproved_email(team)
    @team = team

    @team.users.each do |disapproved_user|
      @user = disapproved_user
        Severity: Minor
        Found in app/mailers/admin_mailer.rb and 2 other locations - About 20 mins to fix
        app/mailers/admin_mailer.rb on lines 22..29
        app/mailers/email_students.rb on lines 14..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            def successfully_submitted_email(team)
      @team = team
      
      @team.users.each do |student|
         @user = student
        Severity: Minor
        Found in app/mailers/email_students.rb and 2 other locations - About 20 mins to fix
        app/mailers/admin_mailer.rb on lines 22..29
        app/mailers/admin_mailer.rb on lines 34..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          def send_approved_email(team)
    @team = team

    @team.users.each do |approved_user|
      @user = approved_user
        Severity: Minor
        Found in app/mailers/admin_mailer.rb and 2 other locations - About 20 mins to fix
        app/mailers/admin_mailer.rb on lines 34..41
        app/mailers/email_students.rb on lines 14..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Use && instead of and.
        Open

              (time.month == 11 and time.day > 15) or time.month == 12)
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Unnecessary spacing detected.
        Open

          class IsSingletonError < RuntimeError;  end
        Severity: Minor
        Found in app/models/option.rb by rubocop

        This cop checks for extra/unnecessary whitespace.

        Example:

        # good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

        Trailing whitespace detected.
        Open
        Severity: Minor
        Found in app/models/admin.rb by rubocop

        Do not leave space between ! and its argument.
        Open

                ! approved     &&
        Severity: Minor
        Found in app/models/team.rb by rubocop

        This cop checks for space after !.

        Example:

        # bad
! something

# good
!something
        Severity
        Category
        Status
        Source
        Language