Sign upLogin

colinschoen/enrollme

View on GitHub
Star
script/clock.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

  if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or 
      (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
    puts "Sending Emails to Admins..."
    AdminMailer.send_look_at_submission
    puts "done."
Severity: Critical
Found in script/clock.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

      if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
      (time.month == 11 and time.day > 15) or time.month == 12)
    puts "Sending Emails to Admins..."
    AdminMailer.send_look_at_submission
    puts "done."
    Severity: Major
    Found in script/clock.rb - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if ((time.month == 8 and time.day > 15) or time.month == 9 or
      time.month == 1 or (time.month == 2 and time.day <= 20))
    puts "Sending Emails to Admins..."
    AdminMailer.send_look_at_submission
    puts "done."
      Severity: Major
      Found in script/clock.rb - About 40 mins to fix

        Trailing whitespace detected.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Use || instead of or.
        Open

              (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

          if ((time.month == 8 and time.day > 15) or time.month == 9 or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use the new Ruby 1.9 hash syntax.
        Open

        every(7.days, 'Send Pending Teams Emails to Admins, Phase I', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks hash literal syntax.

        It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

        A separate offense is registered for each problematic pair.

        The supported styles are:

        • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
        • hash_rockets - forces use of hash rockets for all hashes
        • nomixedkeys - simply checks for hashes with mixed syntaxes
        • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

        Example: EnforcedStyle: ruby19 (default)

        # bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

        Example: EnforcedStyle: hash_rockets

        # bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

        Example: EnforcedStyle: nomixedkeys

        # bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

        Example: EnforcedStyle: ruby19nomixed_keys

        # bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

        Line is too long. [124/80]
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        Line is too long. [84/80]
        Open

          if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        Avoid using {...} for multi-line blocks.
        Open

        every(7.days, 'Send Pending Teams Emails to Admins, Phase I', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        Check for uses of braces or do/end around single line or multi-line blocks.

        Example: EnforcedStyle: linecountbased (default)

        # bad - single line block
items.each do |item| item / 5 end

# good - single line block
items.each { |item| item / 5 }

# bad - multi-line block
things.map { |thing|
  something = thing.some_method
  process(something)
}

# good - multi-line block
things.map do |thing|
  something = thing.some_method
  process(something)
end

        Example: EnforcedStyle: semantic

        # Prefer `do...end` over `{...}` for procedural blocks.

# return value is used/assigned
# bad
foo = map do |x|
  x
end
puts (map do |x|
  x
end)

# return value is not used out of scope
# good
map do |x|
  x
end

# Prefer `{...}` over `do...end` for functional blocks.

# return value is not used out of scope
# bad
each { |x|
  x
}

# return value is used/assigned
# good
foo = map { |x|
  x
}
map { |x|
  x
}.inspect

        Example: EnforcedStyle: bracesforchaining

        # bad
words.each do |word|
  word.flip.flop
end.join("-")

# good
words.each { |word|
  word.flip.flop
}.join("-")

        Avoid using {...} for multi-line blocks.
        Open

        every(1.day, 'Send Pending Teams Emails to Admins, Adjustment Period', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        Check for uses of braces or do/end around single line or multi-line blocks.

        Example: EnforcedStyle: linecountbased (default)

        # bad - single line block
items.each do |item| item / 5 end

# good - single line block
items.each { |item| item / 5 }

# bad - multi-line block
things.map { |thing|
  something = thing.some_method
  process(something)
}

# good - multi-line block
things.map do |thing|
  something = thing.some_method
  process(something)
end

        Example: EnforcedStyle: semantic

        # Prefer `do...end` over `{...}` for procedural blocks.

# return value is used/assigned
# bad
foo = map do |x|
  x
end
puts (map do |x|
  x
end)

# return value is not used out of scope
# good
map do |x|
  x
end

# Prefer `{...}` over `do...end` for functional blocks.

# return value is not used out of scope
# bad
each { |x|
  x
}

# return value is used/assigned
# good
foo = map { |x|
  x
}
map { |x|
  x
}.inspect

        Example: EnforcedStyle: bracesforchaining

        # bad
words.each do |word|
  word.flip.flop
end.join("-")

# good
words.each { |word|
  word.flip.flop
}.join("-")

        Use || instead of or.
        Open

          if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use || instead of or.
        Open

          if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

          if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Trailing whitespace detected.
        Open
        Severity: Minor
        Found in script/clock.rb by rubocop

        Use || instead of or.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

              (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        include is used at the top level. Use inside class or module.
        Open

        include Clockwork
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

        Example:

        # bad
include M

class C
end

# bad
extend M

class C
end

# bad
prepend M

class C
end

# good
class C
  include M
end

# good
class C
  extend M
end

# good
class C
  prepend M
end

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "Sending Emails to Admins..."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "Sending Emails to Admins..."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Use || instead of or.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Use || instead of or.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use the new Ruby 1.9 hash syntax.
        Open

        every(3.days, 'Send Pending Teams Emails to Admins, Phase II', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks hash literal syntax.

        It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

        A separate offense is registered for each problematic pair.

        The supported styles are:

        • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
        • hash_rockets - forces use of hash rockets for all hashes
        • nomixedkeys - simply checks for hashes with mixed syntaxes
        • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

        Example: EnforcedStyle: ruby19 (default)

        # bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

        Example: EnforcedStyle: hash_rockets

        # bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

        Example: EnforcedStyle: nomixedkeys

        # bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

        Example: EnforcedStyle: ruby19nomixed_keys

        # bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

        Don't use parentheses around the condition of an if.
        Open

          if ((time.month == 8 and time.day > 15) or time.month == 9 or
      time.month == 1 or (time.month == 2 and time.day <= 20))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

        Example:

        # bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

        Trailing whitespace detected.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Trailing whitespace detected.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Don't use parentheses around the condition of an if.
        Open

          if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
      (time.month == 11 and time.day > 15) or time.month == 12)
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

        Example:

        # bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

        Line is too long. [85/80]
        Open

              (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
        Severity: Minor
        Found in script/clock.rb by rubocop

        Use || instead of or.
        Open

              time.month == 1 or (time.month == 2 and time.day <= 20))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use || instead of or.
        Open

          if ((time.month == 8 and time.day > 15) or time.month == 9 or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Put empty method definitions on a single line.
        Open

        def schedule
    
end
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

        Note: A method definition is not considered empty if it contains comments.

        Example: EnforcedStyle: compact (default)

        # bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

        Example: EnforcedStyle: expanded

        # bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "Sending Emails to Admins..."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Line is too long. [88/80]
        Open

        every(1.day, 'Send Pending Teams Emails to Admins, Adjustment Period', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        Use || instead of or.
        Open

          if ((time.month == 8 and time.day > 15) or time.month == 9 or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

              time.month == 1 or (time.month == 2 and time.day <= 20))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            puts "done."
        Severity: Minor
        Found in script/clock.rb by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

        Use && instead of and.
        Open

              (time.month == 11 and time.day > 15) or time.month == 12)
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Avoid using {...} for multi-line blocks.
        Open

        every(3.days, 'Send Pending Teams Emails to Admins, Phase II', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        Check for uses of braces or do/end around single line or multi-line blocks.

        Example: EnforcedStyle: linecountbased (default)

        # bad - single line block
items.each do |item| item / 5 end

# good - single line block
items.each { |item| item / 5 }

# bad - multi-line block
things.map { |thing|
  something = thing.some_method
  process(something)
}

# good - multi-line block
things.map do |thing|
  something = thing.some_method
  process(something)
end

        Example: EnforcedStyle: semantic

        # Prefer `do...end` over `{...}` for procedural blocks.

# return value is used/assigned
# bad
foo = map do |x|
  x
end
puts (map do |x|
  x
end)

# return value is not used out of scope
# good
map do |x|
  x
end

# Prefer `{...}` over `do...end` for functional blocks.

# return value is not used out of scope
# bad
each { |x|
  x
}

# return value is used/assigned
# good
foo = map { |x|
  x
}
map { |x|
  x
}.inspect

        Example: EnforcedStyle: bracesforchaining

        # bad
words.each do |word|
  word.flip.flop
end.join("-")

# good
words.each { |word|
  word.flip.flop
}.join("-")

        Use the new Ruby 1.9 hash syntax.
        Open

        every(1.day, 'Send Pending Teams Emails to Admins, Adjustment Period', :at => '05:00') {
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks hash literal syntax.

        It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

        A separate offense is registered for each problematic pair.

        The supported styles are:

        • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
        • hash_rockets - forces use of hash rockets for all hashes
        • nomixedkeys - simply checks for hashes with mixed syntaxes
        • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

        Example: EnforcedStyle: ruby19 (default)

        # bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

        Example: EnforcedStyle: hash_rockets

        # bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

        Example: EnforcedStyle: nomixedkeys

        # bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

        Example: EnforcedStyle: ruby19nomixed_keys

        # bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

        1 trailing blank lines detected.
        Open

        Severity: Minor
        Found in script/clock.rb by rubocop

        Use || instead of or.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Don't use parentheses around the condition of an if.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or 
      (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

        Example:

        # bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

        Use && instead of and.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

              (time.month == 10 and time.day >= 15) or (time.month == 11 and time.day <= 15))
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Use && instead of and.
        Open

          if ((time.month == 7 and time.day > 15) or (time.month == 8 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        Trailing whitespace detected.
        Open

          if (time.month == 5 or time.month == 6 or (time.month == 4 and time.day >= 15) or (time.month == 7 and time.day <= 15) or
        Severity: Minor
        Found in script/clock.rb by rubocop

        Use || instead of or.
        Open

              (time.month == 11 and time.day > 15) or time.month == 12)
        Severity: Minor
        Found in script/clock.rb by rubocop

        This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

        Example: EnforcedStyle: always (default)

        # bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

        Example: EnforcedStyle: conditionals

        # bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

        There are no issues that match your filters.

        Category
        Status