Sign upLogin

compodoc/ngd

View on GitHub
Star

Showing 70 of 70 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private getModuleBootstrap(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'bootstrap').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
Severity: Major
Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
src/modules/compiler/src/compiler.ts on lines 178..182
src/modules/compiler/src/compiler.ts on lines 200..204
src/modules/compiler/src/compiler.ts on lines 206..210
src/modules/compiler/src/compiler.ts on lines 218..222

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (this.options.outputFormats.indexOf('svg') > -1 && this.options.outputFormats.indexOf('dot') === -1) {
                cleanDot = true;
            }
Severity: Major
Found in src/modules/transformer/src/engines/dot/dot.ts and 2 other locations - About 1 hr to fix
src/modules/transformer/src/engines/dot/dot.ts on lines 125..127
src/modules/transformer/src/engines/dot/dot.ts on lines 128..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (this.options.outputFormats.indexOf('html') > -1 && this.options.outputFormats.indexOf('svg') === -1) {
                cleanSvg = true;
            }
Severity: Major
Found in src/modules/transformer/dist/engines/dot/dot.js and 2 other locations - About 1 hr to fix
src/modules/transformer/dist/engines/dot/dot.js on lines 80..82
src/modules/transformer/dist/engines/dot/dot.js on lines 94..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private getModuleExports(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'exports').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
Severity: Major
Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
src/modules/compiler/src/compiler.ts on lines 178..182
src/modules/compiler/src/compiler.ts on lines 200..204
src/modules/compiler/src/compiler.ts on lines 212..216
src/modules/compiler/src/compiler.ts on lines 218..222

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private getComponentProviders(props: NodeObject[]): Dependencies[] {
        return this.getSymbolDeps(props, 'providers').map((name) => {
            return this.parseDeepIndentifier(name);
        });
    }
Severity: Major
Found in src/modules/compiler/src/compiler.ts and 4 other locations - About 1 hr to fix
src/modules/compiler/src/compiler.ts on lines 178..182
src/modules/compiler/src/compiler.ts on lines 200..204
src/modules/compiler/src/compiler.ts on lines 206..210
src/modules/compiler/src/compiler.ts on lines 212..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (this.options.outputFormats.indexOf('html') > -1 && this.options.outputFormats.indexOf('svg') === -1) {
                cleanSvg = true;
            }
Severity: Major
Found in src/modules/transformer/src/engines/dot/dot.ts and 2 other locations - About 1 hr to fix
src/modules/transformer/src/engines/dot/dot.ts on lines 110..112
src/modules/transformer/src/engines/dot/dot.ts on lines 128..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function compilerHost has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function compilerHost(transpileOptions: any): ts.CompilerHost {
    
    const inputFileName = transpileOptions.fileName || (transpileOptions.jsx ? 'module.tsx' : 'module.ts');

    const compilerHost: ts.CompilerHost = {
Severity: Minor
Found in src/modules/core/src/lang/utilities.ts - About 1 hr to fix

    Function compilerHost has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function compilerHost(transpileOptions) {
    var inputFileName = transpileOptions.fileName || (transpileOptions.jsx ? 'module.tsx' : 'module.ts');
    var compilerHost = {
        getSourceFile: function (fileName) {
            if (fileName.lastIndexOf('.ts') !== -1) {
    Severity: Minor
    Found in src/modules/core/dist/lang/utilities.js - About 1 hr to fix

      Function generateGraph has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          generateGraph(deps) {
        let template = this.preprocessTemplates(this.options);
        let generators = [];

        // Handle svg dependency with dot, and html with svg
      Severity: Minor
      Found in src/modules/transformer/src/engines/dot/dot.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    fs.outputFile(_this.paths.json, JSON.stringify(deps, null, 2), function (error) {
                if (error) {
                    reject(error);
                }
                ngd_core_1.logger.info('creating JSON', _this.paths.json);
        Severity: Major
        Found in src/modules/transformer/dist/engines/dot/dot.js and 1 other location - About 1 hr to fix
        src/modules/transformer/dist/engines/dot/dot.js on lines 213..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    fs.outputFile(_this.paths.html, htmlContent, function (error) {
                if (error) {
                    reject(error);
                }
                ngd_core_1.logger.info('creating HTML', _this.paths.html);
        Severity: Major
        Found in src/modules/transformer/dist/engines/dot/dot.js and 1 other location - About 1 hr to fix
        src/modules/transformer/dist/engines/dot/dot.js on lines 142..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function generateHTML has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private generateHTML() {
        let svgContent = fs.readFileSync(this.paths.svg).toString();
        let cssContent = `
            <style>
                .edge {
        Severity: Minor
        Found in src/modules/transformer/src/engines/dot/dot.ts - About 1 hr to fix

          Function visitNode has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          var visitNode = function (visitedNode, index) {
                    var name = _this.getSymboleName(node);
                    var deps = {};
                    var metadata = decorators[decorators.length - 1];
                    var props = _this.findProps(visitedNode);
          Severity: Minor
          Found in src/modules/compiler/dist/compiler.js - About 1 hr to fix

            Function format has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                Logger.prototype.format = function (level) {
        var args = [];
        for (var _i = 1; _i < arguments.length; _i++) {
            args[_i - 1] = arguments[_i];
        }
            Severity: Minor
            Found in src/modules/core/dist/lang/logger.js - About 1 hr to fix

              Function generateGraph has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  DotEngine.prototype.generateGraph = function (deps) {
        var _this = this;
        var template = this.preprocessTemplates(this.options);
        var generators = [];
        // Handle svg dependency with dot, and html with svg
              Severity: Minor
              Found in src/modules/transformer/dist/engines/dot/dot.js - About 1 hr to fix

                Function constructor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    constructor(options: IOptions) {
        let baseDir = `./${appName}/`;

        this.options = {
            name: `${appName}`,
                Severity: Minor
                Found in src/modules/transformer/src/engines/dot/dot.ts - About 1 hr to fix

                  Function visitNode has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                  let visitNode = (visitedNode, index) => {
                    let name = this.getSymboleName(node);
                    let deps: Dependencies = <Dependencies>{};
                    let metadata = decorators[decorators.length - 1];
                    let props = this.findProps(visitedNode);
                  Severity: Minor
                  Found in src/modules/compiler/src/compiler.ts - About 1 hr to fix

                    Function parseProviderConfiguration has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            let parseProviderConfiguration = (o: NodeObject): string => {
            // parse expressions such as:
            // { provide: APP_BASE_HREF, useValue: '/' },
            // or
            // { provide: 'Date', useFactory: (d1, d2) => new Date(), deps: ['d1', 'd2'] }
                    Severity: Minor
                    Found in src/modules/compiler/src/compiler.ts - About 1 hr to fix

                      Function __spreadArray has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                      var __spreadArray = (this && this.__spreadArray) || function (to, from, pack) {
    if (pack || arguments.length === 2) for (var i = 0, l = from.length, ar; i < l; i++) {
        if (ar || !(i in from)) {
            if (!ar) ar = Array.prototype.slice.call(from, 0, i);
            ar[i] = from[i];
                      Severity: Minor
                      Found in src/modules/core/dist/lang/logger.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function buildIdentifierName has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              var buildIdentifierName = function (node, name) {
            if (name === void 0) { name = ''; }
            if (node.expression) {
                name = name ? ".".concat(name) : name;
                var nodeName = _this.unknown;
                      Severity: Minor
                      Found in src/modules/compiler/dist/compiler.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language