Sign upLogin

compodoc/ngd

View on GitHub
Star

Showing 70 of 70 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            fs.outputFile(this.paths.json, JSON.stringify(deps, null, 2), (error) => {
                if (error) {
                    reject(error);
                }
                logger.info('creating JSON', this.paths.json);
Severity: Major
Found in src/modules/transformer/src/engines/dot/dot.ts and 1 other location - About 1 hr to fix
src/modules/transformer/src/engines/dot/dot.ts on lines 277..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            fs.outputFile(this.paths.html, htmlContent, (error) => {
                if (error) {
                    reject(error);
                }
                logger.info('creating HTML', this.paths.html);
Severity: Major
Found in src/modules/transformer/src/engines/dot/dot.ts and 1 other location - About 1 hr to fix
src/modules/transformer/src/engines/dot/dot.ts on lines 178..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function parseProviderConfiguration has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        var parseProviderConfiguration = function (o) {
            // parse expressions such as:
            // { provide: APP_BASE_HREF, useValue: '/' },
            // or
            // { provide: 'Date', useFactory: (d1, d2) => new Date(), deps: ['d1', 'd2'] }
Severity: Minor
Found in src/modules/compiler/dist/compiler.js - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        debug(...args) {
    if(this.silent == false) {
      this.logger(
        this.format(LEVEL.DEBUG, ...args)
      );
    Severity: Major
    Found in src/modules/core/src/lang/logger.ts and 3 other locations - About 50 mins to fix
    src/modules/core/src/lang/logger.ts on lines 38..44
    src/modules/core/src/lang/logger.ts on lines 46..52
    src/modules/core/src/lang/logger.ts on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        error(...args) {
    if(this.silent == false) {
      this.logger(
        this.format(LEVEL.FATAL, ...args)
      );
    Severity: Major
    Found in src/modules/core/src/lang/logger.ts and 3 other locations - About 50 mins to fix
    src/modules/core/src/lang/logger.ts on lines 38..44
    src/modules/core/src/lang/logger.ts on lines 46..52
    src/modules/core/src/lang/logger.ts on lines 68..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        info(...args) {
    if(this.silent == false) {
      this.logger(
        this.format(LEVEL.INFO, ...args)
      );
    Severity: Major
    Found in src/modules/core/src/lang/logger.ts and 3 other locations - About 50 mins to fix
    src/modules/core/src/lang/logger.ts on lines 46..52
    src/modules/core/src/lang/logger.ts on lines 54..60
    src/modules/core/src/lang/logger.ts on lines 68..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        warn(...args) {
    if(this.silent == false) {
      this.logger(
        this.format(LEVEL.WARN, ...args)
      );
    Severity: Major
    Found in src/modules/core/src/lang/logger.ts and 3 other locations - About 50 mins to fix
    src/modules/core/src/lang/logger.ts on lines 38..44
    src/modules/core/src/lang/logger.ts on lines 54..60
    src/modules/core/src/lang/logger.ts on lines 68..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                                if (exclude_1.indexOf(file) < 0) {
                                file = path.join(dir, file);
                                var stat = fs.statSync(file);
                                if (stat && stat.isDirectory()) {
                                    results = results.concat(walk_1(file));
    Severity: Major
    Found in src/modules/cli/dist/cli.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (exclude.indexOf(file) < 0) {
                                file = path.join(dir, file);
                                let stat = fs.statSync(file);
                                if (stat && stat.isDirectory()) {
                                    results = results.concat(walk(file));
      Severity: Major
      Found in src/modules/cli/src/cli.ts - About 45 mins to fix

        Function cleanGeneratedFiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private cleanGeneratedFiles() {
        let removeFile = (path) => {
            return new Promise((resolve, reject) => {
                fs.unlink(path, (error) => {
                    if (error) {
        Severity: Minor
        Found in src/modules/transformer/src/engines/dot/dot.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language