compozed/ops_manager_cli

View on GitHub
lib/ops_manager/appliance_deployment.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class ApplianceDeployment has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class OpsManager::ApplianceDeployment
  extend Forwardable
  attr_reader :config

  def_delegators :pivnet_api, :get_product_releases, :accept_product_release_eula,
Severity: Minor
Found in lib/ops_manager/appliance_deployment.rb - About 3 hrs to fix

    Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        OpsManager.set_conf(:target, config[:ip])
        OpsManager.set_conf(:username, config[:username])
        OpsManager.set_conf(:password, config[:password])
        OpsManager.set_conf(:pivnet_token, config[:pivnet_token])
    Severity: Minor
    Found in lib/ops_manager/appliance_deployment.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          OpsManager.set_conf(:target, config[:ip])
          OpsManager.set_conf(:username, config[:username])
          OpsManager.set_conf(:password, config[:password])
          OpsManager.set_conf(:pivnet_token, config[:pivnet_token])
      Severity: Minor
      Found in lib/ops_manager/appliance_deployment.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status