Sign upLogin

conan-io/conan

View on GitHub
Star
conans/client/runner.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _pipe_os_call has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

    def _pipe_os_call(self, command, stream_output, log_handler, cwd, user_output):

        try:
            # piping both stdout, stderr and then later only reading one will hang the process
            # if the other fills the pip. So piping stdout, and redirecting stderr to stdout,
Severity: Minor
Found in conans/client/runner.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if self._print_commands_to_output:
                            log_handler.write(call_message)
                        return self._pipe_os_call(command, stream_output, log_handler, cwd, user_output)
Severity: Major
Found in conans/client/runner.py - About 45 mins to fix

    Line too long (104 > 100 characters)
    Open

                    if (output is True and not self._output and not log_filepath and self._log_run_to_output
    Severity: Minor
    Found in conans/client/runner.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (102 > 100 characters)
    Open

                            stream_output.write("Logging command output to file '%s'\n" % (log_filepath,))
    Severity: Minor
    Found in conans/client/runner.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (104 > 100 characters)
    Open

                            return self._pipe_os_call(command, stream_output, log_handler, cwd, user_output)
    Severity: Minor
    Found in conans/client/runner.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status