concord-consortium/rigse

View on GitHub

Showing 2,136 of 2,138 total issues

Avoid too many return statements within this method.
Open

            return false
Severity: Major
Found in rails/app/policies/material_shared_policy.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return false
    Severity: Major
    Found in rails/app/policies/material_shared_policy.rb - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return 0;
      Severity: Major
      Found in rails/react-components/src/library/helpers/sort-resources.ts - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return true
        Severity: Major
        Found in rails/app/policies/material_shared_policy.rb - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (isSubset(ES, gradeArray)) { return "ES"; }
          Severity: Major
          Found in rails/react-components/src/library/helpers/standards-helpers.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return "UNKNOWN";
            Severity: Major
            Found in rails/react-components/src/library/helpers/standards-helpers.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                            return "<a href='#' class='prev'>← Previous</a>";
              Severity: Major
              Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            if (this.active) { return "..."; } else { return ""; }
                Severity: Major
                Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                return "<a href='#' class='first'>|&lt;</a>";
                  Severity: Major
                  Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                if (this.active) { return "..."; } else { return ""; }
                    Severity: Major
                    Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return '<span class="disabled">|&lt;</span>';
                      Severity: Major
                      Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                      return "<a href='#' class='last'>&gt;|</a>";
                        Severity: Major
                        Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      if (this.active) { return "   "; } else { return ""; }
                          Severity: Major
                          Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return '<span class="disabled">&gt;|</span>';
                            Severity: Major
                            Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          if (this.active) { return "   "; } else { return ""; }
                              Severity: Major
                              Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                            return '<span class="disabled">Next →</span>';
                                Severity: Major
                                Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                      return (
                                        <>
                                          { offerings.map((offering: any) => <Offering key={offering.id} offering={offering} />) }
                                        </>
                                      );

                                    Avoid too many return statements within this function.
                                    Open

                                                return '<span class="disabled">← Previous</span>';
                                    Severity: Major
                                    Found in rails/react-components/src/library/components/search/pagination.tsx - About 30 mins to fix

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          if(Element.getStyle(this.update, 'display')=='none') this.options.onShow(this.element, this.update);
                                      Severity: Minor
                                      Found in rails/app/assets/javascripts/controls.js and 1 other location - About 30 mins to fix
                                      rails/app/assets/javascripts/controls.js on lines 117..117

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 45.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          updateProps: function() {
                                              if( this.isActive() ) {
                                                  this.updateVisibility();
                                              } else {
                                                  this.destroy();
                                      Severity: Minor
                                      Found in rails/app/assets/javascripts/pie/PIE_uncompressed.js and 1 other location - About 30 mins to fix
                                      rails/app/assets/javascripts/pie/PIE_uncompressed.js on lines 2226..2232

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 45.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language