cosmocode/dokuwiki-plugin-issuelinks

View on GitHub
_test/handleIssueLinkSyntax.test.php

Summary

Maintainability
A
1 hr
Test Coverage

Method test_jiralink_moresyntax has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_jiralink_moresyntax() {
        // arrange
        global $ID;
        $ID = 'testpage2';
        saveWikiText($ID,'page must exist for m_filetime','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php - About 1 hr to fix

    Missing class import via use statement (line '39', column '23').
    Open

                throw new \Exception('sqlite init failed');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '100', column '23').
    Open

                throw new \Exception('sqlite init failed');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '75', column '23').
    Open

                throw new \Exception('sqlite init failed');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Define a constant instead of duplicating this literal "sqlite" 4 times.
    Open

        protected $pluginsEnabled = array('issuelinks', 'sqlite',);
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "testpage2" 5 times.
    Open

            $ID = 'testpage2';
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "helper" 4 times.
    Open

            $db = plugin_load('helper', 'issuelinks_db');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "issue_id" 6 times.
    Open

                    'issue_id' => '281',
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "testpage" 4 times.
    Open

            $ID = 'testpage';
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "test summary" 3 times.
    Open

            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "sqlite init failed" 3 times.
    Open

                throw new \Exception('sqlite init failed');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define and throw a dedicated exception instead of using a generic one.
    Open

                throw new \Exception('sqlite init failed');

    If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

    Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

    Noncompliant Code Example

    throw new Exception();  // Noncompliant
    

    Compliant Solution

    throw new InvalidArgumentException();
    // or
    throw new UnexpectedValueException();
    

    See

    Define a constant instead of duplicating this literal "SELECT page, project_id, issue_id, type FROM pagerev_issues" 3 times.
    Open

            $sql = 'SELECT page, project_id, issue_id, type FROM pagerev_issues';
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "issuelinks/db/" 3 times.
    Open

            if (!$sqliteHelper->init('issuelinks', DOKU_PLUGIN . 'issuelinks/db/')) {
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "project_id" 6 times.
    Open

                    'project_id' => 'SPR',
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "issuelinks" 4 times.
    Open

        protected $pluginsEnabled = array('issuelinks', 'sqlite',);
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
      prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
      execute('action1');
      release('action1');
    }
    

    Compliant Solution

    ACTION_1 = 'action1';
    
    function run() {
      prepare(ACTION_1);
      execute(ACTION_1);
      release(ACTION_1);
    }
    

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define and throw a dedicated exception instead of using a generic one.
    Open

                throw new \Exception('sqlite init failed');

    If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

    Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

    Noncompliant Code Example

    throw new Exception();  // Noncompliant
    

    Compliant Solution

    throw new InvalidArgumentException();
    // or
    throw new UnexpectedValueException();
    

    See

    Define and throw a dedicated exception instead of using a generic one.
    Open

                throw new \Exception('sqlite init failed');

    If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

    Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

    Noncompliant Code Example

    throw new Exception();  // Noncompliant
    

    Compliant Solution

    throw new InvalidArgumentException();
    // or
    throw new UnexpectedValueException();
    

    See

    Call to undeclared function \plugin_load()
    Open

            $db = plugin_load('helper', 'issuelinks_db');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared method \linksyntax_plugin_issuelinks_test::assertEquals
    Open

            $this->assertEquals(array(), $pagerev_issues);
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Reference to undeclared class \DokuWikiTest
    Open

            parent::setUp();
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('[[gh>cosmocode/dokuwiki-plugin-issuelinks#1]]');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('[[jira>SPR-281]]');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \wikiFN()
    Open

            $REV = filemtime(wikiFN($ID))+1;
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('{{jira>SPR-281}}');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Class extends undeclared class \DokuWikiTest
    Open

    class linksyntax_plugin_issuelinks_test extends DokuWikiTest {
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \saveWikiText()
    Open

            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Reference to undeclared constant \DOKU_PLUGIN
    Open

            if (!$sqliteHelper->init('issuelinks', DOKU_PLUGIN . 'issuelinks/db/')) {
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Reference to undeclared constant \DOKU_PLUGIN
    Open

            if (!$sqliteHelper->init('issuelinks', DOKU_PLUGIN . 'issuelinks/db/')) {
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared method \linksyntax_plugin_issuelinks_test::assertEquals
    Open

            $this->assertEquals(array(
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('{{jira>TW-7}}');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('[[jira>TW-7]]');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('[[gl>grosse/project-with-merge-request!1]]');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('[[gl>grosse/project-with-issue#1]]');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \saveWikiText()
    Open

            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \plugin_load()
    Open

            $sqliteHelper = plugin_load('helper', 'sqlite');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \p_get_instructions()
    Open

            p_get_instructions('[[jira>TW-7]]');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared method \linksyntax_plugin_issuelinks_test::assertEquals
    Open

            $this->assertEquals(array(
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Reference to undeclared class \DokuWikiTest
    Open

            parent::tearDown();
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \plugin_load()
    Open

            $sqliteHelper = plugin_load('helper', 'sqlite');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Reference to undeclared constant \DOKU_PLUGIN
    Open

            if (!$sqliteHelper->init('issuelinks', DOKU_PLUGIN . 'issuelinks/db/')) {
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \saveWikiText()
    Open

            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Call to undeclared function \plugin_load()
    Open

            $sqliteHelper = plugin_load('helper', 'sqlite');
    Severity: Critical
    Found in _test/handleIssueLinkSyntax.test.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class linksyntax_plugin_issuelinks_test extends DokuWikiTest {

    Avoid variables with short names like $ID. Configured minimum length is 3.
    Open

            global $ID;
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class linksyntax_plugin_issuelinks_test is not named in CamelCase.
    Open

    class linksyntax_plugin_issuelinks_test extends DokuWikiTest {
    
        protected $pluginsEnabled = array('issuelinks', 'sqlite',);
    
        public function setUp() {
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
    }

    Source

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = plugin_load('helper', 'issuelinks_db');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $ID. Configured minimum length is 3.
    Open

            global $ID, $REV;
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $ID. Configured minimum length is 3.
    Open

            global $ID;
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Opening brace of a class must be on the line after the definition
    Open

    class linksyntax_plugin_issuelinks_test extends DokuWikiTest {

    Method name "linksyntax_plugin_issuelinks_test::test_jiralink_oldrev" is not in camel caps format
    Open

        public function test_jiralink_oldrev() {

    Method name "linksyntax_plugin_issuelinks_test::test_jiralink" is not in camel caps format
    Open

        public function test_jiralink() {

    Method name "linksyntax_plugin_issuelinks_test::test_jiralink_moresyntax" is not in camel caps format
    Open

        public function test_jiralink_moresyntax() {

    No space found after comma in function call
    Open

            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');

    Opening brace should be on a new line
    Open

        public function test_jiralink_oldrev() {

    Opening brace should be on a new line
    Open

        public function test_jiralink_moresyntax() {

    Opening brace should be on a new line
    Open

        public function test_jiralink() {

    Class name "linksyntax_plugin_issuelinks_test" is not in camel caps format
    Open

    class linksyntax_plugin_issuelinks_test extends DokuWikiTest {

    No space found after comma in function call
    Open

            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');

    No space found after comma in function call
    Open

            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');

    No space found after comma in function call
    Open

            saveWikiText($ID,'page must exist for m_filetime','test summary');

    Opening brace should be on a new line
    Open

        public function tearDown() {

    No space found after comma in function call
    Open

            saveWikiText($ID,'page must exist for m_filetime','test summary');

    No space found after comma in function call
    Open

            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');

    Opening brace should be on a new line
    Open

        public function setUp() {

    The variable $pagerev_issues is not named in camelCase.
    Open

        public function test_jiralink() {
            // arrange
            global $ID;
            $ID = 'testpage';
            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $pagerev_issues is not named in camelCase.
    Open

        public function test_jiralink() {
            // arrange
            global $ID;
            $ID = 'testpage';
            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $REV is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink() {
            // arrange
            global $ID;
            $ID = 'testpage';
            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink() {
            // arrange
            global $ID;
            $ID = 'testpage';
            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $pagerev_issues is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_moresyntax() {
            // arrange
            global $ID;
            $ID = 'testpage2';
            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $pagerev_issues is not named in camelCase.
    Open

        public function test_jiralink_moresyntax() {
            // arrange
            global $ID;
            $ID = 'testpage2';
            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_moresyntax() {
            // arrange
            global $ID;
            $ID = 'testpage2';
            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $ID is not named in camelCase.
    Open

        public function test_jiralink_moresyntax() {
            // arrange
            global $ID;
            $ID = 'testpage2';
            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $REV is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $pagerev_issues is not named in camelCase.
    Open

        public function test_jiralink_moresyntax() {
            // arrange
            global $ID;
            $ID = 'testpage2';
            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $pagerev_issues is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The method test_jiralink_oldrev is not named in camelCase.
    Open

        public function test_jiralink_oldrev() {
            // arrange
            global $ID, $REV;
            $ID = 'testpage_oldnew';
            saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method test_jiralink is not named in camelCase.
    Open

        public function test_jiralink() {
            // arrange
            global $ID;
            $ID = 'testpage';
            saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method test_jiralink_moresyntax is not named in camelCase.
    Open

        public function test_jiralink_moresyntax() {
            // arrange
            global $ID;
            $ID = 'testpage2';
            saveWikiText($ID,'page must exist for m_filetime','test summary');
    Severity: Minor
    Found in _test/handleIssueLinkSyntax.test.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status