Sign upLogin

cosmocode/dokuwiki-plugin-issuelinks

View on GitHub
Star

Showing 899 of 899 total issues

File Issue.php has 467 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace dokuwiki\plugin\issuelinks\classes;

/**
Severity: Minor
Found in classes/Issue.php - About 7 hrs to fix

    File GitHub.service.php has 440 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace dokuwiki\plugin\issuelinks\services;

use dokuwiki\Form\Form;
    Severity: Minor
    Found in services/GitHub.service.php - About 6 hrs to fix

      Issue has 45 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Issue extends \DokuWiki_Plugin implements \JsonSerializable
{

    /** @var Issue[] */
    private static $instances = [];
      Severity: Minor
      Found in classes/Issue.php - About 6 hrs to fix

        File GitLab.service.php has 392 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace dokuwiki\plugin\issuelinks\services;

use dokuwiki\Form\Form;
        Severity: Minor
        Found in services/GitLab.service.php - About 5 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function parseMergeRequestDescription($currentProject, $description)
    {
        $issues = [];

        $issueOwnRepoPattern = '/(?:\W|^)#([1-9]\d*)\b/';
          Severity: Major
          Found in services/GitHub.service.php and 1 other location - About 4 hrs to fix
          services/GitLab.service.php on lines 388..414

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 171.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function parseMergeRequestDescription($currentProject, $description)
    {
        $issues = [];

        $issueOwnRepoPattern = '/(?:\W|^)#([1-9]\d*)\b/';
          Severity: Major
          Found in services/GitLab.service.php and 1 other location - About 4 hrs to fix
          services/GitHub.service.php on lines 487..515

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 171.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File Jira.service.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
/**
 * Created by IntelliJ IDEA.
 * User: michael
 * Date: 4/16/18
          Severity: Minor
          Found in services/Jira.service.php - About 3 hrs to fix

            GitHub has 28 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class GitHub extends AbstractService
{


    const SYNTAX = 'gh';
            Severity: Minor
            Found in services/GitHub.service.php - About 3 hrs to fix

              The class GitHub has an overall complexity of 76 which is very high. The configured complexity threshold is 50.
              Open

              class GitHub extends AbstractService
{


    const SYNTAX = 'gh';
              Severity: Minor
              Found in services/GitHub.service.php by phpmd

              The class GitLab has an overall complexity of 68 which is very high. The configured complexity threshold is 50.
              Open

              class GitLab extends AbstractService
{

    const SYNTAX = 'gl';
    const DISPLAY_NAME = 'GitLab';
              Severity: Minor
              Found in services/GitLab.service.php by phpmd

              The class Issue has an overall complexity of 92 which is very high. The configured complexity threshold is 50.
              Open

              class Issue extends \DokuWiki_Plugin implements \JsonSerializable
{

    /** @var Issue[] */
    private static $instances = [];
              Severity: Minor
              Found in classes/Issue.php by phpmd

              The class helper_plugin_issuelinks_db has 11 public methods. Consider refactoring helper_plugin_issuelinks_db to keep number of public methods under 10.
              Open

              class helper_plugin_issuelinks_db extends DokuWiki_Plugin
{
    private $db = null;

    /**
              Severity: Minor
              Found in helper/db.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class helper_plugin_issuelinks_db has an overall complexity of 59 which is very high. The configured complexity threshold is 50.
              Open

              class helper_plugin_issuelinks_db extends DokuWiki_Plugin
{
    private $db = null;

    /**
              Severity: Minor
              Found in helper/db.php by phpmd

              File db.php has 297 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
/**
 * DokuWiki Plugin issuelinks (Helper Component)
 *
 * @license GPL 2 http://www.gnu.org/licenses/gpl-2.0.html
              Severity: Minor
              Found in helper/db.php - About 3 hrs to fix

                GitLab has 26 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class GitLab extends AbstractService
{

    const SYNTAX = 'gl';
    const DISPLAY_NAME = 'GitLab';
                Severity: Minor
                Found in services/GitLab.service.php - About 3 hrs to fix

                  Method buildTooltipHTML has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function buildTooltipHTML()
    {
        $html = '<aside class="issueTooltip">';
        $html .= "<h1 class=\"issueTitle\">{$this->getSummary()}</h1>";
        $html .= "<div class='assigneeAvatar waiting'></div>";
                  Severity: Major
                  Found in classes/Issue.php - About 2 hrs to fix

                    Function buildTooltipHTML has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function buildTooltipHTML()
    {
        $html = '<aside class="issueTooltip">';
        $html .= "<h1 class=\"issueTitle\">{$this->getSummary()}</h1>";
        $html .= "<div class='assigneeAvatar waiting'></div>";
                    Severity: Minor
                    Found in classes/Issue.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Jira has 22 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Jira extends AbstractService
{

    const SYNTAX = 'jira';
    const DISPLAY_NAME = 'Jira';
                    Severity: Minor
                    Found in services/Jira.service.php - About 2 hrs to fix

                      Method importAllIssues has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function importAllIssues($serviceName, $projectKey)
    {
        $lockfileKey = $this->getImportLockID($serviceName, $projectKey);
        if ($this->isImportLocked($lockfileKey)) {
            throw new RuntimeException('Import of Issues is already locked!');
                      Severity: Major
                      Found in helper/data.php - About 2 hrs to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            protected function getTypeFromLabels(array $labels)
    {
        $bugTypeLabels = ['bug'];
        $improvementTypeLabels = ['enhancement'];
        $storyTypeLabels = ['feature'];
                        Severity: Major
                        Found in services/GitLab.service.php and 1 other location - About 1 hr to fix
                        services/GitHub.service.php on lines 414..433

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 119.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language