Sign upLogin

cosmocode/dokuwiki-plugin-issuelinks

View on GitHub
Star
classes/ServiceProvider.php

Summary

Maintainability
A
45 mins
Test Coverage

Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function __construct()
    {
        $serviceDir = __DIR__ . '/../services';
        $filenames = scandir($serviceDir, SCANDIR_SORT_ASCENDING);
        foreach ($filenames as $filename) {
Severity: Minor
Found in classes/ServiceProvider.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method getInstance has a boolean flag argument $forcereload, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getInstance($forcereload = false)
Severity: Minor
Found in classes/ServiceProvider.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Saw a token Phan may have failed to parse after '* @return ServiceInterface[]]': after ServiceInterface[], saw ']'
Open

     * @return ServiceInterface[]]
Severity: Info
Found in classes/ServiceProvider.php by phan

Avoid variables with short names like $ua. Configured minimum length is 3.
Open

            $ua = $className::WEBHOOK_UA;
Severity: Minor
Found in classes/ServiceProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status