Sign upLogin

creof/doctrine2-spatial

View on GitHub
Star

Showing 447 of 447 total issues

Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'setUp'.
Open

        if (! Type::hasType('point')) {
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Platform/PlatformTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method validateArguments uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $value = sprintf('"%s"', $value);
            }
Severity: Minor
Found in lib/CrEOF/Spatial/PHP/Types/AbstractPoint.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$point'.
Open

        $point = new Point(-230, 54);
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geography/PointTest.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'testDoctrineTypeMapping'.
Open

                $type          = Type::getType($doctrineType);
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/SchemaTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$type'.
Open

    public function convertToDatabaseValue(AbstractSpatialType $type, GeometryInterface $value)
Severity: Minor
Found in lib/CrEOF/Spatial/DBAL/Platform/AbstractPlatform.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'setUpTypes'.
Open

            if (! isset(static::$addedTypes[$typeName]) && ! Type::hasType($typeName)) {
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$point'.
Open

        $point = new Point(55, 190);
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geography/PointTest.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$point'.
Open

        $point = new Point(55, -90.00001);
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geography/PointTest.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid assigning values to variables in if clauses and the like (line '126', column '14').
Open

    public function convertToDatabaseValue(AbstractSpatialType $type, GeometryInterface $value)
    {
        $sridSQL = null;

        if ($type instanceof GeographyType && null === $value->getSrid()) {
Severity: Minor
Found in lib/CrEOF/Spatial/DBAL/Platform/PostgreSql.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\Doctrine\ORM\Version' in method 'testTypeWrappingSelect'.
Open

        if (Version::compare('2.5') <= 0) {
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/WrappingTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'setUpTypes'.
Open

                Type::addType($typeName, static::$types[$typeName]);
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'setUpTypes'.
Open

                    $this->getPlatform()->markDoctrineTypeCommented(Type::getType($typeName));
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

getCommonConnectionParameters accesses the super-global variable $GLOBALS.
Open

    protected static function getCommonConnectionParameters()
    {
        $connectionParams = array(
            'driver'   => $GLOBALS['db_type'],
            'user'     => $GLOBALS['db_username'],
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getCommonConnectionParameters accesses the super-global variable $GLOBALS.
Open

    protected static function getCommonConnectionParameters()
    {
        $connectionParams = array(
            'driver'   => $GLOBALS['db_type'],
            'user'     => $GLOBALS['db_username'],
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getCommonConnectionParameters accesses the super-global variable $GLOBALS.
Open

    protected static function getCommonConnectionParameters()
    {
        $connectionParams = array(
            'driver'   => $GLOBALS['db_type'],
            'user'     => $GLOBALS['db_username'],
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getCommonConnectionParameters accesses the super-global variable $GLOBALS.
Open

    protected static function getCommonConnectionParameters()
    {
        $connectionParams = array(
            'driver'   => $GLOBALS['db_type'],
            'user'     => $GLOBALS['db_username'],
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

onNotSuccessfulTest accesses the super-global variable $GLOBALS.
Open

    protected function onNotSuccessfulTest(\Exception $e)
    {
        if (! $GLOBALS['opt_use_debug_stack'] || $e instanceof \PHPUnit_Framework_AssertionFailedError) {
            throw $e;
        }
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Avoid using CrEOF\Spatial\PHP\Types\count() function in for loops.
Open

        for ($i = 0; $i < count($this->points); $i++) {
            $points[] = $this->getPoint($i);
        }
Severity: Minor
Found in lib/CrEOF/Spatial/PHP/Types/AbstractMultiPoint.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Avoid using CrEOF\Spatial\ORM\Query\AST\Functions\count() function in while loops.
Open

        while (count($this->geomExpr) < $this->minGeomExpr || (($this->maxGeomExpr === null || count($this->geomExpr) < $this->maxGeomExpr) && $lexer->lookahead['type'] != Lexer::T_CLOSE_PARENTHESIS)) {
            $parser->match(Lexer::T_COMMA);

            $this->geomExpr[] = $parser->ArithmeticPrimary();
        }
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/AbstractSpatialDQLFunction.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Avoid using CrEOF\Spatial\ORM\Query\AST\Functions\count() function in while loops.
Open

        while (count($this->geomExpr) < $this->minGeomExpr || (($this->maxGeomExpr === null || count($this->geomExpr) < $this->maxGeomExpr) && $lexer->lookahead['type'] != Lexer::T_CLOSE_PARENTHESIS)) {
            $parser->match(Lexer::T_COMMA);

            $this->geomExpr[] = $parser->ArithmeticPrimary();
        }
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/AbstractSpatialDQLFunction.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Severity
Category
Status
Source
Language