Sign upLogin

crowbar/crowbar-ha

View on GitHub
Star
chef/cookbooks/lvm/libraries/provider_lvm_logical_volume.rb

Summary

Maintainability
C
1 day
Test Coverage

Method action_create has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

      def action_create # rubocop:disable MethodLength
        name = new_resource.name
        group = new_resource.group
        fs_type = new_resource.filesystem
        device_name = "/dev/mapper/#{to_dm_name(group)}-#{to_dm_name(name)}"
Severity: Minor
Found in chef/cookbooks/lvm/libraries/provider_lvm_logical_volume.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method action_create has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def action_create # rubocop:disable MethodLength
        name = new_resource.name
        group = new_resource.group
        fs_type = new_resource.filesystem
        device_name = "/dev/mapper/#{to_dm_name(group)}-#{to_dm_name(name)}"
Severity: Major
Found in chef/cookbooks/lvm/libraries/provider_lvm_logical_volume.rb - About 3 hrs to fix

There are no issues that match your filters.

Category
Status