Sign upLogin

crowbar/crowbar-ha

View on GitHub
Star
chef/cookbooks/lvm/libraries/provider_lvm_volume_group.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method action_create has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def action_create
        name = new_resource.name
        physical_volume_list = [new_resource.physical_volumes].flatten

        # Make sure any pvs are not being used as filesystems (e.g. ephemeral0 on
Severity: Minor
Found in chef/cookbooks/lvm/libraries/provider_lvm_volume_group.rb - About 1 hr to fix

Method action_create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def action_create
        name = new_resource.name
        physical_volume_list = [new_resource.physical_volumes].flatten

        # Make sure any pvs are not being used as filesystems (e.g. ephemeral0 on
Severity: Minor
Found in chef/cookbooks/lvm/libraries/provider_lvm_volume_group.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status