Sign upLogin

cse112-sp20/Team-Potato

View on GitHub
Star

Showing 15 of 15 total issues

Function render has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    /** Add those to the current state
     * addGroupModel: decide whether the add group modal pop oopen or not
     * activeTabs: the tabs being active currently on chrome browser
     * tabGroups: the tabGroups the user has created
Severity: Major
Found in src/components/Menu.jsx - About 5 hrs to fix

    Function render has 129 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    /** set the following to be props
     * tabGroupname: the name of the tabgroup to launch focus mode
     * tabGroupUrls: the urls stored in the tabgroup which is to be launched into focus mode
     * hideFocusMode: forbidden other tabgroups to start focus mode
    Severity: Major
    Found in src/components/PopupFocusMode.jsx - About 5 hrs to fix

      File Menu.jsx has 377 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * @fileOverview This file is the menu class which contains tabgroups,
 *               activetabs, and savedtabs. Here included functionalities from
 *               constrcutor, component render, create a new tabgroup, and so on
 *
      Severity: Minor
      Found in src/components/Menu.jsx - About 5 hrs to fix

        Function render has 105 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
    /** add the following to the props
     * name: the name of the tabgroup
     * trackid: uuid for each tabgroup
     * deleteGroup: function to delete a tabgroup
        Severity: Major
        Found in src/components/TabGroup.jsx - About 4 hrs to fix

          Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render() {
    /** update those to the current state
     * shouldDisplayFocusMode: decide whether the focus mode should be displayed or not
     * focusedTabGroupName: the name of the tabgroup that user chose to focus
     * focusedTabGroupUrls: an array of urls stored in the tabgroup that user chose to focus
          Severity: Minor
          Found in src/components/Popup.jsx - About 1 hr to fix

            Function render has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              render() {
    /** add the following to props
     * title: the title of webiste stored in the tab
     * url: the link of the website
     * favIconUrl: the favIcon of the website
            Severity: Minor
            Found in src/components/Tab.jsx - About 1 hr to fix

              Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                constructor(props) {
    super(props);
    TabGroup.propTypes = {
      name: PropTypes.string.isRequired,
      trackid: PropTypes.string.isRequired,
              Severity: Minor
              Found in src/components/TabGroup.jsx - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      chrome.tabs.query({ currentWindow: true, active: true }, (tabs) => {
        chrome.tabs.reload(tabs[0].id);
      });
                Severity: Major
                Found in src/background.js and 1 other location - About 1 hr to fix
                src/background.js on lines 75..77

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      chrome.tabs.query({ currentWindow: true, active: true }, (tabs) => {
        chrome.tabs.remove(tabs[0].id);
      });
                Severity: Major
                Found in src/background.js and 1 other location - About 1 hr to fix
                src/background.js on lines 95..97

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    chrome.storage.sync.get('focusedTabGroupName', (obj) => {
      this.setState({ focusedTabGroupName: obj.focusedTabGroupName });
    });
                Severity: Minor
                Found in src/components/Popup.jsx and 1 other location - About 50 mins to fix
                src/components/Popup.jsx on lines 68..70

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    chrome.storage.sync.get('focusedTabGroupUrls', (obj) => {
      this.setState({ focusedTabGroupUrls: obj.focusedTabGroupUrls });
    });
                Severity: Minor
                Found in src/components/Popup.jsx and 1 other location - About 50 mins to fix
                src/components/Popup.jsx on lines 64..66

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  render() {
    /** add the following to the props
     * name: the name of the tabgroup
     * trackid: uuid for each tabgroup
     * deleteGroup: function to delete a tabgroup
                Severity: Minor
                Found in src/components/TabGroup.jsx - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                            if (i !== deleteIndex) {
              updatedTabs.push({
                title: tabGroups[deleteGroup].tabs[i].title,
                url: tabGroups[deleteGroup].tabs[i].url,
                stored: tabGroups[deleteGroup].tabs[i].stored,
                Severity: Major
                Found in src/components/Menu.jsx - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      } else if (e.target.attributes.getNamedItem('droppable').value !== 'true') {
      /** if not droppable, do nothing */
      e.preventDefault();
      e.dataTransfer.effectAllowed = 'none';
      e.dataTransfer.dropEffect = 'none';
                  Severity: Minor
                  Found in src/components/Menu.jsx and 1 other location - About 35 mins to fix
                  src/components/Menu.jsx on lines 167..243

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (
      e.target === undefined ||
      e.target.attributes.getNamedItem('droppable') === null
    ) {
      /** if invalid, do nothing */
                  Severity: Minor
                  Found in src/components/Menu.jsx and 1 other location - About 35 mins to fix
                  src/components/Menu.jsx on lines 175..243

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language