Sign upLogin

cyberark/secretless-broker

View on GitHub
Star
internal/log/log.go

Summary

Maintainability
B
4 hrs
Test Coverage
A
96%

Logger has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

type Logger struct {
    BackingLogger *stdlib_log.Logger
    IsDebug       bool
    prefix        string
}
Severity: Minor
Found in internal/log/log.go - About 2 hrs to fix

    TODO found
    Open

    // TODO: This duplication is quite hideous, and should be cleaned up by
    Severity: Minor
    Found in internal/log/log.go by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (logger *Logger) panicln(sev severity, args ...interface{}) {
    if !logger.shouldPrint(sev) {
        return
    }
    Severity: Minor
    Found in internal/log/log.go and 1 other location - About 45 mins to fix
    internal/log/log.go on lines 124..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (logger *Logger) logln(sev severity, args ...interface{}) {
    if !logger.shouldPrint(sev) {
        return
    }
    Severity: Minor
    Found in internal/log/log.go and 1 other location - About 45 mins to fix
    internal/log/log.go on lines 160..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package log
    Severity: Minor
    Found in internal/log/log.go by gofmt

    There are no issues that match your filters.

    Category
    Status