Sign upLogin

cyberark/secretless-broker

View on GitHub
Star
internal/plugin/connectors/ssh/proxy_service.go

Summary

Maintainability
A
1 hr
Test Coverage
C
70%

Method proxyService.Start has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Open

func (proxy *proxyService) Start() error {
    logger := proxy.logger

    logger.Infof("Starting service")
Severity: Minor
Found in internal/plugin/connectors/ssh/proxy_service.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

        // TODO: is it possible to use the duplex func to stream ?
Severity: Minor
Found in internal/plugin/connectors/ssh/proxy_service.go by fixme

TODO found
Open

        // TODO: Be able to use secretless.yml-provided host key
Severity: Minor
Found in internal/plugin/connectors/ssh/proxy_service.go by fixme

There are no issues that match your filters.

Category
Status