Sign upLogin

cyberark/secretless-broker

View on GitHub
Star
internal/proxyservice/proxy_service.go

Summary

Maintainability
B
4 hrs
Test Coverage
C
75%

TODO found
Open

    // TODO: Add validation somewhere about overlapping listenOns
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: v2.NetworkAddress is a value type.  It needs to be moved to its
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

            // TODO: Upgrade our logger so we can use Fatalf here
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: Add validation somewhere about overlapping listenOns
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: NewProxyService needs to be injected
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

            // TODO: Add Fatalf to our logger and use that
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

            ConnectorID:              subCfg.Connector, // TODO: Rename connectorID
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: NewProxyService needs to be injected
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

// TODO: move to impl package
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: Add validation somewhere about overlapping listenOns
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: NewTCPProxyFunc needs to be injected
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

// TODO: Reconsider the Resolver design so it's exactly what we need for the new code.
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

            // TODO: Add Fatalf to our logger and use that
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: v2.NetworkAddress is a value type.  It needs to be moved to its
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: v2.NewConfigsByType should be an interface, so we can remove this
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: NewHTTPProxyFunc needs to be injected
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

// TODO: v1.Provider options should be an interface
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: If we want to unit test this, we'll need to inject net.Listen
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

TODO found
Open

    // TODO: v2.NetworkAddress is a value type.  It needs to be moved to its
Severity: Minor
Found in internal/proxyservice/proxy_service.go by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (s *proxyServices) createSSHAgentService(
    config v2.Service,
) (internal.Service, error) {

    // TODO: Add validation somewhere about overlapping listenOns
Severity: Major
Found in internal/proxyservice/proxy_service.go and 1 other location - About 2 hrs to fix
internal/proxyservice/proxy_service.go on lines 213..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 205.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (s *proxyServices) createSSHService(
    config v2.Service,
) (internal.Service, error) {

    // TODO: Add validation somewhere about overlapping listenOns
Severity: Major
Found in internal/proxyservice/proxy_service.go and 1 other location - About 2 hrs to fix
internal/proxyservice/proxy_service.go on lines 246..277

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 205.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status